[Bugs] [Bug 1291985] New: store afr pending xattrs as a volume option

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1291985

            Bug ID: 1291985
           Summary: store afr pending xattrs as a volume option
           Product: GlusterFS
           Version: 3.7.6
         Component: replicate
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: ravishankar at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com
        Depends On: 1285152



+++ This bug was initially created as a clone of Bug #1285152 +++

Description of problem:

    Problem:
    When AFR xlator initialises, it uses the name of the client xlators
    below it for storing the pending changelogs (xattrs). This can be
    problem when some other xlator is loaded in between AFR and the client.
    Though that is a trivial 'traverse-graph-till-the-client-and-use-the-name'
    fix in AFR's init(), there are other issues like when there's no client
    xlator at all when, say, AFR is moved to the server side.

    Fix:
    The client xlator names are currenly unique and stored as
    brickinfo->brick_ids. So persist these ids as comma separated values in
    AFR's volume_options and use them as xattr values during init().

--- Additional comment from Ravishankar N on 2015-11-24 23:46:01 EST ---

http://review.gluster.org/#/c/12738/

--- Additional comment from Vijay Bellur on 2015-11-25 04:38:04 EST ---

REVIEW: http://review.gluster.org/12738 (glusterd/afr: store afr pending xattrs
as a volume option) posted (#2) for review on master by Ravishankar N
(ravishankar at redhat.com)

--- Additional comment from Vijay Bellur on 2015-11-27 07:10:19 EST ---

REVIEW: http://review.gluster.org/12738 (glusterd/afr: store afr pending xattrs
as a volume option) posted (#3) for review on master by Ravishankar N
(ravishankar at redhat.com)

--- Additional comment from Vijay Bellur on 2015-11-27 10:18:59 EST ---

REVIEW: http://review.gluster.org/12738 (glusterd/afr: store afr pending xattrs
as a volume option) posted (#4) for review on master by Ravishankar N
(ravishankar at redhat.com)

--- Additional comment from Vijay Bellur on 2015-12-07 07:26:12 EST ---

REVIEW: http://review.gluster.org/12738 (glusterd/afr: store afr pending xattrs
as a volume option) posted (#5) for review on master by Ravishankar N
(ravishankar at redhat.com)

--- Additional comment from Vijay Bellur on 2015-12-08 03:48:23 EST ---

REVIEW: http://review.gluster.org/12738 (glusterd/afr: store afr pending xattrs
as a volume option) posted (#6) for review on master by Ravishankar N
(ravishankar at redhat.com)

--- Additional comment from Vijay Bellur on 2015-12-08 16:47:06 EST ---

REVIEW: http://review.gluster.org/12738 (glusterd/afr: store afr pending xattrs
as a volume option) posted (#7) for review on master by Vijay Bellur
(vbellur at redhat.com)

--- Additional comment from Vijay Bellur on 2015-12-15 12:59:29 EST ---

REVIEW: http://review.gluster.org/12738 (glusterd/afr: store afr pending xattrs
as a volume option) posted (#8) for review on master by Ravishankar N
(ravishankar at redhat.com)

--- Additional comment from Vijay Bellur on 2015-12-16 01:17:18 EST ---

COMMIT: http://review.gluster.org/12738 committed in master by Atin Mukherjee
(amukherj at redhat.com) 
------
commit 6e635284a4411b816d4d860a28262c9e6dc4bd6a
Author: Ravishankar N <ravishankar at redhat.com>
Date:   Wed Nov 25 09:49:19 2015 +0530

    glusterd/afr: store afr pending xattrs as a volume option

    Problem:
    When AFR xlator initialises, it uses the name of the client xlators
    below it for storing the pending changelogs (xattrs). This can be
    problem when some other xlator is loaded in between AFR and the client.
    Though that is a trivial 'traverse-graph-till-the-client-and-use-the-name'
    fix in AFR's init(), there are other issues like when there's no client
    xlator at all when, say, AFR is moved to the server side.

    Fix:
    The client xlator names are currenly unique and stored as
    brickinfo->brick_ids. So persist these ids as comma separated values in
    AFR's volume_options and use them as xattr values during init().

    Change-Id: Ie761ffeb3373a4c4d85ad05c84a768c4188aa90d
    BUG: 1285152
    Signed-off-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-on: http://review.gluster.org/12738
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Atin Mukherjee <amukherj at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1285152
[Bug 1285152] store afr pending xattrs as a volume option
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.