[Bugs] [Bug 1292254] New: hook script for CTDB should not change Samba config

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1292254

            Bug ID: 1292254
           Summary: hook script for CTDB should not change Samba config
           Product: GlusterFS
           Version: 3.7.6
         Component: scripts
          Keywords: Triaged
          Severity: medium
          Priority: medium
          Assignee: bugs at gluster.org
          Reporter: madam at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com,
                    hgowtham at redhat.com
        Depends On: 1290151



+++ This bug was initially created as a clone of Bug #1290151 +++

There are several reasons why the behaviour in
the hook scripts was bad:

1. A samba installation is clustered or non-clustered.
   That does not change because of the availability
   of the CTDB lock-volume. If the lock-volume is not
   available (and hence CTDB is not available or not
   healthy), then Samba won't be operational. But turning
   it into a non-clustered Samba-installation can in
   the worst case lead to data corruption if clients
   manage to access the same files (on share volumes).
   Hence 'clustering = yes/no' in Samba's config should
   not be touched.

   In particular, Samba should not be stopped/started by
   the hook script. If needed, then ctdb will take care
   of it.

2. Changing the idmap configuration is potentially
   dangerous as well. In particular the used tdb2
   backend is legacy nowadays and should not be used
   any more in new installs. (I stems from the times
   when ctdb could not host persistent databases.)
   Changing the idmap can result in loss of access
   to files or in giving access to files where it is
   not intended.

3. The pattern used for detecting need for change is
   fragile. It may or may not play well possible
   manual changes to smb.conf.

Hence the hook scripts should be changed not to do this.

--- Additional comment from Vijay Bellur on 2015-12-09 13:37:26 EST ---

REVIEW: http://review.gluster.org/12930 (hook-scripts: don't let ctdb script
change samba config) posted (#1) for review on master by Michael Adam
(obnox at samba.org)

--- Additional comment from Vijay Bellur on 2015-12-10 01:11:42 EST ---

REVIEW: http://review.gluster.org/12930 (hook-scripts: don't let ctdb script
change samba config) posted (#2) for review on master by Michael Adam
(obnox at samba.org)

--- Additional comment from Vijay Bellur on 2015-12-10 04:31:06 EST ---

REVIEW: http://review.gluster.org/12930 (hook-scripts: don't let ctdb script
change samba config) posted (#3) for review on master by Michael Adam
(obnox at samba.org)

--- Additional comment from Vijay Bellur on 2015-12-16 14:13:45 EST ---

COMMIT: http://review.gluster.org/12930 committed in master by Raghavendra
Talur (rtalur at redhat.com) 
------
commit 27c16d6da82876a689dfba53b8d45c3a3a657954
Author: Michael Adam <obnox at samba.org>
Date:   Wed Dec 9 18:57:59 2015 +0100

    hook-scripts: don't let ctdb script change samba config

    There are several reasons why the behaviour in
    the hook scripts was bad:

    1. A samba installation is clustered or non-clustered.
       That does not change because of the availability
       of the CTDB lock-volume. If the lock-volume is not
       available (and hence CTDB is not available or not
       healthy), then Samba won't be operational. But turning
       it into a non-clustered Samba-installation can in
       the worst case lead to data corruption if clients
       manage to access the same files (on share volumes).
       Hence 'clustering = yes/no' in Samba's config should
       not be touched.

       In particular, Samba should not be stopped/started by
       the hook script. If needed, then ctdb will take care
       of it.

    2. Changing the idmap configuration is potentially
       dangerous as well. In particular the used tdb2
       backend is legacy nowadays and should not be used
       any more in new installs. (I stems from the times
       when ctdb could not host persistent databases.)
       Changing the idmap can result in loss of access
       to files or in giving access to files where it is
       not intended.

    3. The pattern used for detecting need for change is
       fragile. It may or may not play well possible
       manual changes to smb.conf.

    This change removes the parts that change the smb.conf
    file and start or stop Samba from the S29CTDB* hook scripts.

    Change-Id: I72f7aabafa8f089da4531fca2572a72c22825bcc
    BUG: 1290151
    Signed-off-by: Michael Adam <obnox at samba.org>
    Reviewed-on: http://review.gluster.org/12930
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Raghavendra Talur <rtalur at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1290151
[Bug 1290151] hook script for CTDB should not change Samba config
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.