[Bugs] [Bug 1291970] Data Tiering: new set of gluster v tier commands not working as expected

bugzilla at redhat.com bugzilla at redhat.com
Wed Dec 16 17:28:33 UTC 2015


https://bugzilla.redhat.com/show_bug.cgi?id=1291970



--- Comment #3 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/12976 committed in release-3.7 by Dan
Lambright (dlambrig at redhat.com) 
------
commit 5f6baf2cb061fd32a35bff2081b8ba966871e39d
Author: hari gowtham <hgowtham at redhat.com>
Date:   Fri Dec 4 18:34:36 2015 +0530

    tier/glusterd : making new tier detach command throw warning

            back port of : http://review.gluster.org/#/c/12883/

    For detach tier, the validation was done using the string "detach-tier"
    but the new commands used has the string "tier". Making the string use
    "tier" to compare, creates problem as the tier status and tier detach
    have the keyword "tier". So tier detach and tier status were separated.
    and strtok was used to prevent the condition from passing when the
    volume name has a substring of "tier". (only the second word from the
    string is got and checked if the feature is tier).

    Problem: new detach tier command doesnt throw warnings like
    "not a tier volume" or " detach tier not started" respectively
    instead it prints empty output.

    Fix: while validate the volume is checked if its a tiered volume
    if yes it is checked if the detach tier is started, else a warning
    is thrown respectively.

    >Change-Id: I94246d53b18ab0e9406beaf459eaddb7c5b766c2
    >BUG: 1288517
    >Signed-off-by: hari gowtham <hgowtham at redhat.com>
    >Reviewed-on: http://review.gluster.org/12883
    >Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    >Tested-by: Gluster Build System <jenkins at build.gluster.com>
    >Reviewed-by: Atin Mukherjee <amukherj at redhat.com>

    Change-Id: I1ac3b6baaec644dbc2025085a7f17abd56ba169d
    BUG: 1291970
    Signed-off-by: hari gowtham <hgowtham at redhat.com>
    Reviewed-on: http://review.gluster.org/12976
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Dan Lambright <dlambrig at redhat.com>
    Tested-by: Dan Lambright <dlambrig at redhat.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.



More information about the Bugs mailing list