[Bugs] [Bug 1290151] New: hook script for CTDB should not change Samba config

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1290151

            Bug ID: 1290151
           Summary: hook script for CTDB should not change Samba config
           Product: GlusterFS
           Version: mainline
         Component: gluster-smb
          Assignee: bugs at gluster.org
          Reporter: madam at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com



There are several reasons why the behaviour in
the hook scripts was bad:

1. A samba installation is clustered or non-clustered.
   That does not change because of the availability
   of the CTDB lock-volume. If the lock-volume is not
   available (and hence CTDB is not available or not
   healthy), then Samba won't be operational. But turning
   it into a non-clustered Samba-installation can in
   the worst case lead to data corruption if clients
   manage to access the same files (on share volumes).
   Hence 'clustering = yes/no' in Samba's config should
   not be touched.

   In particular, Samba should not be stopped/started by
   the hook script. If needed, then ctdb will take care
   of it.

2. Changing the idmap configuration is potentially
   dangerous as well. In particular the used tdb2
   backend is legacy nowadays and should not be used
   any more in new installs. (I stems from the times
   when ctdb could not host persistent databases.)
   Changing the idmap can result in loss of access
   to files or in giving access to files where it is
   not intended.

3. The pattern used for detecting need for change is
   fragile. It may or may not play well possible
   manual changes to smb.conf.

Hence the hook scripts should be changed not to do this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.