[Bugs] [Bug 1283211] check_host_list() should be more robust

bugzilla at redhat.com bugzilla at redhat.com
Tue Dec 1 19:24:38 UTC 2015


https://bugzilla.redhat.com/show_bug.cgi?id=1283211



--- Comment #6 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/12588 committed in master by Kaleb KEITHLEY
(kkeithle at redhat.com) 
------
commit de9c322dfbe5c4f9da65fbe0eef443440eafbbdc
Author: Cedric Buissart <cbuissar at redhat.com>
Date:   Mon Nov 16 15:32:29 2015 +0100

    glusterd-ganesha xlator parser for ganesha-ha.conf

    The current method for parsing ganesha-ha.conf is prone to issues :
    Before the patch :
    - no double quote leads to segfault
       e.g. : HA_CLUSTER_NODES=server1,server2
    - no check for comments.
       e.g. : #HA_CLUSTER_NODES="server1,server2"
          would be used if preceding the real value

    This is an attempt to a cleaner parser:
    1- factorization of parsing code, creating 1 dedicated, more generic
    parser
    2- double quote are no longer mandatory
    3- should not segfault
    4- lines are no longer limited to 1024 chars

    Resolves RHBZ 1283211

    Change-Id: I75f11461fe1b84915d1c5cfe945b47bd81abc2b1
    BUG: 1283211
    Signed-off-by: Cedric Buissart <cbuissar at redhat.com>
    Reviewed-on: http://review.gluster.org/12588
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: jiffin tony Thottan <jthottan at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TNMynEGQNV&a=cc_unsubscribe


More information about the Bugs mailing list