[Bugs] [Bug 1215547] New: 'volume get' invoked on a non-existing key fails with zero as a return value

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1215547

            Bug ID: 1215547
           Summary: 'volume get' invoked on a non-existing key fails with
                    zero as a return value
           Product: GlusterFS
           Version: 3.7.0
         Component: cli
          Severity: medium
          Assignee: bugs at gluster.org
          Reporter: amukherj at redhat.com
                CC: amukherj at redhat.com, bugs at gluster.org,
                    gluster-bugs at redhat.com, sasundar at redhat.com
        Depends On: 1211132



+++ This bug was initially created as a clone of Bug #1211132 +++

Description of problem:
-----------------------
'volume get' invoked on a non-existing key returns zero as a return value

Version-Release number of selected component (if applicable):
--------------------------------------------------------------
glusterfs-3.7 nightly build

How reproducible:
-----------------
Always

Steps to Reproduce:
-------------------
1. Try to get the value of the non-existing key on the volume

(i.e) gluster volume get <vol-name> mykey

Actual results:
---------------
return value ($?) is 0

Expected results:
-----------------
return value should be non-zero, indicating the failure as the key is
non-existent

Additional info:
-----------------
[root@ ~]# gluster volume get repvol mykey
volume get option: failed: Did you mean acl or allow?

[root@ ~]# echo $?
0

This affects automation - where the return value of the command will be checked
for the successful execution of a command

--- Additional comment from Anand Avati on 2015-04-14 02:16:38 EDT ---

REVIEW: http://review.gluster.org/10229 (glusterd: incorrect rsp.op_ret
handling in volume get in cli) posted (#1) for review on master by Atin
Mukherjee (amukherj at redhat.com)

--- Additional comment from Anand Avati on 2015-04-21 04:49:26 EDT ---

REVIEW: http://review.gluster.org/10229 (glusterd: incorrect rsp.op_ret
handling in volume get in cli) posted (#3) for review on master by Atin
Mukherjee (amukherj at redhat.com)

--- Additional comment from Anand Avati on 2015-04-27 01:17:45 EDT ---

COMMIT: http://review.gluster.org/10229 committed in master by Kaushal M
(kaushal at redhat.com) 
------
commit 540fc2829bd63a2fa070c68ed105eb23145df406
Author: Atin Mukherjee <amukherj at redhat.com>
Date:   Mon Apr 13 10:37:55 2015 +0530

    glusterd: incorrect rsp.op_ret handling in volume get in cli

    Change-Id: Iabe99c06166578fc90121e7cfdca4a6a3f5328ae
    BUG: 1211132
    Signed-off-by: Atin Mukherjee <amukherj at redhat.com>
    Reviewed-on: http://review.gluster.org/10229
    Reviewed-by: Niels de Vos <ndevos at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Kaushal M <kaushal at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1211132
[Bug 1211132] 'volume get' invoked on a non-existing key fails with zero as
a return value
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.