[Bugs] [Bug 1214563] New: [FEAT] Trash translator
bugzilla at redhat.com
bugzilla at redhat.com
Thu Apr 23 05:47:51 UTC 2015
https://bugzilla.redhat.com/show_bug.cgi?id=1214563
Bug ID: 1214563
Summary: [FEAT] Trash translator
Product: GlusterFS
Version: 3.7.0
Component: trash-xlator
Keywords: FutureFeature
Severity: medium
Assignee: bugs at gluster.org
Reporter: achiraya at redhat.com
CC: achiraya at redhat.com, asengupt at redhat.com,
bugs at gluster.org, gluster-bugs at redhat.com,
jthottan at redhat.com, vagarwal at redhat.com,
vbellur at redhat.com
Depends On: 1132465
+++ This bug was initially created as a clone of Bug #1132465 +++
Description of problem:
Trash translator is a new feature which is used to store files removed from the
mount point.This bug is to track changes related to trash translator
--- Additional comment from Anand Avati on 2014-08-21 09:02:34 EDT ---
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for
trash translator) posted (#7) for review on master by jiffin tony Thottan
(jthottan at redhat.com)
--- Additional comment from Anand Avati on 2014-09-18 02:07:58 EDT ---
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for
trash translator) posted (#8) for review on master by Anoop C S
(achiraya at redhat.com)
--- Additional comment from Anand Avati on 2014-11-27 06:28:24 EST ---
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for
trash translator) posted (#9) for review on master by Anoop C S
(achiraya at redhat.com)
--- Additional comment from Anand Avati on 2014-12-01 00:35:36 EST ---
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for
trash translator) posted (#10) for review on master by jiffin tony Thottan
(jthottan at redhat.com)
--- Additional comment from Anand Avati on 2014-12-01 03:43:51 EST ---
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for
trash translator) posted (#11) for review on master by jiffin tony Thottan
(jthottan at redhat.com)
--- Additional comment from Anand Avati on 2014-12-01 10:17:11 EST ---
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for
trash translator) posted (#12) for review on master by jiffin tony Thottan
(jthottan at redhat.com)
--- Additional comment from Anand Avati on 2014-12-02 02:23:15 EST ---
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for
trash translator) posted (#13) for review on master by Anoop C S
(achiraya at redhat.com)
--- Additional comment from Anand Avati on 2015-01-28 02:07:40 EST ---
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for
trash translator) posted (#14) for review on master by Anoop C S
(achiraya at redhat.com)
--- Additional comment from Anand Avati on 2015-03-01 06:26:19 EST ---
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for
trash translator) posted (#15) for review on master by jiffin tony Thottan
(jthottan at redhat.com)
--- Additional comment from Anand Avati on 2015-03-02 02:03:22 EST ---
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for
trash translator) posted (#16) for review on master by Anoop C S
(achiraya at redhat.com)
--- Additional comment from Anand Avati on 2015-03-02 09:06:47 EST ---
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for
trash translator) posted (#17) for review on master by Anoop C S
(achiraya at redhat.com)
--- Additional comment from Anand Avati on 2015-03-02 23:48:35 EST ---
REVIEW: http://review.gluster.org/8312 (features/trash : Combined patches for
trash translator) posted (#18) for review on master by Anoop C S
(achiraya at redhat.com)
--- Additional comment from Anand Avati on 2015-03-03 07:43:33 EST ---
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for
trash translator) posted (#19) for review on master by jiffin tony Thottan
(jthottan at redhat.com)
--- Additional comment from Anand Avati on 2015-03-03 13:24:44 EST ---
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for
trash translator) posted (#20) for review on master by jiffin tony Thottan
(jthottan at redhat.com)
--- Additional comment from Anand Avati on 2015-03-09 03:29:53 EDT ---
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for
trash translator) posted (#21) for review on master by Anoop C S
(achiraya at redhat.com)
--- Additional comment from Anand Avati on 2015-03-16 06:36:45 EDT ---
COMMIT: http://review.gluster.org/8312 committed in master by Vijay Bellur
(vbellur at redhat.com)
------
commit 0ef870741a2f49d47a02725aed13a95335a6e42f
Author: Anoop C S <achiraya at redhat.com>
Date: Fri Feb 27 15:14:08 2015 +0530
Features/trash : Combined patches for trash translator
This is the combined patch set for supporting trash feature.
http://www.gluster.org/community/documentation/index.php/Features/Trash
Current patch includes the following features:
* volume set options for enabling trash globally and
exclusively for internal operations like self-heal
and re-balance
* volume set options for setting the eliminate
path, trash directory path and maximum trashable
file size.
* test script for checking the functionality of the
feature
* brief documentation on different aspects of trash
feature.
Change-Id: Ic7486982dcd6e295d1eba0f4d5ee6d33bf1b4cb3
BUG: 1132465
Signed-off-by: Anoop C S <achiraya at redhat.com>
Signed-off-by: Jiffin Tony Thottan <jthottan at redhat.com>
Reviewed-on: http://review.gluster.org/8312
Tested-by: Gluster Build System <jenkins at build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur at redhat.com>
--- Additional comment from Anand Avati on 2015-03-17 07:42:10 EDT ---
REVIEW: http://review.gluster.org/9909 (features/trash: Avoid unnecessary
logging from trash_local_wipe) posted (#1) for review on master by Anoop C S
(achiraya at redhat.com)
--- Additional comment from Anand Avati on 2015-03-18 00:08:02 EDT ---
COMMIT: http://review.gluster.org/9909 committed in master by Vijay Bellur
(vbellur at redhat.com)
------
commit 33944a3eb3b589b1d309826b5f431497924ac3ae
Author: Anoop C S <achiraya at redhat.com>
Date: Tue Mar 17 16:29:53 2015 +0530
features/trash: Avoid unnecessary logging from trash_local_wipe
Even when trash translator is disabled, the following error
is being logged for each unlink/truncate/ftruncate calls.
[...] E [trash.c:221:trash_local_wipe] (--> ...
... ) 0-trash: invalid argument: local
This change replaces GF_VALIDATE_OR_GOTO macro with simple
if condition.
Change-Id: I7e6754cd53ec7c2d84669b6d40d883a2d1eee41e
BUG: 1132465
Signed-off-by: Anoop C S <achiraya at redhat.com>
Reviewed-on: http://review.gluster.org/9909
Reviewed-by: jiffin tony Thottan <jthottan at redhat.com>
Reviewed-by: Vijay Bellur <vbellur at redhat.com>
Tested-by: Vijay Bellur <vbellur at redhat.com>
--- Additional comment from Anand Avati on 2015-03-18 05:35:30 EDT ---
REVIEW: http://review.gluster.org/9926 (features/trash: Handling hardlinks in
trash translator) posted (#1) for review on master by jiffin tony Thottan
(jthottan at redhat.com)
--- Additional comment from Anand Avati on 2015-03-24 03:18:54 EDT ---
COMMIT: http://review.gluster.org/9926 committed in master by Vijay Bellur
(vbellur at redhat.com)
------
commit 191ab5693d3c9a0cdedc66bb24dd5efa535963d9
Author: Jiffin Tony Thottan <jthottan at redhat.com>
Date: Wed Mar 18 14:12:03 2015 +0530
features/trash: Handling hardlinks in trash translator
In the current code of trash translator, file is moved to
trash directory without checking whether it is the last
hardlink.This may lead to inconsistency for a file in that
gluster volume.To avoid those scenarios,so a file is moved
to trash directory only if it is the last hardlink.
Change-Id: Id098e53a2236c6406ef91e6e2599ea2cff9bace3
BUG: 1132465
Signed-off-by: Jiffin Tony Thottan <jthottan at redhat.com>
Reviewed-on: http://review.gluster.org/9926
Reviewed-by: Anoop C S <achiraya at redhat.com>
Tested-by: Gluster Build System <jenkins at build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>
Reviewed-by: Vijay Bellur <vbellur at redhat.com>
--- Additional comment from Anand Avati on 2015-03-24 07:02:10 EDT ---
REVIEW: http://review.gluster.org/9984 (features/trash : Discarding extended
truncate for trash-translator) posted (#1) for review on master by jiffin tony
Thottan (jthottan at redhat.com)
--- Additional comment from Anand Avati on 2015-03-25 01:07:07 EDT ---
REVIEW: http://review.gluster.org/9984 (features/trash : Discarding extended
truncate for trash-translator) posted (#2) for review on master by jiffin tony
Thottan (jthottan at redhat.com)
--- Additional comment from Anand Avati on 2015-03-26 02:44:03 EDT ---
REVIEW: http://review.gluster.org/10002 (features/trash: Removing ftruncate
dead callbacks) posted (#1) for review on master by Anoop C S
(achiraya at redhat.com)
--- Additional comment from Anand Avati on 2015-03-26 02:49:39 EDT ---
REVIEW: http://review.gluster.org/10002 (features/trash: Removing dead
callbacks) posted (#2) for review on master by Anoop C S (achiraya at redhat.com)
--- Additional comment from Anand Avati on 2015-03-26 07:48:11 EDT ---
REVIEW: http://review.gluster.org/9984 (features/trash : Discarding extended
truncate for trash-translator) posted (#3) for review on master by jiffin tony
Thottan (jthottan at redhat.com)
--- Additional comment from Anand Avati on 2015-03-27 03:23:39 EDT ---
REVIEW: http://review.gluster.org/10002 (features/trash: Removing dead
callbacks) posted (#3) for review on master by Anoop C S (achiraya at redhat.com)
--- Additional comment from Anand Avati on 2015-03-27 13:43:33 EDT ---
COMMIT: http://review.gluster.org/10002 committed in master by Vijay Bellur
(vbellur at redhat.com)
------
commit bc71cc39881730c8592718a5045a744387bfaea4
Author: Anoop C S <achiraya at redhat.com>
Date: Thu Mar 26 12:00:39 2015 +0530
features/trash: Removing dead callbacks
Since ftruncate create, mkdir, writev, readv and
unlink calls are being re-directed to corresponding
truncate calls, we no longer need their cbks. So
removing those cbks for now.
Change-Id: I41ecde7093a555b3bf69b66afaa8eca835b4982a
BUG: 1132465
Signed-off-by: Anoop C S <achiraya at redhat.com>
Reviewed-on: http://review.gluster.org/10002
Tested-by: Gluster Build System <jenkins at build.gluster.com>
Reviewed-by: jiffin tony Thottan <jthottan at redhat.com>
Reviewed-by: Vijay Bellur <vbellur at redhat.com>
--- Additional comment from Anand Avati on 2015-03-30 03:48:54 EDT ---
COMMIT: http://review.gluster.org/9984 committed in master by Vijay Bellur
(vbellur at redhat.com)
------
commit 3db5f3a41b7029ce8005d1e1cc01808a15cc6019
Author: Jiffin Tony Thottan <jthottan at redhat.com>
Date: Tue Mar 24 16:29:13 2015 +0530
features/trash : Discarding extended truncate for trash-translator
Change-Id: I5c571cbb2d6da1e95831ec206639926722a9d281
BUG: 1132465
Signed-off-by: Jiffin Tony Thottan <jthottan at redhat.com>
Reviewed-on: http://review.gluster.org/9984
Tested-by: Gluster Build System <jenkins at build.gluster.com>
Reviewed-by: Anoop C S <achiraya at redhat.com>
Reviewed-by: Vijay Bellur <vbellur at redhat.com>
--- Additional comment from Anand Avati on 2015-04-13 06:37:10 EDT ---
REVIEW: http://review.gluster.org/10215 (features/trash : fixing trash dir
option) posted (#1) for review on master by jiffin tony Thottan
(jthottan at redhat.com)
--- Additional comment from Anand Avati on 2015-04-14 01:45:02 EDT ---
REVIEW: http://review.gluster.org/10215 (features/trash : fixing trash dir
option) posted (#2) for review on master by jiffin tony Thottan
(jthottan at redhat.com)
--- Additional comment from Anand Avati on 2015-04-21 02:09:25 EDT ---
REVIEW: http://review.gluster.org/10215 (features/trash : fixing trash dir
option) posted (#3) for review on master by jiffin tony Thottan
(jthottan at redhat.com)
--- Additional comment from Anand Avati on 2015-04-21 04:21:43 EDT ---
REVIEW: http://review.gluster.org/10215 (features/trash : fixing trash dir
option) posted (#4) for review on master by Vijay Bellur (vbellur at redhat.com)
--- Additional comment from Anand Avati on 2015-04-22 09:01:24 EDT ---
REVIEW: http://review.gluster.org/10215 (features/trash : fixing trash dir
option) posted (#5) for review on master by jiffin tony Thottan
(jthottan at redhat.com)
--- Additional comment from Anand Avati on 2015-04-23 01:07:33 EDT ---
COMMIT: http://review.gluster.org/10215 committed in master by Vijay Bellur
(vbellur at redhat.com)
------
commit ee255e239aaa1ed5f6388c48a8919989535f3dcc
Author: Jiffin Tony Thottan <jthottan at redhat.com>
Date: Mon Apr 13 15:23:51 2015 +0530
features/trash : fixing trash dir option
Previously, problem was caused due to buffer overflow of variable used
in the code. This patch fix the same.
Change-Id: I3df5e06044470022f9475d93d33447db35384da2
BUG: 1132465
Signed-off-by: Jiffin Tony Thottan <jthottan at redhat.com>
Reviewed-on: http://review.gluster.org/10215
Tested-by: NetBSD Build System
Tested-by: Gluster Build System <jenkins at build.gluster.com>
Reviewed-by: Anoop C S <achiraya at redhat.com>
Reviewed-by: Vijay Bellur <vbellur at redhat.com>
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1132465
[Bug 1132465] [FEAT] Trash translator
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
More information about the Bugs
mailing list