[Bugs] [Bug 1207624] BitRot :- scrubber is not detecting rotten data and not marking file as 'BAD' file

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1207624



--- Comment #5 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/10118 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit f0cd1d73c63001740cd7691a77df7631c9b8e8dc
Author: Venky Shankar <vshankar at redhat.com>
Date:   Tue Mar 31 15:48:18 2015 +0530

    bitrot/scrub: Scrubber fixes

    This patch fixes a handful of problem with scrubber which
    are detailed below.

    Scrubber used to skip objects for verification due to missing
    fd iterface to fetch versioning extended attributes. Similar
    to the inode interface, an fd based interface in POSIX is now
    introduced.

    Moreover, this patch also fixes potential false reporting by
    scrubber due to:

      An object gets dirtied and signed when scrubber is busy
      calculatingobject checksum. This is fixed by caching the
      signed version when an object is first inspected for
      stalenes, i.e., during pre-compute stage. This version is
      used to verify checksum in the post-compute stage when the
      signatures are compared for possible corruption.

      Side effect of _not_ sending signature length during signing
      resulted in "truncated" signature to be set for an object.
      Now, at the time of signing, the signature length is sent
      and is used in place of invoking strlen() to get signature
      length (which could have possible 00s). The signature length
      itself is not persisted in the signature xattr, but is
      calculated on-the-fly by substracting the xattr length by
      the "structure" header size.

    Some of the log entries are made more meaningful (as and aid
    for debugging).

    Change-Id: I938bee5aea6688d5d99eb2640053613af86d6269
    BUG: 1207624
    Signed-off-by: Venky Shankar <vshankar at redhat.com>
    Reviewed-on: http://review.gluster.org/10118
    Reviewed-by: Raghavendra Bhat <raghavendra at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the Docs Contact for the bug.