[Bugs] [Bug 1201724] Handle the review comments in bit-rot patches

bugzilla at redhat.com bugzilla at redhat.com
Wed Apr 8 06:49:28 UTC 2015


https://bugzilla.redhat.com/show_bug.cgi?id=1201724



--- Comment #4 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/10140 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit 7fb55dbdabf73f9169b0f3021a42fa120d64b373
Author: Venky Shankar <vshankar at redhat.com>
Date:   Mon Apr 6 18:14:53 2015 +0530

    tests/bitrot-stub: Object versioning test(s)

    This patch introduces basic object versioning test(s) which
    is required for bitrot detection to work correctly. Basic
    test(s) such as opening a file in read-only mode, single
    open, multiple open()s are covered on FUSE mount _only_ as
    stub does not support anonymous fds yet. For this reason,
    the test case disables open-behind.

    Actual verification is implemented as a C source which
    makes use of the same on-disk data structures as used by
    the stub code. The data structures are moved to separate
    header file which is included by the test script. Such
    modularization helps in future enhancements to keep the
    version "data type" opaque and provide handful of APIs
    version checking (equal/greater/etc..).

    [
      This is just a start and should grow over time as stub
      is enhanced and codebase matures.
    ]

    Change-Id: Ibee20e65a15b56bbdd59fd2703f9305b115aec7a
    BUG: 1201724
    Signed-off-by: Venky Shankar <vshankar at redhat.com>
    Reviewed-on: http://review.gluster.org/10140
    Reviewed-by: Raghavendra Bhat <raghavendra at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VoVdVRWK6Z&a=cc_unsubscribe


More information about the Bugs mailing list