[Bugs] [Bug 1163543] Fix regression test spurious failures

bugzilla at redhat.com bugzilla at redhat.com
Wed Apr 1 08:49:52 UTC 2015


https://bugzilla.redhat.com/show_bug.cgi?id=1163543



--- Comment #82 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/10053 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit 6d083f47e1399c58da02836f33fdb7d9c31fd689
Author: Jeff Darcy <jdarcy at redhat.com>
Date:   Mon Mar 30 13:22:45 2015 -0400

    tests: fix volume_exists to be used from EXPECT_WITHIN

    Fixes the spurious volume-snapshot-clone.t regression failures.  In
    brief, the problem is that the script wasn't waiting for config commands
    to complete, and would *sometimes* query the status of a volume while
    that volume was still being deleted.

    It turns out that "!" doesn't work properly from EXPECT_WITHIN, so there
    was a choice between changing that or changing volume_exists.  This
    seemed less risky.  Because of code duplication, two instances of the
    function had to be changed, and the other caller (volume-snapshot.t) did
    too.

    Change-Id: I766d4dc7c5b11038ede8e45d9d1f29cd02a622a0
    BUG: 1163543
    Signed-off-by: Jeff Darcy <jdarcy at redhat.com>
    Reviewed-on: http://review.gluster.org/10053
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list