[Bugs] [Bug 1157982] New: [USS]: leak in snapview-client xlator in lookup and readdirp operations as per coverity

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1157982

            Bug ID: 1157982
           Summary: [USS]: leak in snapview-client xlator in lookup and
                    readdirp operations as per coverity
           Product: Red Hat Storage
           Version: 3.0
         Component: gluster-snapshot
          Assignee: rjoseph at redhat.com
          Reporter: rabhat at redhat.com
        QA Contact: storage-qa-internal at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com
        Depends On: 1111552



+++ This bug was initially created as a clone of Bug #1111552 +++

Description of problem:
The system resource will not be reclaimed and reused, reducing the future
availability of the resource.

In svc_readdirp: Leak of memory or pointers to system resources 

In SVC_STACK_UNWIND svc_local_free is called. But svc_local_free just wipes the
contents of local. It is not freeing local. Since frame->local is set to NULL
before unwinding, local is not put back into the mempool as part of
FRAME_DESTROY also.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2014-06-20 06:28:44 EDT ---

REVIEW: http://review.gluster.org/8128 (features/snapview-client: put local
back to mempool after unwind) posted (#1) for review on master by Raghavendra
Bhat (raghavendra at redhat.com)

--- Additional comment from Anand Avati on 2014-06-20 07:15:29 EDT ---

REVIEW: http://review.gluster.org/8128 (features/snapview-client: put local
back to mempool after unwind) posted (#2) for review on master by Raghavendra
Bhat (raghavendra at redhat.com)

--- Additional comment from Anand Avati on 2014-06-23 03:40:07 EDT ---

COMMIT: http://review.gluster.org/8128 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit a6620e3840bad41b84c590116183670cb1819667
Author: Raghavendra Bhat <raghavendra at redhat.com>
Date:   Fri Jun 20 15:54:57 2014 +0530

    features/snapview-client: put local back to mempool after unwind

    Change-Id: I3a709a835b21edf757ee5a1cd04cd9d1c59201dc
    BUG: 1111552
    Signed-off-by: Raghavendra Bhat <raghavendra at redhat.com>
    Reviewed-on: http://review.gluster.org/8128
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>

--- Additional comment from Niels de Vos on 2014-09-22 08:43:25 EDT ---

A beta release for GlusterFS 3.6.0 has been released. Please verify if the
release solves this bug report for you. In case the glusterfs-3.6.0beta1
release does not have a resolution for this issue, leave a comment in this bug
and move the status to ASSIGNED. If this release fixes the problem for you,
leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future.
Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an
"updates-testing" repository) infrastructure for your distribution.

[1]
http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1111552
[Bug 1111552] [USS]: leak in snapview-client xlator in lookup and readdirp
operations as per coverity
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jV2lHVbJXB&a=cc_unsubscribe