[Bugs] [Bug 1151004] [USS]: deletion and creation of snapshots with same name causes problems

bugzilla at redhat.com bugzilla at redhat.com
Tue Oct 28 07:08:14 UTC 2014


https://bugzilla.redhat.com/show_bug.cgi?id=1151004



--- Comment #3 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/8917 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit 1fa3e87db77bb379173723a5e75b361a8e192f09
Author: Raghavendra Bhat <raghavendra at redhat.com>
Date:   Thu Oct 9 17:32:48 2014 +0530

    features/snapview-server: check if the reference to the snapshot world is
    correct before doing any fop

    The following operations might lead to problems:
    * Create a file on the glusterfs mount point
    * Create a snapshot (say "snap1")
    * Access the contents of the snapshot
    * Delete the file from the mount point
    * Delete the snapshot "snap1"
    * Create a new snapshot "snap1"

    Now accessing the new snapshot "snap1" gives problems. Because the inode
and
    dentry created for snap1 would not be deleted upon the deletion of the
snapshot
    (as deletion of snapshot is a gluster cli operation, not a fop). So next
time
    upon creation of a new snap with same name, the previous inode and dentry
itself
    will be used. But the inode context contains old information about the
glfs_t
    instance and the handle in the gfapi world. Directly accessing them without
    proper check leads to ENOTCONN errors. Thus the glfs_t instance should be
    checked before accessing. If its wrong, then right instance should be
obtained
    by doing the lookup.

    Change-Id: Idca0c8015ff632447cea206a4807d8ef968424fa
    BUG: 1151004
    Signed-off-by: Raghavendra Bhat <raghavendra at redhat.com>
    Reviewed-on: http://review.gluster.org/8917
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yVPgpnNFyN&a=cc_unsubscribe


More information about the Bugs mailing list