[Bugs] [Bug 1149943] New: duplicate librsync code should likely be linked removed and linked as a library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1149943

            Bug ID: 1149943
           Summary: duplicate librsync code should likely be linked
                    removed and linked as a library
           Product: GlusterFS
           Version: mainline
         Component: core
          Assignee: gluster-bugs at redhat.com
          Reporter: wmealing at redhat.com
                CC: bugs at gluster.org



Description of problem:


I've noticed that there is some code in the glusterfs (
libglusterfs/src/checksum.c ) that looks to be lifted rom the librsync code.  

Is there anything obvious on why this was done, and not directly linked to
librsync ?

I see it from this commit:

> commit 239d2cbdb0a4c32df9f21de8385e2c466b934178
> Author: Vikas Gorur <vikas at gluster.com>
> Date:   Thu Sep 17 05:56:24 2009 +0000
>
>      libglusterfs: Add checksum functions.
>
>      gf_rsync_weak_checksum:   Calculates a simple 32-bit checksum.
>      gf_rsync_strong_checksum: Calculates the MD5 checksum.
>
>      The strong checksum function makes use of Christophe Devine's
>      MD5 implementation (adapted from the rsync source code,
>      version 3.0.6. <http://www.samba.org/ftp/rsync/>).
>

I don't know why this wasn't just linked as a C library, however due to
maintainability and future proofing this product we should extract this code
and link to the relevant librsync library.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nkiZpxv4mK&a=cc_unsubscribe