[Bugs] [Bug 1140556] Core: client crash while doing rename operations on the mount

bugzilla at redhat.com bugzilla at redhat.com
Wed Oct 1 10:37:44 UTC 2014


https://bugzilla.redhat.com/show_bug.cgi?id=1140556



--- Comment #4 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/8733 committed in release-3.5 by Niels de Vos
(ndevos at redhat.com) 
------
commit 66ebbb55918645928bc479c0e723f035a4c1ec11
Author: Raghavendra G <rgowdapp at redhat.com>
Date:   Thu Sep 11 14:23:44 2014 +0530

    cluster/dht: fix memory corruption in locking api.

    <man 3 qsort>

         The  contents  of the array are sorted in ascending order
         according to a comparison function pointed to by compar, which is
         called with two arguments that "point to the objects being
         compared".

    </man 3 qsort>

    qsort passes "pointers to members of the array" to comparision
    function. Since the members of the array happen to be (dht_lock_t *),
    the arguments passed to dht_lock_request_cmp are of type (dht_lock_t
    **). Previously we assumed them to be of type (dht_lock_t *), which
    resulted in memory corruption.

    Change-Id: Iee0758704434beaff3c3a1ad48d549cbdc9e1c96
    BUG: 1140556
    Signed-off-by: Raghavendra G <rgowdapp at redhat.com>
    Reviewed-on: http://review.gluster.org/8659
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Shyamsundar Ranganathan <srangana at redhat.com>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>
    (cherry picked from commit ed4a754f7b6b103b23b2c3e29b8b749cd9db89f3)
    Signed-off-by: Nithya Balachandran <nbalacha at redhat.com>
    Reviewed-on: http://review.gluster.org/8733
    Reviewed-by: Niels de Vos <ndevos at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5TibS6MeDR&a=cc_unsubscribe


More information about the Bugs mailing list