[automated-testing] Glusto-tests code quality

[Yaniv Kaul]

On Fri, Mar 29, 2019 at 8:38 AM Vijay Bhaskar Reddy Avuthu <
vavuthu at redhat.com> wrote:

> Thanks Yaniv for pointing out the typos. We follow flake8 and pylint.
> As soon as patch is submitted, Gluster Build System will run both flake8
> and pylint. If it fails Build System will give -1
> Before merging the patch, we run the test case in upstream through "/run
> tests"
>

Thanks.
Is there a simple way to apply the same flake8 and pylint rules on your
code, before submitting a patch?
I see there's a .pylintrc in the repository, any instructions for flake8?
TIA,
Y.

>
> Regards,
> Vijay A
>
> On Thu, Mar 28, 2019 at 7:24 PM Yaniv Kaul <ykaul at redhat.com> wrote:
>
>> 1. There are several typos in the messages. Would be nice to fix (I'll
>> send a patch to those I stumble upon)
>> 2. Do we have some code convention? Flake8, pep8, pylint?
>> 3. Is there some CI, to ensure changes do not break tests?
>>
>> TIA,
>> Y.
>> _______________________________________________
>> automated-testing mailing list
>> automated-testing at gluster.org
>> https://lists.gluster.org/mailman/listinfo/automated-testing
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gluster.org/pipermail/automated-testing/attachments/20190329/34b4d699/attachment.html>