[automated-testing] Supporting GD2 & GD1 in glusto-tests

[Nigel Babu]

Do you have a PoC that we can play with some time next week?

On Thu, Jul 26, 2018 at 6:54 PM Vijay Bhaskar Reddy Avuthu <
vavuthu at redhat.com> wrote:

> yes, we need to override all the necessary functions keeping the other
> function untouched. In other words it is replicate of non-GD2 libs with
> only changes needed for GD2 functions.
>
> Any other approach to support both GD2 and non-GD2
>
> Regards,
> Vijay A
>
> On Thu, Jul 26, 2018 at 2:07 PM, Nigel Babu <nigelb at redhat.com> wrote:
>
>> Hang on, when you try to create a file inside this new folder, you can't
>> override one function, you have to override all the functions in that
>> folder. That's a lot of code duplication. Is that the best idea forward
>> here?
>>
>> On Thu, Jul 26, 2018 at 12:46 PM Nigel Babu <nigelb at redhat.com> wrote:
>>
>>> This seems like an incredibly tricky way to do it. I can certainly see
>>> the benefits. I'm a little hesitant to try this approach because it means
>>> copying the entire function over for an override and making small changes.
>>>
>>> Either way, the challenge is going to be making sure that changes are in
>>> sync for GD2 and non-GD2 tests. Perhaps this is a better approach since you
>>> can land changes to both in one commit.
>>>
>>> On Thu, Jul 12, 2018 at 12:18 PM Vijay Bhaskar Reddy Avuthu <
>>> vavuthu at redhat.com> wrote:
>>>
>>>> I think both cli commands and syntax is changed.
>>>>
>>>> Can we create another directory for GD2 in glusto-tests like below
>>>>
>>>> "glusto-tests/gd2_libs/glustolibs/gluster/"
>>>>
>>>> If we need to run the test cases on gd2 setup, then we need to install
>>>> libraries in gd2_libs on top of usual libs.
>>>>
>>>>
>>>> Regards,
>>>> Vijay A
>>>>
>>>>
>>>>
>>>> On Wed, Jul 11, 2018 at 7:30 PM, Jonathan Holloway <
>>>> jholloway at redhat.com> wrote:
>>>>
>>>>> Is the only change in the cli commands the renaming to glustercli, or
>>>>> are some of the commands changing in syntax as well?
>>>>>
>>>>> Cheers,
>>>>> Jonathan
>>>>>
>>>>
>>>>
>>>
>>> --
>>> nigelb
>>>
>>
>>
>> --
>> nigelb
>>
>
>

-- 
nigelb
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gluster.org/pipermail/automated-testing/attachments/20180726/d84a045f/attachment.html>