<div dir="ltr">I am totally fine with v5.5, my suggestion for moving the tag was if we consider calling 5.4 with these two patches.<div><br></div><div>Calling the release as 5.5 is totally OK, and we call it out specifically in our version numbering scheme, as if something is very serious, we can break &#39;release date&#39; train.</div><div><br></div><div>-Amar</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 13, 2019 at 6:13 PM Kaleb Keithley &lt;<a href="mailto:kkeithle@redhat.com">kkeithle@redhat.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">The Version tag should be (considered) immutable. Please don&#39;t move it.<div><br></div><div>If you want to add another tag to help us remember this issue that&#39;s fine.</div><div><br></div><div>The other option which Shyam and I discussed was tagging v5.5.</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 13, 2019 at 8:32 AM Amar Tumballi Suryanarayan &lt;<a href="mailto:atumball@redhat.com" target="_blank">atumball@redhat.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto">We need to tag different commit may be? So the &#39;git checkout v5.4&#39; points to the correct commit?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 13 Mar, 2019, 4:40 PM Shyam Ranganathan, &lt;<a href="mailto:srangana@redhat.com" target="_blank">srangana@redhat.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Niels, Kaleb,<br>
<br>
We need to respin 5.4 with the 2 additional commits as follows,<br>
<br>
commit a00953ed212a7071b152c4afccd35b92fa5a682a (HEAD -&gt; release-5,<br>
    core: make compute_cksum function op_version compatible<br>
<br>
commit 8fb4631c65f28dd0a5e0304386efff3c807e64a4<br>
    dict: handle STR_OLD data type in xdr conversions<br>
<br>
As the current build breaks rolling upgrades, we had held back on<br>
announcing 5.4 and are now ready with the fixes that can be used to<br>
respin 5.4.<br>
<br>
Let me know if I need to do anything more from my end for help with the<br>
packaging.<br>
<br>
Once the build is ready, we would be testing it out as usual.<br>
<br>
NOTE: As some users have picked up 5.4 the announce would also carry a<br>
notice, that they need to do a downserver upgrade to the latest bits<br>
owing to the patches that have landed in addition to the existing content.<br>
<br>
Thanks,<br>
Shyam<br>
<br>
On 3/5/19 8:59 AM, Shyam Ranganathan wrote:<br>
&gt; On 2/27/19 5:19 AM, Niels de Vos wrote:<br>
&gt;&gt; On Tue, Feb 26, 2019 at 02:47:30PM +0000, <a href="mailto:jenkins@build.gluster.org" rel="noreferrer" target="_blank">jenkins@build.gluster.org</a> wrote:<br>
&gt;&gt;&gt; SRC: <a href="https://build.gluster.org/job/release-new/80/artifact/glusterfs-5.4.tar.gz" rel="noreferrer noreferrer" target="_blank">https://build.gluster.org/job/release-new/80/artifact/glusterfs-5.4.tar.gz</a><br>
&gt;&gt;&gt; HASH: <a href="https://build.gluster.org/job/release-new/80/artifact/glusterfs-5.4.sha512sum" rel="noreferrer noreferrer" target="_blank">https://build.gluster.org/job/release-new/80/artifact/glusterfs-5.4.sha512sum</a><br>
&gt;&gt;<br>
&gt;&gt; Packages for the CentOS Storage SIG are now available for testing.<br>
&gt;&gt; Please try them out and report test results on this list.<br>
&gt;&gt;<br>
&gt;&gt;   # yum install centos-release-gluster<br>
&gt;&gt;   # yum install --enablerepo=centos-gluster5-test glusterfs-server<br>
&gt; <br>
&gt; Due to patch [1] upgrades are broken, so we are awaiting a fix or revert<br>
&gt; of the same before requesting a new build of 5.4.<br>
&gt; <br>
&gt; The current RPMs should hence not be published.<br>
&gt; <br>
&gt; Sanju/Hari, are we reverting this patch so that we can release 5.4, or<br>
&gt; are we expecting the fix to land in 5.4 (as in [2])?<br>
&gt; <br>
&gt; Thanks,<br>
&gt; Shyam<br>
&gt; <br>
&gt; [1] Patch causing regression: <a href="https://review.gluster.org/c/glusterfs/+/22148" rel="noreferrer noreferrer" target="_blank">https://review.gluster.org/c/glusterfs/+/22148</a><br>
&gt; <br>
&gt; [2] Proposed fix on master: <a href="https://review.gluster.org/c/glusterfs/+/22297/" rel="noreferrer noreferrer" target="_blank">https://review.gluster.org/c/glusterfs/+/22297/</a><br>
&gt; _______________________________________________<br>
&gt; maintainers mailing list<br>
&gt; <a href="mailto:maintainers@gluster.org" rel="noreferrer" target="_blank">maintainers@gluster.org</a><br>
&gt; <a href="https://lists.gluster.org/mailman/listinfo/maintainers" rel="noreferrer noreferrer" target="_blank">https://lists.gluster.org/mailman/listinfo/maintainers</a><br>
&gt; <br>
_______________________________________________<br>
maintainers mailing list<br>
<a href="mailto:maintainers@gluster.org" rel="noreferrer" target="_blank">maintainers@gluster.org</a><br>
<a href="https://lists.gluster.org/mailman/listinfo/maintainers" rel="noreferrer noreferrer" target="_blank">https://lists.gluster.org/mailman/listinfo/maintainers</a><br>
</blockquote></div>
_______________________________________________<br>
maintainers mailing list<br>
<a href="mailto:maintainers@gluster.org" target="_blank">maintainers@gluster.org</a><br>
<a href="https://lists.gluster.org/mailman/listinfo/maintainers" rel="noreferrer" target="_blank">https://lists.gluster.org/mailman/listinfo/maintainers</a><br>
</blockquote></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Amar Tumballi (amarts)<br></div></div></div></div></div>