<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Oct 15, 2019 at 10:57 AM Aravinda Vishwanathapura Krishna Murthy <<a href="mailto:avishwan@redhat.com">avishwan@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Centos CI was voting Glusterd2 repo's pull requests.</div><div><br></div><div><a href="https://github.com/gluster/centosci/blob/master/jobs/glusterd2.yml" target="_blank">https://github.com/gluster/centosci/blob/master/jobs/glusterd2.yml</a></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 14, 2019 at 8:31 PM Amar Tumballi <<a href="mailto:amarts@gmail.com" target="_blank">amarts@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 14 Oct, 2019, 5:37 PM Niels de Vos, <<a href="mailto:ndevos@redhat.com" target="_blank">ndevos@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Mon, Oct 14, 2019 at 03:52:30PM +0530, Amar Tumballi wrote:<br>
> Any thoughts on this?<br>
> <br>
> I tried a basic .travis.yml for the unified glusterfs repo I am<br>
> maintaining, and it is good enough for getting most of the tests.<br>
> Considering we are very close to glusterfs-7.0 release, it is good to time<br>
> this after 7.0 release.<br>
<br>
Is there a reason to move to Travis? GitHub does offer integration with<br>
Jenkins, so we should be able to keep using our existing CI, I think?<br></blockquote></div></div></div></blockquote></div></blockquote><div><br></div><div>Yes, we can make use of existing jenkins jobs for GitHub. It needs some config changes in the JJB to get triggered for GitHub pull requests.</div><div><br></div><div>I can start off with basic smoke testing. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Yes, that's true. I tried Travis because I don't have complete idea of Jenkins infra and trying Travis needed just basic permissions from me on repo (it was tried on my personal repo)</div><div dir="auto"><br></div><div dir="auto">Happy to get some help here.</div><div dir="auto"><br></div><div dir="auto">Regards,</div><div dir="auto">Amar</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Niels<br>
<br>
<br>
> <br>
> -Amar<br>
> <br>
> On Thu, Sep 5, 2019 at 5:13 PM Amar Tumballi <<a href="mailto:amarts@gmail.com" rel="noreferrer" target="_blank">amarts@gmail.com</a>> wrote:<br>
> <br>
> > Going through the thread, I see in general positive responses for the<br>
> > same, with few points on review system, and not loosing information when<br>
> > merging the patches.<br>
> ><br>
> > While we are working on that, we need to see and understand how our CI/CD<br>
> > looks like with github migration. We surely need suggestion and volunteers<br>
> > here to get this going.<br>
> ><br>
> > Regards,<br>
> > Amar<br>
> ><br>
> ><br>
> > On Wed, Aug 28, 2019 at 12:38 PM Niels de Vos <<a href="mailto:ndevos@redhat.com" rel="noreferrer" target="_blank">ndevos@redhat.com</a>> wrote:<br>
> ><br>
> >> On Tue, Aug 27, 2019 at 06:57:14AM +0530, Amar Tumballi Suryanarayan<br>
> >> wrote:<br>
> >> > On Tue, Aug 27, 2019 at 12:10 AM Niels de Vos <<a href="mailto:ndevos@redhat.com" rel="noreferrer" target="_blank">ndevos@redhat.com</a>><br>
> >> wrote:<br>
> >> ><br>
> >> > > On Mon, Aug 26, 2019 at 08:36:30PM +0530, Aravinda Vishwanathapura<br>
> >> Krishna<br>
> >> > > Murthy wrote:<br>
> >> > > > On Mon, Aug 26, 2019 at 7:49 PM Joe Julian <<a href="mailto:joe@julianfamily.org" rel="noreferrer" target="_blank">joe@julianfamily.org</a>><br>
> >> wrote:<br>
> >> > > ><br>
> >> > > > > > Comparing the changes between revisions is something<br>
> >> > > > > that GitHub does not support...<br>
> >> > > > ><br>
> >> > > > > It does support that,<br>
> >> > > > > actually._______________________________________________<br>
> >> > > > ><br>
> >> > > ><br>
> >> > > > Yes, it does support. We need to use Squash merge after all review<br>
> >> is<br>
> >> > > done.<br>
> >> > ><br>
> >> > > Squash merge would also combine multiple commits that are intended to<br>
> >> > > stay separate. This is really bad :-(<br>
> >> > ><br>
> >> > ><br>
> >> > We should treat 1 patch in gerrit as 1 PR in github, then squash merge<br>
> >> > works same as how reviews in gerrit are done. Or we can come up with<br>
> >> > label, upon which we can actually do 'rebase and merge' option, which<br>
> >> can<br>
> >> > preserve the commits as is.<br>
> >><br>
> >> Something like that would be good. For many things, including commit<br>
> >> message update squashing patches is just loosing details. We dont do<br>
> >> that with Gerrit now, and we should not do that when using GitHub PRs.<br>
> >> Proper documenting changes is still very important to me, the details of<br>
> >> patches should be explained in commit messages. This only works well<br>
> >> when developers 'force push' to the branch holding the PR.<br>
> >><br>
> >> Niels<br>
> >> _______________________________________________<br>
> >><br>
> >> Community Meeting Calendar:<br>
> >><br>
> >> APAC Schedule -<br>
> >> Every 2nd and 4th Tuesday at 11:30 AM IST<br>
> >> Bridge: <a href="https://bluejeans.com/836554017" rel="noreferrer noreferrer" target="_blank">https://bluejeans.com/836554017</a><br>
> >><br>
> >> NA/EMEA Schedule -<br>
> >> Every 1st and 3rd Tuesday at 01:00 PM EDT<br>
> >> Bridge: <a href="https://bluejeans.com/486278655" rel="noreferrer noreferrer" target="_blank">https://bluejeans.com/486278655</a><br>
> >><br>
> >> Gluster-devel mailing list<br>
> >> <a href="mailto:Gluster-devel@gluster.org" rel="noreferrer" target="_blank">Gluster-devel@gluster.org</a><br>
> >> <a href="https://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer noreferrer" target="_blank">https://lists.gluster.org/mailman/listinfo/gluster-devel</a><br>
> >><br>
> >><br>
<br>
> _______________________________________________<br>
> <br>
> Community Meeting Calendar:<br>
> <br>
> APAC Schedule -<br>
> Every 2nd and 4th Tuesday at 11:30 AM IST<br>
> Bridge: <a href="https://bluejeans.com/118564314" rel="noreferrer noreferrer" target="_blank">https://bluejeans.com/118564314</a><br>
> <br>
> NA/EMEA Schedule -<br>
> Every 1st and 3rd Tuesday at 01:00 PM EDT<br>
> Bridge: <a href="https://bluejeans.com/118564314" rel="noreferrer noreferrer" target="_blank">https://bluejeans.com/118564314</a><br>
> <br>
> Gluster-devel mailing list<br>
> <a href="mailto:Gluster-devel@gluster.org" rel="noreferrer" target="_blank">Gluster-devel@gluster.org</a><br>
> <a href="https://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer noreferrer" target="_blank">https://lists.gluster.org/mailman/listinfo/gluster-devel</a><br>
> <br>
<br>
</blockquote></div></div></div>
_______________________________________________<br>
maintainers mailing list<br>
<a href="mailto:maintainers@gluster.org" target="_blank">maintainers@gluster.org</a><br>
<a href="https://lists.gluster.org/mailman/listinfo/maintainers" rel="noreferrer" target="_blank">https://lists.gluster.org/mailman/listinfo/maintainers</a><br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>regards<br></div>Aravinda VK<br></div></div></div></div></div></div>
_______________________________________________<br>
maintainers mailing list<br>
<a href="mailto:maintainers@gluster.org" target="_blank">maintainers@gluster.org</a><br>
<a href="https://lists.gluster.org/mailman/listinfo/maintainers" rel="noreferrer" target="_blank">https://lists.gluster.org/mailman/listinfo/maintainers</a><br>
</blockquote></div></div>