<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Aug 27, 2019 at 12:10 AM Niels de Vos <<a href="mailto:ndevos@redhat.com">ndevos@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Mon, Aug 26, 2019 at 08:36:30PM +0530, Aravinda Vishwanathapura Krishna Murthy wrote:<br>
> On Mon, Aug 26, 2019 at 7:49 PM Joe Julian <<a href="mailto:joe@julianfamily.org" target="_blank">joe@julianfamily.org</a>> wrote:<br>
> <br>
> > > Comparing the changes between revisions is something<br>
> > that GitHub does not support...<br>
> ><br>
> > It does support that,<br>
> > actually._______________________________________________<br>
> ><br>
> <br>
> Yes, it does support. We need to use Squash merge after all review is done.<br>
<br>
Squash merge would also combine multiple commits that are intended to<br>
stay separate. This is really bad :-(<br>
<br></blockquote><div><br></div><div>We should treat 1 patch in gerrit as 1 PR in github, then squash merge works same as how reviews in gerrit are done. Or we can come up with label, upon which we can actually do 'rebase and merge' option, which can preserve the commits as is.</div><div><br></div><div>-Amar</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Niels<br>
_______________________________________________<br>
maintainers mailing list<br>
<a href="mailto:maintainers@gluster.org" target="_blank">maintainers@gluster.org</a><br>
<a href="https://lists.gluster.org/mailman/listinfo/maintainers" rel="noreferrer" target="_blank">https://lists.gluster.org/mailman/listinfo/maintainers</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Amar Tumballi (amarts)<br></div></div></div></div></div></div>