<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <br>
    <div class="moz-cite-prefix">On 09/12/2018 07:31 PM, Amar Tumballi
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAHxyDdMFd0sax0h5c9f_TPknK_uW5qkZsFohtsfiwn12EVZpLg@mail.gmail.com">
      <div dir="ltr">Top posting:
        <div><br>
        </div>
        <div>All is well at the tip of glusterfs master branch now.</div>
        <div><br>
        </div>
        <div>We will post a postmortem report of events and what went
          wrong in this activity, later.</div>
        <div><br>
        </div>
        <div>With this, Shyam, you can go ahead with release-v5.0
          branching.</div>
        <div><br>
        </div>
        <div>-Amar</div>
        <div class="gmail_extra"><br>
          <div class="gmail_quote">On Wed, Sep 12, 2018 at 6:21 PM, Amar
            Tumballi <span dir="ltr">&lt;<a
                href="mailto:atumball@redhat.com" target="_blank"
                moz-do-not-send="true">atumball@redhat.com</a>&gt;</span>
            wrote:<br>
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex">
              <div dir="ltr"><br>
                <div class="gmail_extra"><br>
                  <div class="gmail_quote"><span>On Wed, Sep 12, 2018 at
                      5:36 PM, Amar Tumballi <span dir="ltr">&lt;<a
                          href="mailto:atumball@redhat.com"
                          target="_blank" moz-do-not-send="true">atumball@redhat.com</a>&gt;</span>
                      wrote:<br>
                      <blockquote class="gmail_quote" style="margin:0 0
                        0 .8ex;border-left:1px #ccc
                        solid;padding-left:1ex">
                        <div dir="ltr"><br>
                          <div class="gmail_extra"><br>
                            <div class="gmail_quote"><span>On Mon, Aug
                                27, 2018 at 8:47 AM, Amar Tumballi <span
                                  dir="ltr">&lt;<a
                                    href="mailto:atumball@redhat.com"
                                    target="_blank"
                                    moz-do-not-send="true">atumball@redhat.com</a>&gt;</span>
                                wrote:<br>
                                <blockquote class="gmail_quote"
                                  style="margin:0 0 0
                                  .8ex;border-left:1px #ccc
                                  solid;padding-left:1ex">
                                  <div dir="ltr"><br>
                                    <div class="gmail_extra"><br>
                                      <div class="gmail_quote"><span>On
                                          Wed, Aug 22, 2018 at 12:35 PM,
                                          Amar Tumballi <span dir="ltr">&lt;<a
href="mailto:atumball@redhat.com" target="_blank" moz-do-not-send="true">atumball@redhat.com</a>&gt;</span>
                                          wrote:<br>
                                          <blockquote
                                            class="gmail_quote"
                                            style="margin:0px 0px 0px
                                            0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
                                            <div dir="ltr">
                                              <p
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-part"
style="box-sizing:border-box;margin:0px 0px
16px;color:rgb(51,51,51);font-family:-apple-system,BlinkMacSystemFont,&quot;Segoe
UI&quot;,Roboto,&quot;Helvetica
                                                Neue&quot;,Helvetica,Arial,sans-serif,&quot;Apple
                                                Color
                                                Emoji&quot;,&quot;Segoe
                                                UI
                                                Emoji&quot;,&quot;Segoe
                                                UI
Symbol&quot;;font-size:16px;letter-spacing:0.35px;text-decoration-style:initial;text-decoration-color:initial">Hi
                                                All,</p>
                                              <p
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-part"
style="box-sizing:border-box;margin:0px 0px
16px;color:rgb(51,51,51);font-family:-apple-system,BlinkMacSystemFont,&quot;Segoe
UI&quot;,Roboto,&quot;Helvetica
                                                Neue&quot;,Helvetica,Arial,sans-serif,&quot;Apple
                                                Color
                                                Emoji&quot;,&quot;Segoe
                                                UI
                                                Emoji&quot;,&quot;Segoe
                                                UI
Symbol&quot;;font-size:16px;letter-spacing:0.35px;text-decoration-style:initial;text-decoration-color:initial">Below
                                                is an update about the
                                                project’s move towards
                                                using clang-formatter
                                                for imposing few
                                                coding-standards.</p>
                                              <p
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-part"
style="box-sizing:border-box;margin:0px 0px
16px;color:rgb(51,51,51);font-family:-apple-system,BlinkMacSystemFont,&quot;Segoe
UI&quot;,Roboto,&quot;Helvetica
                                                Neue&quot;,Helvetica,Arial,sans-serif,&quot;Apple
                                                Color
                                                Emoji&quot;,&quot;Segoe
                                                UI
                                                Emoji&quot;,&quot;Segoe
                                                UI
Symbol&quot;;font-size:16px;letter-spacing:0.35px;text-decoration-style:initial;text-decoration-color:initial">Gluster
                                                project, since inception
                                                followed certain basic
                                                coding standard, which
                                                was (at that time) easy
                                                to follow, and easy to
                                                review.</p>
                                              <p
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-part"
style="box-sizing:border-box;margin:0px 0px
16px;color:rgb(51,51,51);font-family:-apple-system,BlinkMacSystemFont,&quot;Segoe
UI&quot;,Roboto,&quot;Helvetica
                                                Neue&quot;,Helvetica,Arial,sans-serif,&quot;Apple
                                                Color
                                                Emoji&quot;,&quot;Segoe
                                                UI
                                                Emoji&quot;,&quot;Segoe
                                                UI
Symbol&quot;;font-size:16px;letter-spacing:0.35px;text-decoration-style:initial;text-decoration-color:initial">Over
                                                the time, with inclusion
                                                of many more developers
                                                and working with other
                                                communities, as the
                                                coding standards are
                                                different across
                                                projects, we got
                                                different type of code
                                                into source. After
                                                11+years, now is the
                                                time we should be
                                                depending on tool for it
                                                more than ever, and
                                                hence we have decided to
                                                depend on
                                                clang-formatter for
                                                this.</p>
                                              <p
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-part"
style="box-sizing:border-box;margin:0px 0px
16px;color:rgb(51,51,51);font-family:-apple-system,BlinkMacSystemFont,&quot;Segoe
UI&quot;,Roboto,&quot;Helvetica
                                                Neue&quot;,Helvetica,Arial,sans-serif,&quot;Apple
                                                Color
                                                Emoji&quot;,&quot;Segoe
                                                UI
                                                Emoji&quot;,&quot;Segoe
                                                UI
Symbol&quot;;font-size:16px;letter-spacing:0.35px;text-decoration-style:initial;text-decoration-color:initial">Below
                                                are some highlights of
                                                this activity. We expect
                                                each of you to actively
                                                help us in this move, so
                                                it is smooth for all of
                                                us.</p>
                                              <ul
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-part"
style="box-sizing:border-box;margin-top:0px;margin-bottom:16px;padding-left:2em;color:rgb(51,51,51);font-family:-apple-system,BlinkMacSystemFont,&quot;Segoe
UI&quot;,Roboto,&quot;Helvetica
                                                Neue&quot;,Helvetica,Arial,sans-serif,&quot;Apple
                                                Color
                                                Emoji&quot;,&quot;Segoe
                                                UI
                                                Emoji&quot;,&quot;Segoe
                                                UI
Symbol&quot;;font-size:16px;letter-spacing:0.35px;text-decoration-style:initial;text-decoration-color:initial">
                                                <li
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-"
style="box-sizing:border-box">We kickstarted this activity sometime
                                                  around<span> </span><a
href="https://bugzilla.redhat.com/show_bug.cgi?id=1564149"
style="box-sizing:border-box;background-color:transparent;color:rgb(51,122,183);text-decoration:none"
                                                    target="_blank"
                                                    moz-do-not-send="true">April
                                                    2018</a></li>
                                                <li
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-"
style="box-sizing:border-box;margin-top:0.25em">There was a repo created
                                                  for trying out the
                                                  options, and
                                                  validating the code.<span> </span><a
href="https://github.com/nigelbabu/clang-format-sample"
style="box-sizing:border-box;background-color:transparent;color:rgb(51,122,183);text-decoration:none"
                                                    target="_blank"
                                                    moz-do-not-send="true">Link
                                                    to Repo</a></li>
                                                <li
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-"
style="box-sizing:border-box;margin-top:0.25em">Now, with the latest<span> </span><code
style="box-sizing:border-box;font-family:Menlo,Monaco,Consolas,&quot;Courier
New&quot;,monospace;font-size:13.6px;padding:0.2em
0px;background-color:rgba(0,0,0,0.04);border-radius:3px;margin:0px;color:inherit">.clang-format</code><span> </span>file,
                                                  we have made the whole
                                                  GlusterFS codebase
                                                  changes.<span> </span><a
href="https://github.com/nigelbabu/glusterfs"
style="box-sizing:border-box;background-color:transparent;color:rgb(51,122,183);text-decoration:none"
                                                    target="_blank"
                                                    moz-do-not-send="true">The
                                                    change here</a></li>
                                                <li
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-"
style="box-sizing:border-box;margin-top:0.25em">We will be running
                                                  regression with the
                                                  changes, multiple
                                                  times, so we don’t
                                                  want to miss something
                                                  getting in without our
                                                  notice.</li>
                                                <li
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-"
style="box-sizing:border-box;margin-top:0.25em">As it is a very big
                                                  change (Almost 6 lakh
                                                  lines changed), we
                                                  will not put this
                                                  commit through gerrit,
                                                  but directly pushing
                                                  to the repo.</li>
                                                <li
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-"
style="box-sizing:border-box;margin-top:0.25em">Once this patch gets in
                                                  (ETA: 28th August),
                                                  all the pending
                                                  patches needs to go
                                                  through rebase.</li>
                                              </ul>
                                            </div>
                                          </blockquote>
                                          <div><br>
                                          </div>
                                        </span>
                                        <div>All, as Shyam has proposed
                                          to change the branch out date
                                          for release-5.0 as Sept 10th
                                          [1], we are now targeting Sept
                                          7th for this activity.</div>
                                        <div><br>
                                        </div>
                                      </div>
                                    </div>
                                  </div>
                                </blockquote>
                                <div><br>
                                </div>
                              </span>
                              <div>We are finally Done!</div>
                              <div><br>
                              </div>
                              <div>We delayed in by another 4 days to
                                make sure we pass the regression
                                properly with clang changes, and it
                                doesn't break anything.</div>
                              <div><br>
                              </div>
                              <div>Also note, from now, it is always
                                better to format the changes with below
                                command before committing.</div>
                              <div><br>
                              </div>
                              <div> sh$ cd glusterfs-git-repo/</div>
                              <div> sh$ clang-format -i
                                $(list_of_files_changed)</div>
                              <div> sh$ git commit # and usual steps to
                                publish your changes.</div>
                              <div><br>
                              </div>
                              <div>Also note, all the changes which were
                                present earlier, needs to be rebased
                                with clang-format too.</div>
                              <div><br>
                              </div>
                              <div>One of the quick and dirty way to get
                                your changes rebased in the case if your
                                patch is significantly large, is by
                                applying the patches on top of the
                                commit before the clang-changes, and
                                copy the files over, and run
                                clang-format -i on them, and checking
                                the diff. As no code other coding style
                                changes happened, this should work fine.</div>
                              <div><br>
                              </div>
                              <div>Please post if you have any concerns.</div>
                            </div>
                          </div>
                        </div>
                      </blockquote>
                    </span></div>
                </div>
              </div>
            </blockquote>
          </div>
        </div>
      </div>
    </blockquote>
    <br>
    <br>
    What rules does clang impose on function/argument wrapping and
    alignment? I somehow found the new code wrapping to be random and
    highly unreadable. An example of 'before and after' the clang format
    patches went in:
    <a class="moz-txt-link-freetext" href="https://paste.fedoraproject.org/paste/dC~aRCzYgliqucGYIzxPrQ">https://paste.fedoraproject.org/paste/dC~aRCzYgliqucGYIzxPrQ</a>
    Wondering if this is just me or is it some problem of spurious clang
    fixes.<br>
    <br>
    Regards,<br>
    Ravi<br>
    <br>
    <br>
    <blockquote type="cite"
cite="mid:CAHxyDdMFd0sax0h5c9f_TPknK_uW5qkZsFohtsfiwn12EVZpLg@mail.gmail.com">
      <div dir="ltr">
        <div class="gmail_extra">
          <div class="gmail_quote">
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex">
              <div dir="ltr">
                <div class="gmail_extra">
                  <div class="gmail_quote"><span>
                      <blockquote class="gmail_quote" style="margin:0 0
                        0 .8ex;border-left:1px #ccc
                        solid;padding-left:1ex">
                        <div dir="ltr">
                          <div class="gmail_extra">
                            <div class="gmail_quote">
                              <div><br>
                              </div>
                            </div>
                          </div>
                        </div>
                      </blockquote>
                      <div><br>
                      </div>
                    </span>
                    <div>Noticed some glitches! Stand with us till we
                      handle the situation...</div>
                    <div><br>
                    </div>
                    <div>meantime, found that below command for git am
                      works better for applying smaller patches:</div>
                    <div><br>
                    </div>
                    <div> $ <span style="color:rgb(51,51,51);font-family:Menlo,Monaco,Consolas,&quot;Courier New&quot;,monospace;text-align:left;white-space:pre-wrap;background-color:rgb(248,248,248);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">git am --ignore-whitespace --ignore-space-change --reject 0001-patch</span></div>
                    <div><span style="color:rgb(51,51,51);font-family:Menlo,Monaco,Consolas,&quot;Courier New&quot;,monospace;text-align:left;white-space:pre-wrap;background-color:rgb(248,248,248);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">
</span></div>
                    <div><font color="#333333" face="Menlo, Monaco,
                        Consolas, Courier New, monospace"><span style="white-space:pre-wrap;background-color:rgb(248,248,248)">-Amar</span></font></div>
                    <span>
                      <div> </div>
                      <blockquote class="gmail_quote" style="margin:0 0
                        0 .8ex;border-left:1px #ccc
                        solid;padding-left:1ex">
                        <div dir="ltr">
                          <div class="gmail_extra">
                            <div class="gmail_quote">
                              <div>Regards,</div>
                              <div>Amar</div>
                              <span>
                                <div><br>
                                </div>
                                <div> </div>
                                <blockquote class="gmail_quote"
                                  style="margin:0 0 0
                                  .8ex;border-left:1px #ccc
                                  solid;padding-left:1ex">
                                  <div dir="ltr">
                                    <div class="gmail_extra">
                                      <div class="gmail_quote">
                                        <div>[1] - <a
href="https://lists.gluster.org/pipermail/gluster-devel/2018-August/055308.html"
                                            target="_blank"
                                            moz-do-not-send="true">https://lists.gluster.org/pipe<wbr>rmail/gluster-devel/2018-Augus<wbr>t/055308.html</a></div>
                                        <span>
                                          <div> </div>
                                          <blockquote
                                            class="gmail_quote"
                                            style="margin:0px 0px 0px
                                            0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
                                            <div dir="ltr">
                                              <p
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-part"
style="box-sizing:border-box;margin:0px 0px
16px;color:rgb(51,51,51);font-family:-apple-system,BlinkMacSystemFont,&quot;Segoe
UI&quot;,Roboto,&quot;Helvetica
                                                Neue&quot;,Helvetica,Arial,sans-serif,&quot;Apple
                                                Color
                                                Emoji&quot;,&quot;Segoe
                                                UI
                                                Emoji&quot;,&quot;Segoe
                                                UI
Symbol&quot;;font-size:16px;letter-spacing:0.35px;text-decoration-style:initial;text-decoration-color:initial">What
                                                are the next steps:</p>
                                              <ul
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-part"
style="box-sizing:border-box;margin-top:0px;margin-bottom:16px;padding-left:2em;color:rgb(51,51,51);font-family:-apple-system,BlinkMacSystemFont,&quot;Segoe
UI&quot;,Roboto,&quot;Helvetica
                                                Neue&quot;,Helvetica,Arial,sans-serif,&quot;Apple
                                                Color
                                                Emoji&quot;,&quot;Segoe
                                                UI
                                                Emoji&quot;,&quot;Segoe
                                                UI
Symbol&quot;;font-size:16px;letter-spacing:0.35px;text-decoration-style:initial;text-decoration-color:initial">
                                                <li
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-"
style="box-sizing:border-box">The<span> </span><a
                                                    href="https://review.gluster.org/#/c/glusterfs/+/20892"
style="box-sizing:border-box;background-color:transparent;color:rgb(51,122,183);text-decoration:none"
                                                    target="_blank"
                                                    moz-do-not-send="true">patch</a><span> </span>of
                                                  adding<span> </span><code
style="box-sizing:border-box;font-family:Menlo,Monaco,Consolas,&quot;Courier
New&quot;,monospace;font-size:13.6px;padding:0.2em
0px;background-color:rgba(0,0,0,0.04);border-radius:3px;margin:0px;color:inherit">.clang-format</code><span> </span>file
                                                  will get in first</li>
                                                <li
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-"
style="box-sizing:border-box;margin-top:0.25em">Nigel/Infra team will be
                                                  keeping<span> </span><a
href="https://github.com/nigelbabu/glusterfs"
style="box-sizing:border-box;background-color:transparent;color:rgb(51,122,183);text-decoration:none"
                                                    target="_blank"
                                                    moz-do-not-send="true">the
                                                    repo</a><span> </span>with
                                                  all files changed open
                                                  for review till EOD
                                                  27th August, 2018</li>
                                              </ul>
                                            </div>
                                          </blockquote>
                                        </span>
                                        <div>This changes to 05th Sept,
                                          2018</div>
                                        <span>
                                          <div> </div>
                                          <blockquote
                                            class="gmail_quote"
                                            style="margin:0px 0px 0px
                                            0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
                                            <div dir="ltr">
                                              <ul
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-part"
style="box-sizing:border-box;margin-top:0px;margin-bottom:16px;padding-left:2em;color:rgb(51,51,51);font-family:-apple-system,BlinkMacSystemFont,&quot;Segoe
UI&quot;,Roboto,&quot;Helvetica
                                                Neue&quot;,Helvetica,Arial,sans-serif,&quot;Apple
                                                Color
                                                Emoji&quot;,&quot;Segoe
                                                UI
                                                Emoji&quot;,&quot;Segoe
                                                UI
Symbol&quot;;font-size:16px;letter-spacing:0.35px;text-decoration-style:initial;text-decoration-color:initial">
                                                <li
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-"
style="box-sizing:border-box;margin-top:0.25em">Upon passing regression,
                                                  we will push this one
                                                  change to main branch.</li>
                                                <li
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-"
style="box-sizing:border-box;margin-top:0.25em">After that, we will have
                                                  a smoke job to
                                                  validate the coding
                                                  standard as per the<span> </span><code
style="box-sizing:border-box;font-family:Menlo,Monaco,Consolas,&quot;Courier
New&quot;,monospace;font-size:13.6px;padding:0.2em
0px;background-color:rgba(0,0,0,0.04);border-radius:3px;margin:0px;color:inherit">.clang-format</code><span> </span>file,
                                                  which will vote -1 if
                                                  it is not meeting the
                                                  standard.</li>
                                                <li
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-"
style="box-sizing:border-box;margin-top:0.25em">There will be guidelines
                                                  about how to setup
                                                  your own .clang-format
                                                  setup, so while
                                                  sending the patch, it
                                                  gets posted in proper
                                                  format
                                                  <ul
style="box-sizing:border-box;margin-top:0px;margin-bottom:0px;padding-left:2em">
                                                    <li
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-"
style="box-sizing:border-box">This will be provided for both<span> </span><code
style="box-sizing:border-box;font-family:Menlo,Monaco,Consolas,&quot;Courier
New&quot;,monospace;font-size:13.6px;padding:0.2em
0px;background-color:rgba(0,0,0,0.04);border-radius:3px;margin:0px;color:inherit">./rfc.sh</code><span> </span>and<span> </span><code
style="box-sizing:border-box;font-family:Menlo,Monaco,Consolas,&quot;Courier
New&quot;,monospace;font-size:13.6px;padding:0.2em
0px;background-color:rgba(0,0,0,0.04);border-radius:3px;margin:0px;color:inherit">git
                                                        review</code><span> </span>users.</li>
                                                  </ul>
                                                </li>
                                                <li
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-"
style="box-sizing:border-box;margin-top:0.25em">Having clang-formatter
                                                  installed would be
                                                  still optional, but
                                                  there would be high
                                                  chance the smoke would
                                                  fail if not formatted
                                                  right.</li>
                                              </ul>
                                              <p
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-part"
style="box-sizing:border-box;margin:0px 0px
16px;color:rgb(51,51,51);font-family:-apple-system,BlinkMacSystemFont,&quot;Segoe
UI&quot;,Roboto,&quot;Helvetica
                                                Neue&quot;,Helvetica,Arial,sans-serif,&quot;Apple
                                                Color
                                                Emoji&quot;,&quot;Segoe
                                                UI
                                                Emoji&quot;,&quot;Segoe
                                                UI
Symbol&quot;;font-size:16px;letter-spacing:0.35px;text-decoration-style:initial;text-decoration-color:initial">Any
                                                future changes to coding
                                                standard, due to
                                                improvements in
                                                clang-format tool
                                                itself, or due to
                                                developers believing
                                                some other option is
                                                better suited, can be
                                                getting in through
                                                gerrit.</p>
                                              <p
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-part"
style="box-sizing:border-box;margin:0px 0px
16px;color:rgb(51,51,51);font-family:-apple-system,BlinkMacSystemFont,&quot;Segoe
UI&quot;,Roboto,&quot;Helvetica
                                                Neue&quot;,Helvetica,Arial,sans-serif,&quot;Apple
                                                Color
                                                Emoji&quot;,&quot;Segoe
                                                UI
                                                Emoji&quot;,&quot;Segoe
                                                UI
Symbol&quot;;font-size:16px;letter-spacing:0.35px;text-decoration-style:initial;text-decoration-color:initial">Also
                                                note that, we will not
                                                be applying the changes
                                                to<span> </span><code
style="box-sizing:border-box;font-family:Menlo,Monaco,Consolas,&quot;Courier
New&quot;,monospace;font-size:13.6px;padding:0.2em
0px;background-color:rgba(0,0,0,0.04);border-radius:3px;margin:0px;color:inherit">contrib/</code><span> </span>directory,
                                                as that is expected to
                                                be same as corresponding
                                                upstream coding standard
                                                of particular project.
                                                We believe that helps to
                                                make sure we can quickly
                                                check the <span
                                                  style="letter-spacing:0.35px">diff
                                                  with corresponding
                                                  changes really easily.</span></p>
                                              <p
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-part"
style="box-sizing:border-box;margin:0px 0px
16px;color:rgb(51,51,51);font-family:-apple-system,BlinkMacSystemFont,&quot;Segoe
UI&quot;,Roboto,&quot;Helvetica
                                                Neue&quot;,Helvetica,Arial,sans-serif,&quot;Apple
                                                Color
                                                Emoji&quot;,&quot;Segoe
                                                UI
                                                Emoji&quot;,&quot;Segoe
                                                UI
Symbol&quot;;font-size:16px;letter-spacing:0.35px;text-decoration-style:initial;text-decoration-color:initial">Happy
                                                to hear any feedback!</p>
                                              <p
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail-m_2009078242492793560gmail-part"
style="box-sizing:border-box;margin:0px 0px
16px;color:rgb(51,51,51);font-family:-apple-system,BlinkMacSystemFont,&quot;Segoe
UI&quot;,Roboto,&quot;Helvetica
                                                Neue&quot;,Helvetica,Arial,sans-serif,&quot;Apple
                                                Color
                                                Emoji&quot;,&quot;Segoe
                                                UI
                                                Emoji&quot;,&quot;Segoe
                                                UI
Symbol&quot;;font-size:16px;letter-spacing:0.35px;text-decoration-style:initial;text-decoration-color:initial">Regards,<br
style="box-sizing:border-box">
                                                Amar (on behalf of many
                                                Gluster Maintainers)</p>
                                              <br clear="all">
                                              <div><br>
                                              </div>
                                            </div>
                                          </blockquote>
                                        </span></div>
                                      <span
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586HOEnZb"><font
                                          color="#888888"><br>
                                          <br clear="all">
                                          <div><br>
                                          </div>
                                          -- <br>
                                          <div
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586m_5419763478846715308gmail_signature">
                                            <div dir="ltr">
                                              <div>
                                                <div dir="ltr">
                                                  <div>Amar Tumballi
                                                    (amarts)<br>
                                                  </div>
                                                </div>
                                              </div>
                                            </div>
                                          </div>
                                        </font></span></div>
                                  </div>
                                </blockquote>
                              </span></div>
                            <span
                              class="m_-4746915144022557778m_343888659565203372HOEnZb"><font
                                color="#888888"><br>
                                <br clear="all">
                                <div><br>
                                </div>
                                -- <br>
                                <div
class="m_-4746915144022557778m_343888659565203372m_5724742561428799586gmail_signature"
                                  data-smartmail="gmail_signature">
                                  <div dir="ltr">
                                    <div>
                                      <div dir="ltr">
                                        <div>Amar Tumballi (amarts)<br>
                                        </div>
                                      </div>
                                    </div>
                                  </div>
                                </div>
                              </font></span></div>
                        </div>
                      </blockquote>
                    </span></div>
                  <span class="m_-4746915144022557778HOEnZb"><font
                      color="#888888"><br>
                      <br clear="all">
                      <div><br>
                      </div>
                      -- <br>
                      <div
                        class="m_-4746915144022557778m_343888659565203372gmail_signature"
                        data-smartmail="gmail_signature">
                        <div dir="ltr">
                          <div>
                            <div dir="ltr">
                              <div>Amar Tumballi (amarts)<br>
                              </div>
                            </div>
                          </div>
                        </div>
                      </div>
                    </font></span></div>
              </div>
            </blockquote>
          </div>
          <br>
          <br clear="all">
          <div><br>
          </div>
          -- <br>
          <div class="m_-4746915144022557778gmail_signature"
            data-smartmail="gmail_signature">
            <div dir="ltr">
              <div>
                <div dir="ltr">
                  <div>Amar Tumballi (amarts)<br>
                  </div>
                </div>
              </div>
            </div>
          </div>
        </div>
      </div>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
Gluster-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a>
<a class="moz-txt-link-freetext" href="https://lists.gluster.org/mailman/listinfo/gluster-devel">https://lists.gluster.org/mailman/listinfo/gluster-devel</a></pre>
    </blockquote>
    <br>
  </body>
</html>