<div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
- github flag enforcement for all features (doc and spec requirement) [amar]<br></blockquote><div><br></div><div>I tried to add these details to 'glusterdocs' repo [1], but noticed that we don't talk much about github is used for 'RFE' itself there. So, to unblock developers for the branching of 4.1 by information planning to write the email with details. will fix the other docs soon(ish)- Any help here would be appreciated with <b>Gluster Swags</b>.</div><div><br></div><div>The intention behind making these flags mandatory is explained in my earlier email [2]. As the same is now enforced, more details below.</div><div><br></div><div>If any one of the 'DocApproved', 'SpecApproved' label is missing, the 'smoke' test name 'comment-on-issue' [3] would keep failing, if your commit message as a reference to github issues.</div><div><br></div><div><b>What is 'DocApproved' and how to get this?</b></div><div><br></div><div>Doc Approved means, the data required for 'user' to use the feature (all the options, CLI commands, how to setup etc) are provided, and also brief note of what the feature is about, is written down, so the release lead can just pick this information, and use it in release process. (Note, the idea is to automate this too, so release-lead's role is to control the cherry-picking after the branch-out).</div><div><br></div><div>We would consider a blog with all these points also can be considered for this.</div><div><b><br></b></div><div><b>What is 'SpecApproved' and how to get this label?</b></div><div><br></div><div>Spec (or Specification) deals with the design of the feature, (mostly similar to gluster-spec repo we have). Answer the question of who needs it and why? (Detail on the usecase). How (for developers) part of the design explained.</div><div><br></div><div><br></div><div><b>Who / How to set this label ?</b></div><div><br></div><div>Today, anyone who is member of glusterfs project, and has access to set/unset labels can do it. But the advise is to leave it to general architects listed in the MAINTAINERS file, mainly as there may be few more questions pending on the spec. Also, as a top level guideline to the architects, please write a summary of why you are giving this label, what are the things you considered etc, without which there may be some conflict of interests here.</div><div><br></div><div>Initial few days/weeks, I along with Shyam would closely monitor this label business. Every one is free to ask more question to developers if design is not clear.</div><div><br></div><div>In future, like many other projects, we want to automate it, where the label is give after certain 'comment commands' are given (like 3 people giving 'i approve' type of message in issue would automatically get it the label).</div><div><br></div><div><b>What if I have more questions? or improvement suggestion?</b></div><div>Please ask, file a bug, write email.. there are many options. Improvements come only when people suggest / provide feedback etc.</div><div><br></div><div>Regards,</div><div>Amar</div><div><br></div><div>[1] - <a href="https://github.com/gluster/glusterdocs">https://github.com/gluster/glusterdocs</a></div><div>[2] - <a href="http://lists.gluster.org/pipermail/gluster-devel/2018-April/054696.html">http://lists.gluster.org/pipermail/gluster-devel/2018-April/054696.html</a></div><div>[3] - <a href="https://build.gluster.org/job/comment-on-issue/">https://build.gluster.org/job/comment-on-issue/</a></div><div><br></div></div>
</div></div>