<div dir="ltr">Hi Niels,<div><br></div><div>Thanks for the feedback. The patches which bring these changes in glusterfs are out for review here:</div><div><br></div><div><a href="https://review.gluster.org/18768">https://review.gluster.org/18768</a> (changing the auth-glusterfs version)</div><div><a href="https://review.gluster.org/19098">https://review.gluster.org/19098</a> (changing fops program actors)<br></div><div><br></div><div>Shyam, please star them for 4.0 watchlist for review help.</div><div><br></div><div>Also, as a dependent patchsets, please review this to reduce some warnings in glusterfs logs to see more focused warnings.</div><div><br></div><div><a href="https://review.gluster.org/19150">https://review.gluster.org/19150</a></div><div><a href="https://review.gluster.org/19166">https://review.gluster.org/19166</a></div><div><br></div><div>Regards,</div><div>Amar</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 12, 2018 at 5:16 PM, Niels de Vos <span dir="ltr"><<a href="mailto:ndevos@redhat.com" target="_blank">ndevos@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Wed, Jan 10, 2018 at 03:36:55PM -0500, Shyam Ranganathan wrote:<br>
> Hi,<br>
><br>
> As we are introducing a new protocol version, the existing gluster<br>
> wireshark plugin [1] needs to be updated.<br>
><br>
> Further this needs to get released to wireshark users in some fashion,<br>
> which looks like a need to follow wireshark roadmap [2] (not sure if<br>
> this can be part of a maintenance release, which would possibly be based<br>
> on the quantum of changes etc.).<br>
><br>
> This need not happen with 4.0 branching, but at least has to be<br>
> completed before 4.0 release.<br>
><br>
> @neils once the protocol changes are complete, would this be possible to<br>
> complete by you in the next 6 odd weeks by the release (end of Feb)? Or,<br>
> if we need volunteers, please give a shout out here.<br>
<br>
</span>Adding the new bits to the Wireshark dissector is pretty straight<br>
forward. Once the protocol changes have been done, it would be good to<br>
have a few .pcap files captured that can be used for developing and<br>
testing the changes. This can even be done in steps, as soon as one<br>
chunk of the protocol is finalized, a patch to upstream Wireshark can be<br>
sent already. We can improve it incrementally that way, also making it<br>
easier for multiple contributors to work on it.<br>
<br>
I can probably do some of the initial work, but would like assistance<br>
from others with testing and possibly improving certain parts. If<br>
someone can provide tcpdumps with updated protocol changes, that would<br>
be most welcome! Capture the dumps like this:<br>
<br>
# tcpdump -i any -w /var/tmp/gluster-40-${proto_<wbr>change}.pcap -s 0 tcp and not port 22<br>
... exercise the protocol bit that changed, include connection setup<br>
... press CTRL+C once done<br>
# gzip /var/tmp/gluster-40-${proto_<wbr>change}.pcap<br>
... Wireshark can read .pcap.gz without manual decompressing<br>
<br>
Attach the .pcap.gz to the GitHub issue for the protocol change and<br>
email gluster-devel@ once it is available so that a developer can start<br>
working on the Wireshark change.<br>
<br>
Thanks,<br>
Niels<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
><br>
> Shyam<br>
><br>
> [1] Gluster wireshark plugin:<br>
> <a href="https://code.wireshark.org/review/gitweb?p=wireshark.git;a=tree;f=epan/dissectors;h=8c8303285a204bdff3b8b80e2811dcd9b7ab6fe0;hb=HEAD" rel="noreferrer" target="_blank">https://code.wireshark.org/<wbr>review/gitweb?p=wireshark.git;<wbr>a=tree;f=epan/dissectors;h=<wbr>8c8303285a204bdff3b8b80e2811dc<wbr>d9b7ab6fe0;hb=HEAD</a><br>
><br>
> [2] Wireshark roadmap: <a href="https://wiki.wireshark.org/Development/Roadmap" rel="noreferrer" target="_blank">https://wiki.wireshark.org/<wbr>Development/Roadmap</a><br>
><br>
______________________________<wbr>_________________<br>
maintainers mailing list<br>
<a href="mailto:maintainers@gluster.org">maintainers@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/maintainers" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/maintainers</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Amar Tumballi (amarts)<br></div></div></div></div></div>
</div>