<div dir="ltr">Kaleb,<div><br></div><div>Replies inline. (Also adding glusterfs-maintainers, as topic is very valid for discussion out there).<br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 27, 2017 at 8:59 PM, Kaleb S. KEITHLEY <span dir="ltr"><<a href="mailto:kkeithle@redhat.com" target="_blank">kkeithle@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Hi,<br>
<br>
I see that these two symbols were added to the top-level xlator.sym file.<br>
<br>
Most xlators don't have class_methods. Only protocol/server has xlator_api (which looks like a superset of class_methods, can we elminiate one of these?).<br>
<br>
All the xlators that do have class_methods have their own .sym file to export class_methods, e.g. quotad.<br>
<br>
I would prefer that we not expand the top-level xlator.sym file with symbols that aren't in the majority of the xlators. Please add new .sym files for the xlators where they are needed.<br></blockquote><div><br></div><div>Ack!</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Also I note that /var/log/glusterfs/glusterd.lo<wbr>g is flooded with warnings like:<br>
[2017-12-27 15:15:47.506911] I [MSGID: 101097] [xlator.c:322:xlator_dynload_n<wbr>ewway] 0-xlator: dlsym(xlator_api) on /usr/lib64/glusterfs/4.0dev1/x<wbr>lator/debug/io-stats.so: undefined symbol: xlator_api. Fall back to old symbols<br>
<br>
this seems suboptimal.<br>
<br></blockquote><div><br></div><div>Agree on that. I too get irritated to see these INFO messages. I thought it is a good reminder for people to complete it.</div><div><br></div><div>Note that right now, there will be more warning about Dictionary values and mismatching types in the log. I would like to keep them as is in the 'master' branch, and suppress them in release branch, So that we can fix it by 4.1 version at least.</div><div><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks,<br>
<br>
--<br>
<br>
Kaleb<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Amar Tumballi (amarts)<br></div></div></div></div></div>
</div></div></div>