<div dir="ltr">Hi Jeff,<div><br></div><div>Thanks for reminder, I was almost about to believe 'experimental' was my personal branch :-P</div><div><div class="gmail_extra"><br></div><div class="gmail_extra">I will try to respond inline, and try to clarify some concerns!</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 31, 2017 at 9:43 PM, Jeff Darcy <span dir="ltr"><<a href="mailto:jeff@pl.atyp.us" target="_blank">jeff@pl.atyp.us</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I've seen a few patches lately that were merged before affected parties<br>
in other timezones had a chance to see them (or see them in their<br>
current form).</blockquote><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> In at least one case, a patch wasn't even reviewed by<br>
*anyone* other than its author before being merged. </blockquote><div><br></div><div>Sorry about both the above. I am fine to have max of 2 day delay in minor</div><div>patches and a week for any large patches, unless there is any review from </div><div>either peer or maintainer of specific component.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I'd like to<br>
discourage this. </blockquote><div><br></div><div>Ack!</div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Yes, even on the "experimental" branch because that's<br>
already more active than master so it's effectively what master should<br>
be. </blockquote><div><br></div><div><div>But, To be honest, in last 3 months of activities in 'experimental' branch, I </div><div>just had you reviewing one patch and ndevos checking 2-3 patches (mainly</div><div>the commit message). Other than that, mostly I did was to rebase long pending </div><div>patches from master, with exception of below:</div><div><br></div><div>Significant feature/enhancement patches are: </div><div>1) error code patches (for github issue #280)</div><div>2) changes for 'metrics'.</div></div><div><br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> If something's not reviewed on experimental, the chances that it<br>
will *ever* be reviewed before being merged into master trend toward<br>
zero. </blockquote><div><br></div><div>Agree! But, again when I proposed the 'experimental' branch, idea was to push changes *quickly* to repository where other significant changes are also happening, so we can keep running regressions, and feel confident about the patch. We surely need people to participate in reviews even when patch is submitted to experimental, rather sometime develop them here instead of taking 40+ iterations for 1 big patch.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> We have a review process for a reason. Reviewing helps us avoid<br>
bugs that would be more difficult to find at later stages, and design<br>
errors that might lead to costly rewrites when issues already known in<br>
the community but not to the author are raised. It's an essential part<br>
of effective collaboration, and we should try to maximize those<br>
benefits.<br></blockquote><div><br></div><div>Totally agree! I would like to hear how we can get more eyeballs into experimental branch, mainly considering about meeting possible deadline of Nov-Dec, 2017 for Gluster 4.0.</div><div><br></div><div>Regards,</div><div>Amar</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
______________________________<wbr>_________________<br>
maintainers mailing list<br>
<a href="mailto:maintainers@gluster.org">maintainers@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/maintainers" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/maintainers</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Amar Tumballi (amarts)<br></div></div></div></div></div>
</div></div></div>