<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, May 28, 2017 at 1:48 PM, Niels de Vos <span dir="ltr"><<a href="mailto:ndevos@redhat.com" target="_blank">ndevos@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">On Fri, May 26, 2017 at 12:25:42PM -0400, Shyam wrote:<br>
> Or this one: <a href="https://review.gluster.org/15036" rel="noreferrer" target="_blank">https://review.gluster.org/<wbr>15036</a><br>
><br>
> This is backported to 3.8/10 and 3.11 and considering the size and impact of<br>
> the change, I wanted to be sure that we are going to accept this across all<br>
> 3 releases?<br>
><br>
> @Du, would like your thoughts on this.<br>
><br>
> @niels, @kaushal, @talur, as release owners, could you weigh in as well<br>
> please.<br>
><br>
> I am thinking that we get this into 3.11.1 if there is agreement, and not in<br>
> 3.11.0 as we are finalizing the release in 3 days, and this change looks<br>
> big, to get in at this time.<br></span></blockquote><div><br></div><div>Given 3.11 is going to be a new release, I'd recommend to get this fix in (if we have time). <a href="https://review.gluster.org/#/c/17402/">https://review.gluster.org/#/c/17402/</a> is dependent on this one.<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">
><br>
> Further the change is actually an enhancement, and provides performance<br>
> benefits, so it is valid as a change itself, but I feel it is too late to<br>
> add to the current 3.11 release.<br>
<br>
</span>Indeed, and mostly we do not merge enhancements that are non-trivial to<br>
stable branches. Each change that we backport introduces the chance on<br>
regressions for users with their unknown (and possibly awkward)<br>
workloads.<br>
<br>
The patch itself looks ok, but it is difficult to predict how the change<br>
affects current deployments. I prefer to be conservative and not have<br>
this merged in 3.8, at least for now. Are there any statistics in how<br>
performance is affected with this change? Having features like this only<br>
in newer versions might also convince users to upgrade sooner, 3.8 will<br>
only be supported until 3.12 (or 4.0) gets released, which is approx. 3<br>
months from now according to our schedule.<br>
<span class="gmail-HOEnZb"><font color="#888888"><br>
Niels<br>
</font></span><br>______________________________<wbr>_________________<br>
maintainers mailing list<br>
<a href="mailto:maintainers@gluster.org">maintainers@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/maintainers" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/maintainers</a><br>
<br></blockquote></div><br></div></div>