<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 10, 2017 at 11:17 AM, Poornima Gurusiddaiah <span dir="ltr"><<a target="_blank" href="mailto:pgurusid@redhat.com">pgurusid@redhat.com</a>></span> wrote:<br><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"><div class="gmail-HOEnZb"><div class="gmail-h5"><br>
----- Original Message -----<br>
> From: "Niels de Vos" <<a href="mailto:ndevos@redhat.com">ndevos@redhat.com</a>><br>
> To: "Shyam" <<a href="mailto:srangana@redhat.com">srangana@redhat.com</a>><br>
> Cc: "Rajesh Joseph" <<a href="mailto:rjoseph@redhat.com">rjoseph@redhat.com</a>>, "Gluster Devel" <<a href="mailto:gluster-devel@gluster.org">gluster-devel@gluster.org</a>>, <a href="mailto:integration@gluster.org">integration@gluster.org</a>,<br>
> "Poornima G" <<a href="mailto:pgurusid@redhat.com">pgurusid@redhat.com</a>><br>
> Sent: Monday, January 9, 2017 5:05:14 PM<br>
> Subject: Re: [Gluster-devel] Release 3.10 feature proposal:: Statedump for libgfapi<br>
><br>
> On Mon, Jan 09, 2017 at 10:27:03AM +0530, Shyam wrote:<br>
> > On 01/05/2017 07:10 PM, Niels de Vos wrote:<br>
> ...<br>
> > > Because we would really like this in 3.10 to allow applications to<br>
> > > integrate better with Gluster, I propose to split the functionality over<br>
> > > several changes:<br>
> > ><br>
> > > 1. ground work and API exposed for applications (and testing)<br>
> ><br>
> > Poornima is working on this as a part of the patch posted at [0]. Poornima<br>
> > do you want to add more details here?<br>
><br>
> Yes, I'm waiting for a reply rom Poornima as well. I'd like a discussion<br>
> about an extendible interface that is not limited to doing statedumps. I<br>
> do have patches for this based on her work and I want to share those in<br>
> the discussion.<br>
><br>
> > > 2. enablement through a simple interface, similar to /proc/sysrq-trigger<br>
> > > 3. enablement through gluster-cli command<br>
> ><br>
> > The initial implementation of triggering a statedump via the CLI already<br>
> > exists as a part of the patch [0].<br>
><br>
> Yes, and I am aware of that. But I also like patches to be modular and<br>
> have split for each single functionality. That makes it easier for<br>
> testing and reviewing. The current approach is a large chunk that I<br>
> would like to see split. Again, waiting for Poornima to join the<br>
> discussion.<br>
><br>
> > > These options should be explained in the feature page, with the plan to<br>
> > > provide the three options for 3.10. I'm happy to massage the patch from<br>
> > > Poornima [0] and split it in 1 and 3. Additional improvements for 3<br>
> > > might be needed, and we'll have to see who does that work. Point 2 is<br>
> > > something I'll take on as well.<br>
> > ><br>
<br>
</div></div>From the methods mentioned 1, 3 are there as a part of the single patch. As you<br>
mentioned the api is not extendable and glusterd requires some improvements. And<br>
also the patch needs to be split, since you already have the patches ready, please<br>
go ahead. I can abandon this patch. It would be very useful if we can get either<br>
approach 2 or 3 for 3.10.<br></blockquote><div><br>FWIW, 3 is an acceptable solution when gluster is running hyperconverged for the VM use case (for instance, with oVirt)<br><br> </div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">
<br>
Thanks,<br>
Poornima<br>
<div class="gmail-HOEnZb"><div class="gmail-h5"><br>
> > > What do others think about this?<br>
> ><br>
> > My question thus is, where are we drawing a line for this in 3.10<br>
> > considering we have about a *week* left for *branching*?<br>
> > - Is 1, and 3 enough as it exists (i.e with the intention of exposing the<br>
> > API as in 1 additionally)?<br>
><br>
> The API does not exist (well, it was added this morning). But the API<br>
> needs discussion because it is not extendible. This discussion needs to<br>
> be had, and with the new feature page we can actually do that somewhere.<br>
><br>
> > - Is 2 mandatory or can come in later (i.e 3.11)?<br>
><br>
> It can come later, but the feature would be kess useful if this does not<br>
> exist. Statedumps are helpful to diagnose network/communication<br>
> problems, relying on the network to trigger them is probably not helpful<br>
> in many situations.<br>
><br>
> > - Is additions to 3 (i.e improvements to the gluster cli) mandatory or<br>
> > can<br>
> > come in later (i.e 3.11)?<br>
><br>
> I see 1 as mandatory. The other interfaces would be welcome, but need<br>
> discussion and approval from different component maintainers and the<br>
> target users.<br>
><br>
> HTH,<br>
> Niels<br>
><br>
><br>
> ><br>
> > ><br>
> > > Thanks,<br>
> > > Niels<br>
> > ><br>
> > > [0] <a target="_blank" rel="noreferrer" href="http://review.gluster.org/9228">http://review.gluster.org/9228</a><br>
> > [1] <a target="_blank" rel="noreferrer" href="http://review.gluster.org/16357">http://review.gluster.org/<wbr>16357</a><br>
><br>
</div></div><div class="gmail-HOEnZb"><div class="gmail-h5">______________________________<wbr>_________________<br>
integration mailing list<br>
<a href="mailto:integration@gluster.org">integration@gluster.org</a><br>
<a target="_blank" rel="noreferrer" href="http://lists.gluster.org/mailman/listinfo/integration">http://lists.gluster.org/<wbr>mailman/listinfo/integration</a><br>
</div></div></blockquote></div><br></div></div>