<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">在 2019/11/21 21:04, Barak Sason Rofman
写道:<br>
</div>
<blockquote type="cite"
cite="mid:CAFx2kQ3HS=SC4govRmc-+uejHYhvO3UN7m3sNpy66UdCAiabKA@mail.gmail.com">
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"
id="gmail-docs-internal-guid-2211c633-7fff-c4eb-83dd-3e2c2e691e75"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">I see two design / implementation problems with that mechanism:</span></p>
<ol style="margin-top:0px;margin-bottom:0px">
<li dir="ltr" style="list-style-type:decimal;font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre"><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">The mutex that guards the log file is likely under constant contention.</span></p></li>
<li dir="ltr" style="list-style-type:decimal;font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre"><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">The fact that each worker thread perform the IO by himself, thus slowing his "real" work.</span></p></li>
</ol>
<br>
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">Initial tests, done by <b>removing logging from the regression testing, shows an improvement of about 20% in run time</b>. This indicates we’re taking a pretty heavy performance hit just because of the logging activity.</span></p>
<br>
</blockquote>
<p>Hi Barak Sason Rofman. Amazing perf improvement! Could show me
the detail test method ? <br>
</p>
<p>Thanks</p>
<p> -Xie<br>
</p>
<blockquote type="cite"
cite="mid:CAFx2kQ3HS=SC4govRmc-+uejHYhvO3UN7m3sNpy66UdCAiabKA@mail.gmail.com">
<p dir="ltr"
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">In addition to these problems, the logging module is due for an upgrade:</span></p>
<ol style="margin-top:0px;margin-bottom:0px">
<li dir="ltr" style="list-style-type:decimal;font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre"><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">There are dozens of APIs in the logger, much of them are deprecated - this makes it very hard for new developers to keep evolving the project.</span></p></li>
<li dir="ltr" style="list-style-type:decimal;font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre"><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">One of the key points for Gluster-X, presented in October at Bangalore, is the switch to a structured logging all across gluster.</span></p></li>
</ol>
</blockquote>
</body>
</html>