[Gluster-infra] [Bug 1564149] Agree upon a coding standard, and automate check for this in smoke
bugzilla at redhat.com
bugzilla at redhat.com
Wed Apr 25 04:27:12 UTC 2018
https://bugzilla.redhat.com/show_bug.cgi?id=1564149
--- Comment #28 from Xavi Hernandez <jahernan at redhat.com> ---
(In reply to Aravinda VK from comment #27)
> I prefer Right(`AlignEscapedNewlines=Right`), since Patch will have minimum
> number of lines change on modification. For example,
>
> #define gf_log(dom, levl, fmt...) do { \
> FMT_WARN (fmt); \
> _gf_log (dom, __FILE__, __FUNCTION__, __LINE__, \
> levl, ##fmt); \
> } while (0)
>
> If longest line is changed then patch diff shows all of them as changed
> lines in case of `AlignEscapedNewLines=Left`
That makes sense. It's ok for me.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CsBYbRgu0h&a=cc_unsubscribe
More information about the Gluster-infra
mailing list