Well, it will be interesting to see the results.<div>Anything that doesn't reduce performance is good.</div><div><br></div><div>Best Regards,</div><div>Strahil Nikolov<br> <br> <blockquote style="margin: 0 0 20px 0;"> <div style="font-family:Roboto, sans-serif; color:#6D00F6;"> <div>On Thu, Mar 24, 2022 at 22:47, Yaniv Kaul</div><div><ykaul@redhat.com> wrote:</div> </div> <div style="padding: 10px 0 0 20px; margin: 10px 0 0 0; border-left: 1px solid #6D00F6;"> <div id="yiv5219190185"><div><div><div><br clear="none"><br clear="none"><div class="yiv5219190185gmail_quote"><div dir="ltr" class="yiv5219190185gmail_attr">On Thu, 24 Mar 2022, 22:16 Xavi Hernandez <<a rel="nofollow noopener noreferrer" shape="rect" ymailto="mailto:xhernandez@redhat.com" target="_blank" href="mailto:xhernandez@redhat.com">xhernandez@redhat.com</a>> wrote:<br clear="none"></div><blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;" class="yiv5219190185gmail_quote"><div dir="ltr"><div>Hi Strahil,</div><br clear="none"><div class="yiv5219190185gmail_quote"><div dir="ltr" class="yiv5219190185gmail_attr">On Thu, Mar 24, 2022 at 8:26 PM Strahil Nikolov <<a rel="nofollow noopener noreferrer" shape="rect" ymailto="mailto:hunter86_bg@yahoo.com" target="_blank" href="mailto:hunter86_bg@yahoo.com">hunter86_bg@yahoo.com</a>> wrote:<br clear="none"></div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex;" class="yiv5219190185gmail_quote">Hey Xavi,<div><br clear="none"></div><div>Did anyone measure performance behavior before and after the changes?</div></blockquote><div><br clear="none"></div><div>I haven't tested performance for this change, but I don't expect any appreciable variation. The main reason to do it is to provide a simpler way to create and use log messages that makes them more flexible and consistent. It's specially useful when used with an editor that support code completion.</div><div><br clear="none"></div><div>Given that I've rewritten a significant part of the code, I've taken the opportunity to include some things that could have a minimal performance benefit, but it's not the main reason.</div></div></div></blockquote></div></div><div><br clear="none"></div><div><br clear="none"></div><div>If we skip the work to create the log string, when eventually we don't need to log at all (as we are not in TRACE or DEBUG levels) that could help a bit. Some of those UUID and lkowner prints for example. </div><div>Y. </div><div><br clear="none"></div><div><div class="yiv5219190185gmail_quote"><blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;" class="yiv5219190185gmail_quote"><div dir="ltr"><div class="yiv5219190185gmail_quote"><div><br clear="none"></div><div>Best regards,</div><div><br clear="none"></div><div>Xavi</div><div><br clear="none"></div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex;" class="yiv5219190185gmail_quote"><div><br clear="none"></div><div>Best Regards,</div><div>Strahil Nikolov<br clear="none"> <br clear="none"> <blockquote style="margin:0px 0px 20px;"> <div style="font-family:Roboto, sans-serif;color:rgb(109,0,246);"> <div>On Thu, Mar 24, 2022 at 20:33, Xavi Hernandez</div><div><<a rel="nofollow noopener noreferrer" shape="rect" ymailto="mailto:xhernandez@redhat.com" target="_blank" href="mailto:xhernandez@redhat.com">xhernandez@redhat.com</a>> wrote:</div> </div> <div style="padding:10px 0px 0px 20px;margin:10px 0px 0px;border-left:1px solid rgb(109,0,246);"> <div id="yiv5219190185m_8006331838643996687gmail-m_-3474842985224959619yiv8462860519"><div dir="ltr">Hi all,<div><br clear="none"></div><div>I've just posted a proposal for a new logging interface here: <a rel="nofollow noopener noreferrer" shape="rect" target="_blank" href="https://github.com/gluster/glusterfs/pull/3342">https://github.com/gluster/glusterfs/pull/3342</a></div><div><br clear="none"></div><div>There are many comments and the documentation is updated in the PR itself, so I won't duplicate all the info here. Please check it if you are interested in the details.</div><div><br clear="none"></div><div>As a summary, I think that the new interface is easier to use, more powerful, more flexible and more robust.</div><div><br clear="none"></div><div>Since it affects an interface used by every single component of Gluster I would like to have some more feedback before deciding whether we merge it or not. Feel free to comment here or in the PR itself.</div><div><br clear="none"></div><div>Thank you very much,</div><div><br clear="none"></div><div>Xavi</div></div>
</div>-------<br clear="none"><br clear="none">Community Meeting Calendar:<br clear="none">Schedule -<br clear="none">Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC<br clear="none">Bridge: <a rel="nofollow noopener noreferrer" shape="rect" target="_blank" href="https://meet.google.com/cpu-eiue-hvk">https://meet.google.com/cpu-eiue-hvk</a><br clear="none"><br clear="none">Gluster-devel mailing list<br clear="none"><a rel="nofollow noopener noreferrer" shape="rect" ymailto="mailto:Gluster-devel@gluster.org" target="_blank" href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br clear="none"><a rel="nofollow noopener noreferrer" shape="rect" target="_blank" href="https://lists.gluster.org/mailman/listinfo/gluster-devel">https://lists.gluster.org/mailman/listinfo/gluster-devel</a><div id="yiv5219190185yqtfd16707" class="yiv5219190185yqt4080387691"><br clear="none"><br clear="none"> </div></div><div id="yiv5219190185yqtfd02966" class="yiv5219190185yqt4080387691"> </div></blockquote></div></blockquote></div></div><div id="yiv5219190185yqtfd30931" class="yiv5219190185yqt4080387691">
-------<br clear="none">
<br clear="none">
Community Meeting Calendar:<br clear="none">
Schedule -<br clear="none">
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC<br clear="none">
Bridge: <a rel="nofollow noopener noreferrer" shape="rect" target="_blank" href="https://meet.google.com/cpu-eiue-hvk">https://meet.google.com/cpu-eiue-hvk</a><br clear="none">
<br clear="none">
Gluster-devel mailing list<br clear="none">
<a rel="nofollow noopener noreferrer" shape="rect" ymailto="mailto:Gluster-devel@gluster.org" target="_blank" href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br clear="none">
<a rel="nofollow noopener noreferrer" shape="rect" target="_blank" href="https://lists.gluster.org/mailman/listinfo/gluster-devel">https://lists.gluster.org/mailman/listinfo/gluster-devel</a><br clear="none">
<br clear="none">
</div></blockquote></div></div></div><div id="yiv5219190185yqtfd22126" class="yiv5219190185yqt4080387691">
</div></div></div> </div> </blockquote></div>