<div dir="ltr">Thanks for bringing this to our attention @Strahil<br><br>[1] and [2] were discretely worked handling different issues at the same span of time. Merging [2] was to be done before [1], which was done otherwise. <br><br>[1] <a href="https://review.gluster.org/#/c/glusterfs/+/23039/">https://review.gluster.org/#/c/glusterfs/+/23039/</a><br>[2] <a href="https://review.gluster.org/#/c/glusterfs/+/22636/">https://review.gluster.org/#/c/glusterfs/+/22636/</a><br><br>Regards,<br>Shwetha</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Nov 18, 2020 at 12:41 PM Ravishankar N <<a href="mailto:ravishankar@redhat.com">ravishankar@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
On 18/11/20 12:17 pm, Strahil Nikolov wrote:<br>
> Nope, it's a deeper s**t.<br>
> I had to edit the ".<a href="http://spec.in" rel="noreferrer" target="_blank">spec.in</a>" file so it has Source0 point to local tar.gz.<br>
> The I edit the requires in both ".spec" & ".<a href="http://spec.in" rel="noreferrer" target="_blank">spec.in</a>" and also I had to remove an obsolete stanza in the glusterfs section.<br>
><br>
> In the end, I got the source - extracted, copied the spec & <a href="http://spec.in" rel="noreferrer" target="_blank">spec.in</a> , and then tar.gz-ed again and put it into the dir.<br>
><br>
> Only then the rpms were properly built.<br>
><br>
> The proposed patch is fixing the issue.<br>
Thanks for confirming!<br>
><br>
> Why do we have line 285 in <a href="https://raw.githubusercontent.com/gluster/glusterfs/devel/glusterfs.spec.in" rel="noreferrer" target="_blank">https://raw.githubusercontent.com/gluster/glusterfs/devel/glusterfs.spec.in</a> ?<br>
><br>
> I guess I need to open 2 issues for the glusterfs:<br>
> - that obsolete stanza is useless<br>
<br>
Using git blame points me to <br>
<a href="https://github.com/gluster/glusterfs/commit/f9118c2c9389e0793951388c2d69ce0350bb9318" rel="noreferrer" target="_blank">https://github.com/gluster/glusterfs/commit/f9118c2c9389e0793951388c2d69ce0350bb9318</a>. <br>
Adding Shwetha to confirm if the change was intended.<br>
<br>
-Ravi<br>
<br>
><br>
><br>
> Best Regards,<br>
> Strahil Nikolov<br>
><br>
><br>
><br>
> В вторник, 17 ноември 2020 г., 14:16:36 Гринуич+2, Ravishankar N <<a href="mailto:ravishankar@redhat.com" target="_blank">ravishankar@redhat.com</a>> написа:<br>
><br>
><br>
><br>
><br>
><br>
> Hi Strahil,<br>
><br>
> I would have imagined editing the 'Requires' section in<br>
> <a href="http://glusterfs.spec.in" rel="noreferrer" target="_blank">glusterfs.spec.in</a> would have sufficed. Do you need rpms though? A source<br>
> install is not enough?<br>
><br>
> Regards,<br>
> Ravi<br>
><br>
> On 17/11/20 5:32 pm, Strahil Nikolov wrote:<br>
>> Hi Ravi,<br>
>><br>
>><br>
>> Any idea how to make the glusterfs-ganesha.x86_64 require resource-agents >= 4.1.0 (instead of 4.2.0) ?<br>
>> I 've replaced every occurance I found and still it tries to grab resource-agents 4.2 (which is not available on EL8).<br>
>><br>
>> Best Regards,<br>
>> Strahil Nikolov<br>
>><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>> В понеделник, 16 ноември 2020 г., 13:15:54 Гринуич+2, Ravishankar N<<a href="mailto:ravishankar@redhat.com" target="_blank">ravishankar@redhat.com</a>> написа:<br>
>><br>
>><br>
>><br>
>><br>
>><br>
>><br>
>> I am surprised too that it wasn't caught earlier.<br>
>><br>
>><br>
>> Steps:<br>
>><br>
>> 1. Clone the gluster repo<br>
>><br>
>> 2. Compile the sourcehttps://<a href="http://docs.gluster.org/en/latest/Developer-guide/Building-GlusterFS/" rel="noreferrer" target="_blank">docs.gluster.org/en/latest/Developer-guide/Building-GlusterFS/</a><br>
>><br>
>> 3. Make the changes (in a different branch if you prefer), compile again and install<br>
>><br>
>> 4. Test it out:<br>
>><br>
>> [root@linuxpad glusterfs]# gluster v create testvol 127.0.0.2:/home/ravi/bricks/brick{1..2} force<br>
>> volume create: testvol: success: please start the volume to access data<br>
>> [root@linuxpad glusterfs]#<br>
>> [root@linuxpad glusterfs]# gluster v start testvol<br>
>> volume start: testvol: success<br>
>> [root@linuxpad glusterfs]#<br>
>> [root@linuxpad glusterfs]# gluster v set testvol ganesha.enable on<br>
>> volume set: failed: The option nfs-ganesha should be enabled before setting ganesha.enable.<br>
>> [root@linuxpad glusterfs]#<br>
>> <br>
>><br>
>> I just tried the change and it looks like some new error shows up. Not too familiar with these settings; I will need to debug further.<br>
>><br>
>> Thanks,<br>
>><br>
>> Ravi<br>
>><br>
>><br>
>> On 16/11/20 4:05 pm, Strahil Nikolov wrote:<br>
>><br>
>><br>
>>> I can try to help with the testing (I'm quite new to that).<br>
>>> Can someone share documentation of that process ?<br>
>>><br>
>>> yet we have another problem -> ganesha is deployed with ocf:heartbeat:portblock which supports only IPTABLES, while EL8 uses NFTABLES ...<br>
>>><br>
>>> Best Regards,<br>
>>> Strahil Nikolov<br>
>>><br>
>>><br>
>>><br>
>>><br>
>>><br>
>>><br>
>>> В понеделник, 16 ноември 2020 г., 10:47:43 Гринуич+2, Yaniv Kaul<<a href="mailto:ykaul@redhat.com" target="_blank">ykaul@redhat.com</a>> написа:<br>
>>><br>
>>><br>
>>><br>
>>><br>
>>><br>
>>><br>
>>><br>
>>> On Mon, Nov 16, 2020 at 10:26 AM Ravishankar N<<a href="mailto:ravishankar@redhat.com" target="_blank">ravishankar@redhat.com</a>> wrote:<br>
>>><br>
>>>> On 15/11/20 8:24 pm, Strahil Nikolov wrote:<br>
>>>><br>
>>>>> Hello All,<br>
>>>>><br>
>>>>> did anyone get a chance to look athttps://<a href="http://github.com/gluster/glusterfs/issues/1778" rel="noreferrer" target="_blank">github.com/gluster/glusterfs/issues/1778</a> ?<br>
>>>>><br>
>>>> A look at<br>
>>>> <a href="https://review.gluster.org/#/c/glusterfs/+/23648/4/xlators/mgmt/glusterd/src/glusterd-op-sm.c@1117" rel="noreferrer" target="_blank">https://review.gluster.org/#/c/glusterfs/+/23648/4/xlators/mgmt/glusterd/src/glusterd-op-sm.c@1117</a><br>
>>>> seems to indicate this could be due to a typo error. Do you have a<br>
>>>> source install where you can apply this simple diff and see if it fixes<br>
>>>> the issue?<br>
>>>><br>
>>> I think you are right - I seem to have introduced it as part ofhttps://<a href="http://github.com/gluster/glusterfs/commit/e081ac683b6a5bda54891318fa1e3ffac981e553" rel="noreferrer" target="_blank">github.com/gluster/glusterfs/commit/e081ac683b6a5bda54891318fa1e3ffac981e553</a> - my bad.<br>
>>><br>
>>> However, it was merged ~1 year ago, and no one has complained thus far... :-/<br>
>>> 1. Is no one using NFS Ganesha?<br>
>>> 2. We are lacking tests for NFS Ganesha - code coverage indicates this path is not covered.<br>
>>><br>
>>> Y.<br>
>>><br>
>>><br>
>>>> <br>
>>>> diff --git a/xlators/mgmt/glusterd/src/glusterd-op-sm.c<br>
>>>> b/xlators/mgmt/glusterd/src/glusterd-op-sm.c<br>
>>>> index 558f04fb2..d7bf96adf 100644<br>
>>>> --- a/xlators/mgmt/glusterd/src/glusterd-op-sm.c<br>
>>>> +++ b/xlators/mgmt/glusterd/src/glusterd-op-sm.c<br>
>>>> @@ -1177,7 +1177,7 @@ glusterd_op_stage_set_volume(dict_t *dict, char<br>
>>>> **op_errstr)<br>
>>>> }<br>
>>>> } else if (len_strcmp(key, keylen, "ganesha.enable")) {<br>
>>>> key_matched = _gf_true;<br>
>>>> - if (!strcmp(value, "off") == 0) {<br>
>>>> + if (strcmp(value, "off") == 0) {<br>
>>>> ret = ganesha_manage_export(dict, "off", _gf_true,<br>
>>>> op_errstr);<br>
>>>> if (ret)<br>
>>>> goto out;<br>
>>>><br>
>>>> Thanks,<br>
>>>><br>
>>>> Ravi<br>
>>>><br>
>>>>> It's really strange that NFS Ganesha has ever passed the tests.<br>
>>>>> How do we test NFS Ganesha exporting ?<br>
>>>>><br>
>>>>> Best Regards,<br>
>>>>> Strahil Nikolov<br>
>>>>> _______________________________________________<br>
>>>>><br>
>>>>> Community Meeting Calendar:<br>
>>>>><br>
>>>>> Schedule -<br>
>>>>> Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC<br>
>>>>> Bridge:<a href="https://bluejeans.com/441850968" rel="noreferrer" target="_blank">https://bluejeans.com/441850968</a><br>
>>>>><br>
>>>>><br>
>>>>><br>
>>>>><br>
>>>>> Gluster-devel mailing list<br>
>>>>> <a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
>>>>> <a href="https://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">https://lists.gluster.org/mailman/listinfo/gluster-devel</a><br>
>>>>><br>
>>>>> <br>
>>>> _______________________________________________<br>
>>>><br>
>>>> Community Meeting Calendar:<br>
>>>><br>
>>>> Schedule -<br>
>>>> Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC<br>
>>>> Bridge:<a href="https://bluejeans.com/441850968" rel="noreferrer" target="_blank">https://bluejeans.com/441850968</a><br>
>>>><br>
>>>><br>
>>>><br>
>>>><br>
>>>> Gluster-devel mailing list<br>
>>>> <a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
>>>> <a href="https://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">https://lists.gluster.org/mailman/listinfo/gluster-devel</a><br>
>>>><br>
>>>><br>
>>>><br>
<br>
</blockquote></div>