<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>I am surprised too that it wasn't caught earlier. <br>
</p>
<p>Steps:</p>
<p>1. Clone the gluster repo</p>
<p>2. Compile the source
<a class="moz-txt-link-freetext" href="https://docs.gluster.org/en/latest/Developer-guide/Building-GlusterFS/">https://docs.gluster.org/en/latest/Developer-guide/Building-GlusterFS/</a></p>
<p>3. Make the changes (in a different branch if you prefer),
compile again and install</p>
<p>4. Test it out:</p>
<table width="100%" cellspacing="2" cellpadding="2" border="1">
<tbody>
<tr>
<td valign="top"><font face="monospace">[root@linuxpad
glusterfs]# gluster v create testvol
127.0.0.2:/home/ravi/bricks/brick{1..2} force<br>
volume create: testvol: success: please start the volume
to access data<br>
[root@linuxpad glusterfs]#<br>
[root@linuxpad glusterfs]# gluster v start testvol<br>
volume start: testvol: success<br>
[root@linuxpad glusterfs]#<br>
[root@linuxpad glusterfs]# gluster v set testvol
ganesha.enable on<br>
volume set: failed: The option nfs-ganesha should be
enabled before setting ganesha.enable.<br>
[root@linuxpad glusterfs]#</font><br>
</td>
</tr>
</tbody>
</table>
<p>I just tried the change and it looks like some new error shows
up. Not too familiar with these settings; I will need to debug
further.</p>
<p>Thanks,</p>
<p>Ravi<br>
</p>
<div class="moz-cite-prefix">On 16/11/20 4:05 pm, Strahil Nikolov
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:221807962.3419628.1605522910004@mail.yahoo.com">
<pre class="moz-quote-pre" wrap="">I can try to help with the testing (I'm quite new to that).
Can someone share documentation of that process ?
yet we have another problem -> ganesha is deployed with ocf:heartbeat:portblock which supports only IPTABLES, while EL8 uses NFTABLES ...
Best Regards,
Strahil Nikolov
В понеделник, 16 ноември 2020 г., 10:47:43 Гринуич+2, Yaniv Kaul <a class="moz-txt-link-rfc2396E" href="mailto:ykaul@redhat.com"><ykaul@redhat.com></a> написа:
On Mon, Nov 16, 2020 at 10:26 AM Ravishankar N <a class="moz-txt-link-rfc2396E" href="mailto:ravishankar@redhat.com"><ravishankar@redhat.com></a> wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
On 15/11/20 8:24 pm, Strahil Nikolov wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Hello All,
did anyone get a chance to look at <a class="moz-txt-link-freetext" href="https://github.com/gluster/glusterfs/issues/1778">https://github.com/gluster/glusterfs/issues/1778</a> ?
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
A look at
<a class="moz-txt-link-freetext" href="https://review.gluster.org/#/c/glusterfs/+/23648/4/xlators/mgmt/glusterd/src/glusterd-op-sm.c@1117">https://review.gluster.org/#/c/glusterfs/+/23648/4/xlators/mgmt/glusterd/src/glusterd-op-sm.c@1117</a>
seems to indicate this could be due to a typo error. Do you have a
source install where you can apply this simple diff and see if it fixes
the issue?
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
I think you are right - I seem to have introduced it as part of <a class="moz-txt-link-freetext" href="https://github.com/gluster/glusterfs/commit/e081ac683b6a5bda54891318fa1e3ffac981e553">https://github.com/gluster/glusterfs/commit/e081ac683b6a5bda54891318fa1e3ffac981e553</a> - my bad.
However, it was merged ~1 year ago, and no one has complained thus far... :-/
1. Is no one using NFS Ganesha?
2. We are lacking tests for NFS Ganesha - code coverage indicates this path is not covered.
Y.
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
diff --git a/xlators/mgmt/glusterd/src/glusterd-op-sm.c
b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
index 558f04fb2..d7bf96adf 100644
--- a/xlators/mgmt/glusterd/src/glusterd-op-sm.c
+++ b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
@@ -1177,7 +1177,7 @@ glusterd_op_stage_set_volume(dict_t *dict, char
**op_errstr)
}
} else if (len_strcmp(key, keylen, "ganesha.enable")) {
key_matched = _gf_true;
- if (!strcmp(value, "off") == 0) {
+ if (strcmp(value, "off") == 0) {
ret = ganesha_manage_export(dict, "off", _gf_true,
op_errstr);
if (ret)
goto out;
Thanks,
Ravi
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
It's really strange that NFS Ganesha has ever passed the tests.
How do we test NFS Ganesha exporting ?
Best Regards,
Strahil Nikolov
_______________________________________________
Community Meeting Calendar:
Schedule -
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
Bridge: <a class="moz-txt-link-freetext" href="https://bluejeans.com/441850968">https://bluejeans.com/441850968</a>
Gluster-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a>
<a class="moz-txt-link-freetext" href="https://lists.gluster.org/mailman/listinfo/gluster-devel">https://lists.gluster.org/mailman/listinfo/gluster-devel</a>
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
_______________________________________________
Community Meeting Calendar:
Schedule -
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
Bridge: <a class="moz-txt-link-freetext" href="https://bluejeans.com/441850968">https://bluejeans.com/441850968</a>
Gluster-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a>
<a class="moz-txt-link-freetext" href="https://lists.gluster.org/mailman/listinfo/gluster-devel">https://lists.gluster.org/mailman/listinfo/gluster-devel</a>
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
</blockquote>
</body>
</html>