<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Nov 16, 2020 at 10:26 AM Ravishankar N <<a href="mailto:ravishankar@redhat.com">ravishankar@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
On 15/11/20 8:24 pm, Strahil Nikolov wrote:<br>
> Hello All,<br>
><br>
> did anyone get a chance to look at <a href="https://github.com/gluster/glusterfs/issues/1778" rel="noreferrer" target="_blank">https://github.com/gluster/glusterfs/issues/1778</a> ?<br>
<br>
A look at <br>
<a href="https://review.gluster.org/#/c/glusterfs/+/23648/4/xlators/mgmt/glusterd/src/glusterd-op-sm.c@1117" rel="noreferrer" target="_blank">https://review.gluster.org/#/c/glusterfs/+/23648/4/xlators/mgmt/glusterd/src/glusterd-op-sm.c@1117</a> <br>
seems to indicate this could be due to a typo error. Do you have a <br>
source install where you can apply this simple diff and see if it fixes <br>
the issue?<br></blockquote><div><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">I think you are right - I seem to have introduced it as part of <a href="https://github.com/gluster/glusterfs/commit/e081ac683b6a5bda54891318fa1e3ffac981e553">https://github.com/gluster/glusterfs/commit/e081ac683b6a5bda54891318fa1e3ffac981e553</a> - my bad.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">However, it was merged ~1 year ago, and no one has complained thus far... :-/</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">1. Is no one using NFS Ganesha? </div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">2. We are lacking tests for NFS Ganesha - code coverage indicates this path is not covered.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Y.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
diff --git a/xlators/mgmt/glusterd/src/glusterd-op-sm.c <br>
b/xlators/mgmt/glusterd/src/glusterd-op-sm.c<br>
index 558f04fb2..d7bf96adf 100644<br>
--- a/xlators/mgmt/glusterd/src/glusterd-op-sm.c<br>
+++ b/xlators/mgmt/glusterd/src/glusterd-op-sm.c<br>
@@ -1177,7 +1177,7 @@ glusterd_op_stage_set_volume(dict_t *dict, char <br>
**op_errstr)<br>
}<br>
} else if (len_strcmp(key, keylen, "ganesha.enable")) {<br>
key_matched = _gf_true;<br>
- if (!strcmp(value, "off") == 0) {<br>
+ if (strcmp(value, "off") == 0) {<br>
ret = ganesha_manage_export(dict, "off", _gf_true, <br>
op_errstr);<br>
if (ret)<br>
goto out;<br>
<br>
Thanks,<br>
<br>
Ravi<br>
><br>
> It's really strange that NFS Ganesha has ever passed the tests.<br>
> How do we test NFS Ganesha exporting ?<br>
><br>
> Best Regards,<br>
> Strahil Nikolov<br>
> _______________________________________________<br>
><br>
> Community Meeting Calendar:<br>
><br>
> Schedule -<br>
> Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC<br>
> Bridge: <a href="https://bluejeans.com/441850968" rel="noreferrer" target="_blank">https://bluejeans.com/441850968</a><br>
><br>
><br>
><br>
><br>
> Gluster-devel mailing list<br>
> <a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
> <a href="https://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">https://lists.gluster.org/mailman/listinfo/gluster-devel</a><br>
><br>
<br>
_______________________________________________<br>
<br>
Community Meeting Calendar:<br>
<br>
Schedule -<br>
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC<br>
Bridge: <a href="https://bluejeans.com/441850968" rel="noreferrer" target="_blank">https://bluejeans.com/441850968</a><br>
<br>
<br>
<br>
<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
<a href="https://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">https://lists.gluster.org/mailman/listinfo/gluster-devel</a><br>
<br>
</blockquote></div></div>