<div dir="ltr">If everyone agrees, I&#39;ll prepare a PR with the changes in rfc.sh and documentation to implement this change.<div><br></div><div>Xavi</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 15, 2020 at 1:27 PM Ravishankar N &lt;<a href="mailto:ravishankar@redhat.com">ravishankar@redhat.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
  
    
  
  <div>
    <p><br>
    </p>
    <div>On 15/10/20 4:36 pm, Sheetal Pamecha
      wrote:<br>
    </div>
    <blockquote type="cite">
      
      <div dir="ltr">
        <div class="gmail_quote"><br>
          <div>+1 </div>
          <div>Just a note to the maintainers who are merging PRs to
            have patience and check the commit message when there are
            more than 1 commits in PR.</div>
        </div>
      </div>
    </blockquote>
    <p>Makes sense.</p>
    <blockquote type="cite">
      <div dir="ltr">
        <div class="gmail_quote">
          <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
            <div dir="ltr">
              <div>
                <div class="gmail_quote">
                  <div> </div>
                  <div><br>
                  </div>
                  <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
                    <div dir="ltr">
                      <div>Another thing to consider is that rfc.sh
                        script always does a rebase before pushing
                        changes. This rewrites history and changes all
                        commits of a PR. I think we shouldn&#39;t do a
                        rebase in rfc.sh. Only if there are conflicts, I
                        would do a manual rebase and push the changes.</div>
                      <div><br>
                      </div>
                    </div>
                  </blockquote>
                  <div><br>
                  </div>
                  <div><br>
                  </div>
                </div>
              </div>
            </div>
          </blockquote>
        </div>
      </div>
    </blockquote>
    <p>I think we would also need to rebase if say some .t failure was
      fixed and we need to submit the PR on top of that, unless &quot;run
      regression&quot; always applies your PR on the latest HEAD in the
      concerned branch and triggers the regression.<br>
    </p>
    <br>
    <blockquote type="cite">
      <div dir="ltr">
        <div class="gmail_quote">
          <div><br>
          </div>
          <div>Actually True, Since the migration to github. I have not
            been using ./rfc.sh and For me it&#39;s easier and cleaner. <br>
          </div>
        </div>
      </div>
    </blockquote>
    <p><br>
    </p>
    <p>Me as well :)</p>
    -Ravi<br>
  </div>

_______________________________________________<br>
<br>
Community Meeting Calendar:<br>
<br>
Schedule -<br>
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC<br>
Bridge: <a href="https://bluejeans.com/441850968" rel="noreferrer" target="_blank">https://bluejeans.com/441850968</a><br>
<br>
<br>
<br>
<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
<a href="https://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">https://lists.gluster.org/mailman/listinfo/gluster-devel</a><br>
<br>
</blockquote></div>