<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 15/10/20 4:36 pm, Sheetal Pamecha
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CABw1KrsQ_YZE87rywjWXK=FP038H9SSjnvt0+LMcLYbSjto8qg@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div class="gmail_quote"><br>
<div>+1 </div>
<div>Just a note to the maintainers who are merging PRs to
have patience and check the commit message when there are
more than 1 commits in PR.</div>
</div>
</div>
</blockquote>
<p>Makes sense.</p>
<blockquote type="cite"
cite="mid:CABw1KrsQ_YZE87rywjWXK=FP038H9SSjnvt0+LMcLYbSjto8qg@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div>
<div class="gmail_quote">
<div> </div>
<div><br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px
0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div>Another thing to consider is that rfc.sh
script always does a rebase before pushing
changes. This rewrites history and changes all
commits of a PR. I think we shouldn't do a
rebase in rfc.sh. Only if there are conflicts, I
would do a manual rebase and push the changes.</div>
<div><br>
</div>
</div>
</blockquote>
<div><br>
</div>
<div><br>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
<p>I think we would also need to rebase if say some .t failure was
fixed and we need to submit the PR on top of that, unless "run
regression" always applies your PR on the latest HEAD in the
concerned branch and triggers the regression.<br>
</p>
<br>
<blockquote type="cite"
cite="mid:CABw1KrsQ_YZE87rywjWXK=FP038H9SSjnvt0+LMcLYbSjto8qg@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote">
<div><br>
</div>
<div>Actually True, Since the migration to github. I have not
been using ./rfc.sh and For me it's easier and cleaner. <br>
</div>
</div>
</div>
</blockquote>
<p><br>
</p>
<p>Me as well :)</p>
-Ravi<br>
</body>
</html>