<div><div dir="auto">There’s no hard requirement to have an op-version tagged against a release until and unless you introduce a new volume option. What you need to do is introduce a new macro with a higher value than max op version and set the max op version value to the same - just like how a new volume option is introduced. If you introduce a new macro with a value lower than max op version you’re calling for a trouble with backward compatibility and managing heterogeneous cluster.</div></div><div dir="auto"><br></div><div dir="auto">HTH</div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 29 Jan 2020 at 14:28, David Spisla <<a href="mailto:spisla80@gmail.com">spisla80@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Dear Gluster Devels,</div><div>i am using gluster 5.10 and want to introduce a new volume option. Therefore I want to set a proper GD_OP_VERSION for it. In gluster 5.10 source code there is no macro defined for 51000.</div><div><br></div><div>But concurrently the GD_OP_VERSION_MAX is set to 50400. I would do something like this:</div><div><br></div><div>1. Change in libglusterfs/src/globals-h (line 47)<br></div><div>#define GD_OP_VERSION_MAX \<br> GD_OP_VERSION_5_10</div><div>2. Add line to same Header file:</div><div>#define GD_OP_VERSION_5_10 51000 /* Op-version for GlusterFS 5.10 */</div><div><br> </div><div>Do you think this is fine? <br></div><div><br></div><div>3. libglusterfs/src/common-utils.c (line 2036): <br></div><div>On the other side there is a if-branch which uses GD_OP_VERSION_5_4 which is currently the
GD_OP_VERSION_MAX. Why it is used here and should I increase it also to
GD_OP_VERSION_5_10?</div><div><br></div><div>Regards</div><div>David Spisla<br>
</div></div>
_______________________________________________<br>
<br>
Community Meeting Calendar:<br>
<br>
APAC Schedule -<br>
Every 2nd and 4th Tuesday at 11:30 AM IST<br>
Bridge: <a href="https://bluejeans.com/441850968" rel="noreferrer" target="_blank">https://bluejeans.com/441850968</a><br>
<br>
<br>
NA/EMEA Schedule -<br>
Every 1st and 3rd Tuesday at 01:00 PM EDT<br>
Bridge: <a href="https://bluejeans.com/441850968" rel="noreferrer" target="_blank">https://bluejeans.com/441850968</a><br>
<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
<a href="https://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">https://lists.gluster.org/mailman/listinfo/gluster-devel</a><br>
<br>
</blockquote></div></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature">--Atin</div>