<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 21, 2019 at 1:02 PM Changwei Ge <<a href="mailto:chge@linux.alibaba.com">chge@linux.alibaba.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Amar,<br>
<br>
Thank you very much for your quick reply :-)<br>
<br>
On 2019/10/21 2:44 下午, Amar Tumballi wrote:<br>
> <br>
> <br>
> On Mon, Oct 21, 2019 at 11:58 AM Changwei Ge <<a href="mailto:chge@linux.alibaba.com" target="_blank">chge@linux.alibaba.com</a> <br>
> <mailto:<a href="mailto:chge@linux.alibaba.com" target="_blank">chge@linux.alibaba.com</a>>> wrote:<br>
> <br>
> Hi,<br>
> <br>
> I am recently working on optimizing inode searching/getting/putting<br>
> concurrency. Before the experiment/trial goes, I would like to get<br>
> fully<br>
> understand what the usage of several lists of inode table, especially<br>
> for 'invalidate list', since the major difficulty making inode<br>
> searching<br>
> run concurrently is that We have to move inode from one list to the<br>
> other and modify some attributes against inode table.<br>
> After reading corresponding code, it seems that inode table 'invalidate<br>
> list' is only retrieved when destroying inode<br>
> table(inode_table_destroy).<br>
> <br>
> Can someone help explain the list usage/purpose of 'invalidate list'?<br>
> <br>
> <br>
> 'invalidate_list' is used only in client side. The patch which got it is <br>
> below:<br>
> <br>
> <a href="https://github.com/gluster/glusterfs/commit/d49b41e817d592c1904b6f01716df6546dad3ebe" rel="noreferrer" target="_blank">https://github.com/gluster/glusterfs/commit/d49b41e817d592c1904b6f01716df6546dad3ebe</a> <br>
> <br>
> <br>
> Hope this gives some idea.<br>
<br>
Cool, this helps me to understand more deeply on inode table.<br>
I will check out other related commits as well.<br>
<br>
> <br>
> Happy to help. If there is an interest, we can even have a video <br>
> conference for all interested developers to discuss inode table, and <br>
> detail out how it is done.<br>
> <br>
<br>
Ack.<br>
As I think that inode table(how we manage inode/dentry) is one of the <br>
most critical parts of a certain type of FS, we should consider and <br>
design carefully hence run it efficiently.<br>
What I can see from glusterfs HEAD code is that we might have many <br>
locking contentions and burden too much logic into inode_[un]ref().<br></blockquote><div><br></div><div>This is true. And I tried couple of approaches. Couldn't get to take it to completion earlier.</div><div><br></div><div>* <a href="https://review.gluster.org/22242">https://review.gluster.org/22242</a></div><div>* <a href="https://review.gluster.org/22243">https://review.gluster.org/22243</a><br></div><div>* <a href="https://review.gluster.org/22186">https://review.gluster.org/22186</a></div><div>* <a href="https://review.gluster.org/22156">https://review.gluster.org/22156</a></div><div><br></div><div>* <a href="https://github.com/gluster/glusterfs/issues/204">https://github.com/gluster/glusterfs/issues/204</a></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
So how can we arrange a video conference and have a further discussion?<br>
<br></blockquote><div><br></div><div>Open for suggestions. We have weekly Community meeting, which can be extended to talk about this.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Thanks,<br>
Changwei<br>
<br>
> For getting complete history of changes to inode.c (from <br>
> <a href="https://github.com/amarts/glusterfs/commit/72db44413ce4686b465c29ea8383fa4f09f53a76" rel="noreferrer" target="_blank">https://github.com/amarts/glusterfs/commit/72db44413ce4686b465c29ea8383fa4f09f53a76</a>), <br>
> you can clone <a href="http://github.com/amarts/glusterfs" rel="noreferrer" target="_blank">github.com/amarts/glusterfs</a> <br>
> <<a href="http://github.com/amarts/glusterfs" rel="noreferrer" target="_blank">http://github.com/amarts/glusterfs</a>> and see that over time what changes <br>
> got into the file... 'git log libglusterfs/src/inode.c' gives an idea.<br>
> <br>
> Regards,<br>
> Amar<br>
> <br>
> <br>
> <br>
> Thanks,<br>
> Changwei<br>
> <br>
</blockquote></div></div>