<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:宋体;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"Segoe UI";
panose-1:2 11 5 2 4 2 4 2 2 3;}
@font-face
{font-family:"\@宋体";
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"\@等线";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:宋体;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:宋体;}
span.EmailStyle18
{mso-style-type:personal;
font-family:DengXian;
color:windowtext;}
span.EmailStyle19
{mso-style-type:personal;
font-family:DengXian;
color:windowtext;}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:DengXian;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="ZH-CN" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">From my code study it seems priv->ssl_ssl is not properly released, I made a patch and the glusterfsd memory leak is alleviated with my patch, but some otherwhere is still
leaking, I have no clue about the other leak points.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">--- a/rpc/rpc-transport/socket/src/socket.c<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">+++ b/rpc/rpc-transport/socket/src/socket.c<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">@@ -1019,7 +1019,16 @@ static void __socket_reset(rpc_transport_t *this) {<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"> memset(&priv->incoming, 0, sizeof(priv->incoming));<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"> event_unregister_close(this->ctx->event_pool, priv->sock, priv->idx);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">-<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">+ if(priv->use_ssl&& priv->ssl_ssl)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">+ {<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">+ gf_log(this->name, GF_LOG_TRACE,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">+ "clear and reset for socket(%d), free ssl ",<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">+ priv->sock);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">+ SSL_shutdown(priv->ssl_ssl);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">+ SSL_clear(priv->ssl_ssl);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">+ SSL_free(priv->ssl_ssl);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">+ priv->ssl_ssl = NULL;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">+ }<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"> priv->sock = -1;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"> priv->idx = -1;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"> priv->connected = -1;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">@@ -4238,6 +4250,16 @@ void fini(rpc_transport_t *this) {<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"> pthread_mutex_destroy(&priv->out_lock);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"> pthread_mutex_destroy(&priv->cond_lock);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"> pthread_cond_destroy(&priv->cond);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">+ if(priv->use_ssl&& priv->ssl_ssl)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">+ {<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">+ gf_log(this->name, GF_LOG_TRACE,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">+ "clear and reset for socket(%d), free ssl ",<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">+ priv->sock);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">+ SSL_shutdown(priv->ssl_ssl);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">+ SSL_clear(priv->ssl_ssl);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">+ SSL_free(priv->ssl_ssl);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">+ priv->ssl_ssl = NULL;<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">+ }<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"> if (priv->ssl_private_key) {<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"> GF_FREE(priv->ssl_private_key);<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"> }<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Zhou, Cynthia (NSB - CN/Hangzhou)
<br>
<b>Sent:</b> Thursday, April 18, 2019 5:31 PM<br>
<b>To:</b> 'Atin Mukherjee' <amukherj@redhat.com><br>
<b>Cc:</b> 'Raghavendra Gowdappa' <rgowdapp@redhat.com>; 'gluster-devel@gluster.org' <gluster-devel@gluster.org><br>
<b>Subject:</b> RE: [Gluster-devel] glusterfsd memory leak issue found after enable ssl<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">We scan it use memory-leak tool, there are following prints. We doubt some open ssl lib malloc is is not properly freed by glusterfs code.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:#1A1A1A">er+0x2af [</span><u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:blue">libglusterfs.so.0.0.1]\n\t\tstart_thread+0xda</span></u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:#1A1A1A">
[</span><u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:blue">libpthread-2.27.so</span></u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:#1A1A1A">]'<br>
</span><u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:blue">13580</span></u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:#1A1A1A"> bytes in 175 allocations from stack<br>
b'CRYPTO_malloc+0x58 [</span><u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:blue">libcrypto.so.1.0.2p</span></u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:#1A1A1A">]'<br>
</span><u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:blue">232904</span></u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:#1A1A1A"> bytes in 14 allocations from stack<br>
b'CRYPTO_malloc+0x58 [</span><u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:blue">libcrypto.so.1.0.2p]\n\t\t[unknown</span></u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:#1A1A1A">]'<br>
[15:41:56] Top 10 stacks with outstanding allocations:<br>
</span><u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:blue">8792</span></u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:#1A1A1A"> bytes in 14 allocations from stack<br>
b'CRYPTO_malloc+0x58 [</span><u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:blue">libcrypto.so.1.0.2p]\n\t\t[unknown</span></u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:#1A1A1A">]'<br>
</span><u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:blue">9408</span></u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:#1A1A1A"> bytes in 42 allocations from stack<br>
b'CRYPTO_realloc+0x4d [</span><u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:blue">libcrypto.so.1.0.2p</span></u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:#1A1A1A">]'<br>
</span><u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:blue">9723</span></u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:#1A1A1A"> bytes in 14 allocations from stack<br>
b'CRYPTO_malloc+0x58 [</span><u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:blue">libcrypto.so.1.0.2p]\n\t\t[unknown</span></u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:#1A1A1A">]'<br>
</span><u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:blue">10696</span></u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:#1A1A1A"> bytes in 21 allocations from stack<br>
b'CRYPTO_malloc+0x58 [</span><u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:blue">libcrypto.so.1.0.2p]\n\t\t[unknown</span></u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:#1A1A1A">]'<br>
</span><u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:blue">11319</span></u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:#1A1A1A"> bytes in 602 allocations from stack<br>
b'CRYPTO_malloc+0x58 [</span><u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:blue">libcrypto.so.1.0.2p]\n\t\t[unknown</span></u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:#1A1A1A">]'<br>
</span><u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:blue">11431</span></u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:#1A1A1A"> bytes in 518 allocations from stack<br>
b'CRYPTO_malloc+0x58 [</span><u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:blue">libcrypto.so.1.0.2p]\n\t\t[unknown</span></u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:#1A1A1A">]'<br>
</span><u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:blue">11704</span></u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:#1A1A1A"> bytes in 371 allocations from stack<br>
b'CRYPTO_malloc+0x58 [</span><u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:blue">libcrypto.so.1.0.2p]\n\t\t[unknown</span></u><span lang="EN-US" style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:#1A1A1A">]'<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">cynthia<o:p></o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Zhou, Cynthia (NSB - CN/Hangzhou)
<br>
<b>Sent:</b> Thursday, April 18, 2019 5:25 PM<br>
<b>To:</b> 'Atin Mukherjee' <<a href="mailto:amukherj@redhat.com">amukherj@redhat.com</a>><br>
<b>Cc:</b> Raghavendra Gowdappa <<a href="mailto:rgowdapp@redhat.com">rgowdapp@redhat.com</a>>;
<a href="mailto:gluster-devel@gluster.org">gluster-devel@gluster.org</a><br>
<b>Subject:</b> RE: [Gluster-devel] glusterfsd memory leak issue found after enable ssl<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">I</span><span style="font-size:10.5pt;font-family:DengXian">’<span lang="EN-US">ve test on glusterfs3.12.15 and glusterfs5.5 all have this issue, after enable tls ssl socket,
when execute gluster v heal <vol-name> info, will trigger glfshel to connect glusterfsd process, and cause glusterfsd process memory leak. Could you please try in your env?
<o:p></o:p></span></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian">cynthia<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:DengXian"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Atin Mukherjee <<a href="mailto:amukherj@redhat.com">amukherj@redhat.com</a>>
<br>
<b>Sent:</b> Thursday, April 18, 2019 1:19 PM<br>
<b>To:</b> Zhou, Cynthia (NSB - CN/Hangzhou) <<a href="mailto:cynthia.zhou@nokia-sbell.com">cynthia.zhou@nokia-sbell.com</a>><br>
<b>Cc:</b> Raghavendra Gowdappa <<a href="mailto:rgowdapp@redhat.com">rgowdapp@redhat.com</a>>;
<a href="mailto:gluster-devel@gluster.org">gluster-devel@gluster.org</a><br>
<b>Subject:</b> Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<div>
<div>
<p class="MsoNormal"><span lang="EN-US">On Wed, 17 Apr 2019 at 10:53, Zhou, Cynthia (NSB - CN/Hangzhou) <<a href="mailto:cynthia.zhou@nokia-sbell.com">cynthia.zhou@nokia-sbell.com</a>> wrote:<o:p></o:p></span></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0cm;margin-bottom:5.0pt">
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US">Hi,<o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span lang="EN-US">In my recent test, I found that there are very severe glusterfsd memory leak when enable socket ssl option<o:p></o:p></span></p>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">What gluster version are you testing? Would you be able to continue your investigation and share the root cause? <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
</div>
</div>
<p class="MsoNormal"><span lang="EN-US">-- <o:p></o:p></span></p>
<div>
<p class="MsoNormal"><span lang="EN-US">- Atin (atinm)<o:p></o:p></span></p>
</div>
</div>
</body>
</html>