<div dir="ltr"><div dir="ltr"><div>Hi,</div><div><br></div><div>  I want to highlight recent bug(<a href="https://bugzilla.redhat.com/show_bug.cgi?id=1699025">https://bugzilla.redhat.com/show_bug.cgi?id=1699025</a>) due to raised after fixed one Coverity </div><div>   bug <a href="https://review.gluster.org/#/c/glusterfs/+/20720/">https://review.gluster.org/#/c/glusterfs/+/20720/</a></div><div>  As we know all <span class="gmail-gr_ gmail-gr_137 gmail-gr-alert gmail-gr_spell gmail-gr_inline_cards gmail-gr_run_anim gmail-ContextualSpelling gmail-ins-del gmail-multiReplace" id="gmail-137" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat;color:inherit;font-size:inherit">gluster</span> processes initially keeping open standard <span class="gmail-gr_ gmail-gr_138 gmail-gr-alert gmail-gr_spell gmail-gr_inline_cards gmail-gr_run_anim gmail-ContextualSpelling" id="gmail-138" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat;color:inherit;font-size:inherit">fd&#39;s</span> (0,1,2) at the time of daemonizing so that kernel</div><div>  don&#39;t assign these <span class="gmail-gr_ gmail-gr_318 gmail-gr-alert gmail-gr_gramm gmail-gr_inline_cards gmail-gr_run_anim gmail-Grammar gmail-multiReplace" id="gmail-318" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat;color:inherit;font-size:inherit">fd&#39;s</span> to any <span class="gmail-gr_ gmail-gr_218 gmail-gr-alert gmail-gr_spell gmail-gr_inline_cards gmail-gr_run_anim gmail-ContextualSpelling" id="gmail-218" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat;color:inherit;font-size:inherit">fd</span> open by <span class="gmail-gr_ gmail-gr_23 gmail-gr-alert gmail-gr_gramm gmail-gr_inline_cards gmail-gr_disable_anim_appear gmail-Grammar gmail-only-ins gmail-doubleReplace gmail-replaceWithoutSep" id="gmail-23" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat"><span class="gmail-gr_ gmail-gr_217 gmail-gr-alert gmail-gr_spell gmail-gr_inline_cards gmail-gr_run_anim gmail-ContextualSpelling gmail-ins-del gmail-multiReplace" id="gmail-217" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat;color:inherit;font-size:inherit">gluster</span></span> process. In this Coverity bug, we closed <span class="gmail-gr_ gmail-gr_38 gmail-gr-alert gmail-gr_spell gmail-gr_inline_cards gmail-gr_disable_anim_appear gmail-ContextualSpelling" id="gmail-38" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat">fd</span> in changelog <span class="gmail-gr_ gmail-gr_35 gmail-gr-alert gmail-gr_spell gmail-gr_inline_cards gmail-gr_disable_anim_appear gmail-ContextualSpelling gmail-ins-del gmail-multiReplace" id="gmail-35" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat">fini</span> if <span class="gmail-gr_ gmail-gr_39 gmail-gr-alert gmail-gr_spell gmail-gr_inline_cards gmail-gr_disable_anim_appear gmail-ContextualSpelling" id="gmail-39" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat">fd</span> value is not equal to -1.</div><div>  As we know GF_CALLOC initializes to all structure members to 0 so initial <span class="gmail-gr_ gmail-gr_18 gmail-gr-alert gmail-gr_spell gmail-gr_inline_cards gmail-gr_disable_anim_appear gmail-ContextualSpelling" id="gmail-18" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat;color:inherit;font-size:inherit">fd</span> value was 0 and changelog_init did not open htime_fd </div>  because changelog was not active so at the time of calling changelog <span class="gmail-gr_ gmail-gr_443 gmail-gr-alert gmail-gr_spell gmail-gr_inline_cards gmail-gr_run_anim gmail-ContextualSpelling gmail-ins-del gmail-multiReplace" id="gmail-443" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat">fini</span> it closes <span class="gmail-gr_ gmail-gr_19 gmail-gr-alert gmail-gr_spell gmail-gr_inline_cards gmail-gr_disable_anim_appear gmail-ContextualSpelling" id="gmail-19" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat">fd</span>(0). After closing <span class="gmail-gr_ gmail-gr_20 gmail-gr-alert gmail-gr_spell gmail-gr_inline_cards gmail-gr_disable_anim_appear gmail-ContextualSpelling" id="gmail-20" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat">fd</span>(0) by changelog <span class="gmail-gr_ gmail-gr_16 gmail-gr-alert gmail-gr_spell gmail-gr_inline_cards gmail-gr_disable_anim_appear gmail-ContextualSpelling gmail-ins-del gmail-multiReplace" id="gmail-16" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat">fini</span> if <span class="gmail-gr_ gmail-gr_808 gmail-gr-alert gmail-gr_gramm gmail-gr_inline_cards gmail-gr_run_anim gmail-Style gmail-multiReplace" id="gmail-808" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat">any</span><div><span class="gmail-gr_ gmail-gr_808 gmail-gr-alert gmail-gr_gramm gmail-gr_inline_cards gmail-gr_disable_anim_appear gmail-Style gmail-multiReplace" id="gmail-808" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat;color:inherit;font-size:inherit">  client</span>(shd) is trying to establish a connection with the server(in the brick_mux environment), the server <span class="gmail-gr_ gmail-gr_781 gmail-gr-alert gmail-gr_gramm gmail-gr_inline_cards gmail-gr_run_anim gmail-Grammar gmail-multiReplace" id="gmail-781" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat;color:inherit;font-size:inherit">gets</span> <span class="gmail-gr_ gmail-gr_21 gmail-gr-alert gmail-gr_spell gmail-gr_inline_cards gmail-gr_disable_anim_appear gmail-ContextualSpelling" id="gmail-21" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat">fd</span>(0) as a socket <span class="gmail-gr_ gmail-gr_17 gmail-gr-alert gmail-gr_spell gmail-gr_inline_cards gmail-gr_disable_anim_appear gmail-ContextualSpelling gmail-ins-del gmail-multiReplace" id="gmail-17" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat">fd</span>. </div><div>  I have observed socket event framework (socket_event_handler) was not working perfectly for <span class="gmail-gr_ gmail-gr_22 gmail-gr-alert gmail-gr_spell gmail-gr_inline_cards gmail-gr_disable_anim_appear gmail-ContextualSpelling" id="gmail-22" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat">fd</span>(0) while</div><div>  volumes are stopped in a loop in brick_mux environment and bricks are not detached successfully.</div><div><br></div><div>  So always we should careful at the time of closing <span class="gmail-gr_ gmail-gr_13 gmail-gr-alert gmail-gr_spell gmail-gr_inline_cards gmail-gr_disable_anim_appear gmail-ContextualSpelling" id="gmail-13" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat;color:inherit;font-size:inherit">fd</span>, before closing <span class="gmail-gr_ gmail-gr_12 gmail-gr-alert gmail-gr_spell gmail-gr_inline_cards gmail-gr_disable_anim_appear gmail-ContextualSpelling gmail-ins-del gmail-multiReplace" id="gmail-12" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat;color:inherit;font-size:inherit">fd</span> in default case we should check <span class="gmail-gr_ gmail-gr_14 gmail-gr-alert gmail-gr_spell gmail-gr_inline_cards gmail-gr_disable_anim_appear gmail-ContextualSpelling" id="gmail-14" style="display:inline;border-bottom:2px solid transparent;background-repeat:no-repeat;color:inherit;font-size:inherit">fd</span> should not be zero.</div><div>  I have fixed the same from (<a href="https://review.gluster.org/#/c/glusterfs/+/22549/">https://review.gluster.org/#/c/glusterfs/+/22549/</a>) and upload a .t also.</div><div><br></div><div>Regards,</div><div>Mohit Agrawal </div><div><br></div></div></div>