<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.E-MailFormatvorlage18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="DE" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Hello Amar,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">no problem. How can I do that? Can you please tell me the procedure?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Regards<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">David<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b>Von:</b> Amar Tumballi Suryanarayan <atumball@redhat.com>
<br>
<b>Gesendet:</b> Mittwoch, 20. Februar 2019 14:18<br>
<b>An:</b> David Spisla <spisla80@gmail.com><br>
<b>Cc:</b> Gluster Devel <gluster-devel@gluster.org><br>
<b>Betreff:</b> Re: [Gluster-devel] md-cache: May bug found in md-cache.c<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Hi David, <o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Thanks for the patch, it got merged in master now. Can you please post it into release branches, so we can take them in release-6, release-5 branch, so next releases can have them.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Regards,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Amar<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Tue, Feb 19, 2019 at 8:49 PM David Spisla <<a href="mailto:spisla80@gmail.com">spisla80@gmail.com</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<div>
<p class="MsoNormal">Hello,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">I already open a bug:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><a href="https://bugzilla.redhat.com/show_bug.cgi?id=1678726" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=1678726</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">There is also a link to a bug fix patch<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Regards<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">David Spisla<o:p></o:p></p>
</div>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">Am Di., 19. Feb. 2019 um 13:07 Uhr schrieb David Spisla <<a href="mailto:spisla80@gmail.com" target="_blank">spisla80@gmail.com</a>>:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<div>
<p class="MsoNormal">Hi folks,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">The 'struct md_cache' in md-cache.c uses int data types which are not in common with the data types used in the 'struct iatt' in iatt.h . If one take a closer look to the implementations one can see that the struct in md-cache.c uses still
the int data types like in the struct 'old_iatt' . This can lead to unexpected side effects and some values of iatt maybe will not mapped correctly. I would suggest to open a bug report. What do you think?<br>
<br>
Additional info:<br>
<br>
struct md_cache {<br>
ia_prot_t md_prot;<br>
uint32_t md_nlink;<br>
uint32_t md_uid;<br>
uint32_t md_gid;<br>
uint32_t md_atime;<br>
uint32_t md_atime_nsec;<br>
uint32_t md_mtime;<br>
uint32_t md_mtime_nsec;<br>
uint32_t md_ctime;<br>
uint32_t md_ctime_nsec;<br>
uint64_t md_rdev;<br>
uint64_t md_size;<br>
uint64_t md_blocks;<br>
uint64_t invalidation_time;<br>
uint64_t generation;<br>
dict_t *xattr;<br>
char *linkname;<br>
time_t ia_time;<br>
time_t xa_time;<br>
gf_boolean_t need_lookup;<br>
gf_boolean_t valid;<br>
gf_boolean_t gen_rollover;<br>
gf_boolean_t invalidation_rollover;<br>
gf_lock_t lock;<br>
};<br>
<br>
struct iatt {<br>
uint64_t ia_flags;<br>
uint64_t ia_ino; /* inode number */<br>
uint64_t ia_dev; /* backing device ID */<br>
uint64_t ia_rdev; /* device ID (if special file) */<br>
uint64_t ia_size; /* file size in bytes */<br>
uint32_t ia_nlink; /* Link count */<br>
uint32_t ia_uid; /* user ID of owner */<br>
uint32_t ia_gid; /* group ID of owner */<br>
uint32_t ia_blksize; /* blocksize for filesystem I/O */<br>
uint64_t ia_blocks; /* number of 512B blocks allocated */<br>
int64_t ia_atime; /* last access time */<br>
int64_t ia_mtime; /* last modification time */<br>
int64_t ia_ctime; /* last status change time */<br>
int64_t ia_btime; /* creation time. Fill using statx */<br>
uint32_t ia_atime_nsec;<br>
uint32_t ia_mtime_nsec;<br>
uint32_t ia_ctime_nsec;<br>
uint32_t ia_btime_nsec;<br>
uint64_t ia_attributes; /* chattr related:compressed, immutable,<br>
* append only, encrypted etc.*/<br>
uint64_t ia_attributes_mask; /* Mask for the attributes */<br>
<br>
uuid_t ia_gfid;<br>
ia_type_t ia_type; /* type of file */<br>
ia_prot_t ia_prot; /* protection */<br>
};<br>
<br>
struct old_iatt {<br>
uint64_t ia_ino; /* inode number */<br>
uuid_t ia_gfid;<br>
uint64_t ia_dev; /* backing device ID */<br>
ia_type_t ia_type; /* type of file */<br>
ia_prot_t ia_prot; /* protection */<br>
uint32_t ia_nlink; /* Link count */<br>
uint32_t ia_uid; /* user ID of owner */<br>
uint32_t ia_gid; /* group ID of owner */<br>
uint64_t ia_rdev; /* device ID (if special file) */<br>
uint64_t ia_size; /* file size in bytes */<br>
uint32_t ia_blksize; /* blocksize for filesystem I/O */<br>
uint64_t ia_blocks; /* number of 512B blocks allocated */<br>
uint32_t ia_atime; /* last access time */<br>
uint32_t ia_atime_nsec;<br>
uint32_t ia_mtime; /* last modification time */<br>
uint32_t ia_mtime_nsec;<br>
uint32_t ia_ctime; /* last status change time */<br>
uint32_t ia_ctime_nsec;<br>
};<o:p></o:p></p>
</div>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal">_______________________________________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
<a href="https://lists.gluster.org/mailman/listinfo/gluster-devel" target="_blank">https://lists.gluster.org/mailman/listinfo/gluster-devel</a><o:p></o:p></p>
</blockquote>
</div>
<p class="MsoNormal"><br clear="all">
<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal">-- <o:p></o:p></p>
<div>
<div>
<div>
<div>
<div>
<p class="MsoNormal">Amar Tumballi (amarts)<o:p></o:p></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>