<div dir="ltr"><div dir="ltr"><div dir="ltr">Hi David,<div><br></div><div><a href="https://docs.gluster.org/en/latest/Developer-guide/Backport-Guidelines/">https://docs.gluster.org/en/latest/Developer-guide/Backport-Guidelines/</a> gives more details about it.<br></div><div><br></div><div>But easiest is to go to your patch (<a href="https://review.gluster.org/22234">https://review.gluster.org/22234</a>), and then click on 'Cherry Pick' button. In the pop-up, 'branch:' field, give 'release-6' and Submit. If you want it in release-5 branch too, repeat the same, with branch being 'release-5'. Siimlarly we need 'clone-of' bug for both the branches (the original bug used in patch is for master branch).</div><div><br></div><div>That should be it. Rest, we can take care.</div><div><br></div><div>Thanks a lot!</div><div><br></div><div>Regards,</div><div>Amar</div><div></div></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Feb 20, 2019 at 6:58 PM David Spisla <<a href="mailto:david.spisla@iternity.com">david.spisla@iternity.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="DE">
<div class="gmail-m_60964825300009873WordSection1">
<p class="MsoNormal"><span>Hello Amar,<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><span>no problem. How can I do that? Can you please tell me the procedure?<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><span>Regards<u></u><u></u></span></p>
<p class="MsoNormal"><span>David<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<div style="border-top:none;border-right:none;border-bottom:none;border-left:1.5pt solid blue;padding:0cm 0cm 0cm 4pt">
<div>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(225,225,225);padding:3pt 0cm 0cm">
<p class="MsoNormal"><b>Von:</b> Amar Tumballi Suryanarayan <<a href="mailto:atumball@redhat.com" target="_blank">atumball@redhat.com</a>>
<br>
<b>Gesendet:</b> Mittwoch, 20. Februar 2019 14:18<br>
<b>An:</b> David Spisla <<a href="mailto:spisla80@gmail.com" target="_blank">spisla80@gmail.com</a>><br>
<b>Cc:</b> Gluster Devel <<a href="mailto:gluster-devel@gluster.org" target="_blank">gluster-devel@gluster.org</a>><br>
<b>Betreff:</b> Re: [Gluster-devel] md-cache: May bug found in md-cache.c<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">Hi David, <u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Thanks for the patch, it got merged in master now. Can you please post it into release branches, so we can take them in release-6, release-5 branch, so next releases can have them.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Regards,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Amar<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Tue, Feb 19, 2019 at 8:49 PM David Spisla <<a href="mailto:spisla80@gmail.com" target="_blank">spisla80@gmail.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0cm 0cm 0cm 6pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<div>
<p class="MsoNormal">Hello,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">I already open a bug:<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><a href="https://bugzilla.redhat.com/show_bug.cgi?id=1678726" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=1678726</a><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">There is also a link to a bug fix patch<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Regards<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">David Spisla<u></u><u></u></p>
</div>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">Am Di., 19. Feb. 2019 um 13:07 Uhr schrieb David Spisla <<a href="mailto:spisla80@gmail.com" target="_blank">spisla80@gmail.com</a>>:<u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0cm 0cm 0cm 6pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<div>
<p class="MsoNormal">Hi folks,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">The 'struct md_cache' in md-cache.c uses int data types which are not in common with the data types used in the 'struct iatt' in iatt.h . If one take a closer look to the implementations one can see that the struct in md-cache.c uses still
the int data types like in the struct 'old_iatt' . This can lead to unexpected side effects and some values of iatt maybe will not mapped correctly. I would suggest to open a bug report. What do you think?<br>
<br>
Additional info:<br>
<br>
struct md_cache {<br>
ia_prot_t md_prot;<br>
uint32_t md_nlink;<br>
uint32_t md_uid;<br>
uint32_t md_gid;<br>
uint32_t md_atime;<br>
uint32_t md_atime_nsec;<br>
uint32_t md_mtime;<br>
uint32_t md_mtime_nsec;<br>
uint32_t md_ctime;<br>
uint32_t md_ctime_nsec;<br>
uint64_t md_rdev;<br>
uint64_t md_size;<br>
uint64_t md_blocks;<br>
uint64_t invalidation_time;<br>
uint64_t generation;<br>
dict_t *xattr;<br>
char *linkname;<br>
time_t ia_time;<br>
time_t xa_time;<br>
gf_boolean_t need_lookup;<br>
gf_boolean_t valid;<br>
gf_boolean_t gen_rollover;<br>
gf_boolean_t invalidation_rollover;<br>
gf_lock_t lock;<br>
};<br>
<br>
struct iatt {<br>
uint64_t ia_flags;<br>
uint64_t ia_ino; /* inode number */<br>
uint64_t ia_dev; /* backing device ID */<br>
uint64_t ia_rdev; /* device ID (if special file) */<br>
uint64_t ia_size; /* file size in bytes */<br>
uint32_t ia_nlink; /* Link count */<br>
uint32_t ia_uid; /* user ID of owner */<br>
uint32_t ia_gid; /* group ID of owner */<br>
uint32_t ia_blksize; /* blocksize for filesystem I/O */<br>
uint64_t ia_blocks; /* number of 512B blocks allocated */<br>
int64_t ia_atime; /* last access time */<br>
int64_t ia_mtime; /* last modification time */<br>
int64_t ia_ctime; /* last status change time */<br>
int64_t ia_btime; /* creation time. Fill using statx */<br>
uint32_t ia_atime_nsec;<br>
uint32_t ia_mtime_nsec;<br>
uint32_t ia_ctime_nsec;<br>
uint32_t ia_btime_nsec;<br>
uint64_t ia_attributes; /* chattr related:compressed, immutable,<br>
* append only, encrypted etc.*/<br>
uint64_t ia_attributes_mask; /* Mask for the attributes */<br>
<br>
uuid_t ia_gfid;<br>
ia_type_t ia_type; /* type of file */<br>
ia_prot_t ia_prot; /* protection */<br>
};<br>
<br>
struct old_iatt {<br>
uint64_t ia_ino; /* inode number */<br>
uuid_t ia_gfid;<br>
uint64_t ia_dev; /* backing device ID */<br>
ia_type_t ia_type; /* type of file */<br>
ia_prot_t ia_prot; /* protection */<br>
uint32_t ia_nlink; /* Link count */<br>
uint32_t ia_uid; /* user ID of owner */<br>
uint32_t ia_gid; /* group ID of owner */<br>
uint64_t ia_rdev; /* device ID (if special file) */<br>
uint64_t ia_size; /* file size in bytes */<br>
uint32_t ia_blksize; /* blocksize for filesystem I/O */<br>
uint64_t ia_blocks; /* number of 512B blocks allocated */<br>
uint32_t ia_atime; /* last access time */<br>
uint32_t ia_atime_nsec;<br>
uint32_t ia_mtime; /* last modification time */<br>
uint32_t ia_mtime_nsec;<br>
uint32_t ia_ctime; /* last status change time */<br>
uint32_t ia_ctime_nsec;<br>
};<u></u><u></u></p>
</div>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal">_______________________________________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
<a href="https://lists.gluster.org/mailman/listinfo/gluster-devel" target="_blank">https://lists.gluster.org/mailman/listinfo/gluster-devel</a><u></u><u></u></p>
</blockquote>
</div>
<p class="MsoNormal"><br clear="all">
<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<p class="MsoNormal">-- <u></u><u></u></p>
<div>
<div>
<div>
<div>
<div>
<p class="MsoNormal">Amar Tumballi (amarts)<u></u><u></u></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Amar Tumballi (amarts)<br></div></div></div></div></div>