<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr">On Wed, 9 Jan 2019 at 08:28, Amar Tumballi Suryanarayan <<a href="mailto:atumball@redhat.com">atumball@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jan 8, 2019 at 8:04 PM Shyam Ranganathan <<a href="mailto:srangana@redhat.com" target="_blank">srangana@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 1/8/19 8:33 AM, Nithya Balachandran wrote:<br>
> Shyam, what is your take on this?<br>
> An upstream user has tried it out and reported that it seems to fix the<br>
> issue , however cpu utilization doubles.<br>
<br>
We usually do not backport big fixes unless they are critical. My first<br>
answer would be, can't this wait for rel-6 which is up next?<br>
<br></blockquote><div>Considering it may take some more time to get adoption, doing a backport may surely benefit users, IMO. </div><div> </div></div></div></blockquote><div>I agree. This is a pain point for several users and I would like to have folks be able to try this out earlier and provide feedback.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
The change has gone through a good review overall, so from a review<br>
thoroughness perspective it looks good.<br>
<br>
The change has a test case to ensure that the limits are honored, so<br>
again a plus.<br>
<br>
Also, it is a switch, so in the worst case moving back to unlimited<br>
should be possible with little adverse effects in case the fix has issues.<br>
<br>
It hence, comes down to how confident are we that the change is not<br>
disruptive to an existing branch? If we can answer this with resonable<br>
confidence we can backport it and release it with the next 5.x update<br>
release.<br>
<br></blockquote><div> </div><div>Considering the code which the patch changes has changed very little over last few years, I feel it is</div><div>totally safe to do the backport. Don't see any possible surprises. Will send a patch today on release-5 branch.</div><div><br></div><div>-Amar</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> <br>
> Regards,<br>
> Nithya<br>
> <br>
> On Fri, 28 Dec 2018 at 09:17, Amar Tumballi <<a href="mailto:atumball@redhat.com" target="_blank">atumball@redhat.com</a><br>
> <mailto:<a href="mailto:atumball@redhat.com" target="_blank">atumball@redhat.com</a>>> wrote:<br>
> <br>
> I feel its good to backport considering glusterfs-6.0 is another 2<br>
> months away.<br>
> <br>
> On Fri, Dec 28, 2018 at 8:19 AM Nithya Balachandran<br>
> <<a href="mailto:nbalacha@redhat.com" target="_blank">nbalacha@redhat.com</a> <mailto:<a href="mailto:nbalacha@redhat.com" target="_blank">nbalacha@redhat.com</a>>> wrote:<br>
> <br>
> Hi,<br>
> <br>
> Can we backport this to release-5 ? We have several reports of<br>
> high memory usage in fuse clients from users and this is likely<br>
> to help.<br>
> <br>
> Regards,<br>
> Nithya<br>
> _______________________________________________<br>
> Gluster-devel mailing list<br>
> <a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a> <mailto:<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a>><br>
> <a href="https://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">https://lists.gluster.org/mailman/listinfo/gluster-devel</a><br>
> <br>
> <br>
> <br>
> -- <br>
> Amar Tumballi (amarts)<br>
> <br>
> <br>
> _______________________________________________<br>
> Gluster-devel mailing list<br>
> <a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
> <a href="https://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">https://lists.gluster.org/mailman/listinfo/gluster-devel</a><br>
> <br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail-m_9053492950317856036gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Amar Tumballi (amarts)<br></div></div></div></div></div></div>
</blockquote></div></div>