<div dir="ltr"><div>Thanks for this initiative. This is very helpful. </div><div><br></div><div>Also noticed that all of the coverity issues of 'INCLUDE_RECURSION' would also be solved by this list. I haven't analysed the whole list yet, but the first 1000s of lines revealed that this is very useful.</div><div><br></div><div>-Amar</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Dec 25, 2018 at 10:18 PM Yaniv Kaul <<a href="mailto:ykaul@redhat.com">ykaul@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Now that I've fixed the paths, the attached report is a more accurate representation.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Regretfully, it's not easy to apply as a patch.</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Dec 25, 2018 at 9:53 AM Yaniv Kaul <<a href="mailto:ykaul@redhat.com" target="_blank">ykaul@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">I'm not sure I'm using it correctly and I'm having trouble compiling it from source on my F29 machine, but include-what-you-use (<a href="https://include-what-you-use.org" target="_blank">https://include-what-you-use.org</a> ) allows you to easily analyze your include statements and ensure accuracy. I believe it has found some issues in our code - I certainly could remove some unneeded includes - but I'm unsure if I need to follow all of its advises to make things work, otherwise something will surely break.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Attached please find the full analysis - hope it's useful for someone. I believe once we figure out how to use it properly, it can be a good tool - will probably reduce compile time in a negligible way too.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Y.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div></div></div></div>
</blockquote></div>
_______________________________________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
<a href="https://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">https://lists.gluster.org/mailman/listinfo/gluster-devel</a></blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Amar Tumballi (amarts)<br></div></div></div></div></div>