<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Fri, Oct 5, 2018 at 9:34 AM Raghavendra Gowdappa <<a href="mailto:rgowdapp@redhat.com">rgowdapp@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Fri, Oct 5, 2018 at 9:11 AM Kaushal M <<a href="mailto:kshlmster@gmail.com" target="_blank">kshlmster@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Fri, Oct 5, 2018 at 9:05 AM Raghavendra Gowdappa <<a href="mailto:rgowdapp@redhat.com" target="_blank">rgowdapp@redhat.com</a>> wrote:<br>
><br>
><br>
><br>
> On Fri, Oct 5, 2018 at 8:53 AM Amar Tumballi <<a href="mailto:atumball@redhat.com" target="_blank">atumball@redhat.com</a>> wrote:<br>
>><br>
>> Can you try below diff in your rfc, and let me know if it works?<br>
><br>
><br>
> No. it didn't. I see the same error.<br>
> [rgowdapp@rgowdapp glusterfs]$ ./rfc.sh<br>
> + rebase_changes<br>
> + GIT_EDITOR=./rfc.sh<br>
> + git rebase -i origin/master<br>
> [detached HEAD e50667e] cluster/dht: clang-format dht-common.c<br>
> 1 file changed, 10674 insertions(+), 11166 deletions(-)<br>
> rewrite xlators/cluster/dht/src/dht-common.c (88%)<br>
> [detached HEAD 0734847] cluster/dht: fixes to unlinking invalid linkto file<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
> [detached HEAD 7aeba07] rfc.sh: test - DO NOT MERGE<br>
> 1 file changed, 8 insertions(+), 3 deletions(-)<br>
> Successfully rebased and updated refs/heads/1635145.<br>
> + check_backport<br>
> + moveon=N<br>
> + '[' master = master ']'<br>
> + return<br>
> + assert_diverge<br>
> + git diff origin/master..HEAD<br>
> + grep -q .<br>
> ++ git log -n1 --format=%b<br>
> ++ grep -ow -E '([fF][iI][xX][eE][sS]|[uU][pP][dD][aA][tT][eE][sS])(:)?[[:space:]]+(gluster\/glusterfs)?(bz)?#[[:digit:]]+'<br>
> ++ awk -F '#' '{print $2}'<br>
> + reference=1635145<br>
> + '[' -z 1635145 ']'<br>
> ++ clang-format --version<br>
> + clang_format='LLVM (<a href="http://llvm.org/" rel="noreferrer" target="_blank">http://llvm.org/</a>):<br>
> LLVM version 3.4.2<br>
> Optimized build.<br>
> Built Dec 7 2015 (09:37:36).<br>
> Default target: x86_64-redhat-linux-gnu<br>
> Host CPU: x86-64'<br>
<br>
This is a pretty old version of clang. Maybe this is the problem?<br></blockquote><div><br></div><div>Yes. That's what I suspected too. Trying to get repos for the upgrade.<br></div></div></div></blockquote><div><br></div><div>But, what's surprising is that script exits.<br> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
><br>
>><br>
>> ```<br>
>>><br>
>>> diff --git a/rfc.sh b/rfc.sh<br>
>>> index 607fd7528f..4ffef26ca1 100755<br>
>>> --- a/rfc.sh<br>
>>> +++ b/rfc.sh<br>
>>> @@ -321,21 +321,21 @@ main()<br>
>>> fi<br>
>>><br>
>>> # TODO: add clang-format command here. It will after the changes are done everywhere else<br>
>>> + set +e<br>
>>> clang_format=$(clang-format --version)<br>
>>> if [ ! -z "${clang_format}" ]; then<br>
>>> # Considering git show may not give any files as output matching the<br>
>>> # criteria, good to tell script not to fail on error<br>
>>> - set +e<br>
>>> list_of_files=$(git show --pretty="format:" --name-only |<br>
>>> grep -v "contrib/" | egrep --color=never "*\.[ch]$");<br>
>>> if [ ! -z "${list_of_files}" ]; then<br>
>>> echo "${list_of_files}" | xargs clang-format -i<br>
>>> fi<br>
>>> - set -e<br>
>>> else<br>
>>> echo "High probability of your patch not passing smoke due to coding standard check"<br>
>>> echo "Please install 'clang-format' to format the patch before submitting"<br>
>>> fi<br>
>>> + set -e<br>
>>><br>
>>> if [ "$DRY_RUN" = 1 ]; then<br>
>>> drier='echo -e Please use the following command to send your commits to review:\n\n'<br>
>><br>
>> ```<br>
>> -Amar<br>
>><br>
>> On Fri, Oct 5, 2018 at 8:09 AM Raghavendra Gowdappa <<a href="mailto:rgowdapp@redhat.com" target="_blank">rgowdapp@redhat.com</a>> wrote:<br>
>>><br>
>>> All,<br>
>>><br>
>>> [rgowdapp@rgowdapp glusterfs]$ ./rfc.sh<br>
>>> + rebase_changes<br>
>>> + GIT_EDITOR=./rfc.sh<br>
>>> + git rebase -i origin/master<br>
>>> [detached HEAD 34fabdd] cluster/dht: clang-format dht-common.c<br>
>>> 1 file changed, 10674 insertions(+), 11166 deletions(-)<br>
>>> rewrite xlators/cluster/dht/src/dht-common.c (88%)<br>
>>> [detached HEAD 4bbcbf9] cluster/dht: fixes to unlinking invalid linkto file<br>
>>> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
>>> [detached HEAD c5583ea] rfc.sh: test - DO NOT MERGE<br>
>>> 1 file changed, 8 insertions(+), 3 deletions(-)<br>
>>> Successfully rebased and updated refs/heads/1635145.<br>
>>> + check_backport<br>
>>> + moveon=N<br>
>>> + '[' master = master ']'<br>
>>> + return<br>
>>> + assert_diverge<br>
>>> + git diff origin/master..HEAD<br>
>>> + grep -q .<br>
>>> ++ git log -n1 --format=%b<br>
>>> ++ grep -ow -E '([fF][iI][xX][eE][sS]|[uU][pP][dD][aA][tT][eE][sS])(:)?[[:space:]]+(gluster\/glusterfs)?(bz)?#[[:digit:]]+'<br>
>>> ++ awk -F '#' '{print $2}'<br>
>>> + reference=1635145<br>
>>> + '[' -z 1635145 ']'<br>
>>> ++ clang-format --version<br>
>>> + clang_format='LLVM (<a href="http://llvm.org/" rel="noreferrer" target="_blank">http://llvm.org/</a>):<br>
>>> LLVM version 3.4.2<br>
>>> Optimized build.<br>
>>> Built Dec 7 2015 (09:37:36).<br>
>>> Default target: x86_64-redhat-linux-gnu<br>
>>> Host CPU: x86-64'<br>
>>><br>
>>> Looks like the script is exiting right after it completes clang-format --version. Nothing after that statement gets executed (did it crash? I don't see any cores). Any help is appreciated<br>
>>><br>
>>> regards,<br>
>>> Raghavendra<br>
>>><br>
>>> _______________________________________________<br>
>>> Gluster-devel mailing list<br>
>>> <a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
>>> <a href="https://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">https://lists.gluster.org/mailman/listinfo/gluster-devel</a><br>
>><br>
>><br>
>><br>
>> --<br>
>> Amar Tumballi (amarts)<br>
><br>
> _______________________________________________<br>
> Gluster-devel mailing list<br>
> <a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
> <a href="https://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">https://lists.gluster.org/mailman/listinfo/gluster-devel</a><br>
</blockquote></div></div>
</blockquote></div></div>