<div dir="ltr"><div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Fri, Oct 5, 2018 at 9:58 AM Sachidananda URS <<a href="mailto:surs@redhat.com">surs@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 5, 2018 at 9:45 AM, Raghavendra Gowdappa <span dir="ltr"><<a href="mailto:rgowdapp@redhat.com" target="_blank">rgowdapp@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><br><div class="gmail_quote"><div><div class="gmail-m_-7925472264348159960h5"><div dir="ltr">On Fri, Oct 5, 2018 at 9:34 AM Raghavendra Gowdappa <<a href="mailto:rgowdapp@redhat.com" target="_blank">rgowdapp@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Fri, Oct 5, 2018 at 9:11 AM Kaushal M <<a href="mailto:kshlmster@gmail.com" target="_blank">kshlmster@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, Oct 5, 2018 at 9:05 AM Raghavendra Gowdappa <<a href="mailto:rgowdapp@redhat.com" target="_blank">rgowdapp@redhat.com</a>> wrote:<br>
><br>
><br>
><br>
> On Fri, Oct 5, 2018 at 8:53 AM Amar Tumballi <<a href="mailto:atumball@redhat.com" target="_blank">atumball@redhat.com</a>> wrote:<br>
>><br>
>> Can you try below diff in your rfc, and let me know if it works?<br>
><br>
><br>
> No. it didn't. I see the same error.<br>
> [rgowdapp@rgowdapp glusterfs]$ ./rfc.sh<br>
> + rebase_changes<br>
> + GIT_EDITOR=./rfc.sh<br>
> + git rebase -i origin/master<br>
> [detached HEAD e50667e] cluster/dht: clang-format dht-common.c<br>
> 1 file changed, 10674 insertions(+), 11166 deletions(-)<br>
> rewrite xlators/cluster/dht/src/dht-common.c (88%)<br>
> [detached HEAD 0734847] cluster/dht: fixes to unlinking invalid linkto file<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
> [detached HEAD 7aeba07] rfc.sh: test - DO NOT MERGE<br>
> 1 file changed, 8 insertions(+), 3 deletions(-)<br>
> Successfully rebased and updated refs/heads/1635145.<br>
> + check_backport<br>
> + moveon=N<br>
> + '[' master = master ']'<br>
> + return<br>
> + assert_diverge<br>
> + git diff origin/master..HEAD<br>
> + grep -q .<br>
> ++ git log -n1 --format=%b<br>
> ++ grep -ow -E '([fF][iI][xX][eE][sS]|[uU][pP][dD][aA][tT][eE][sS])(:)?[[:space:]]+(gluster\/glusterfs)?(bz)?#[[:digit:]]+'<br>
> ++ awk -F '#' '{print $2}'<br>
> + reference=1635145<br>
> + '[' -z 1635145 ']'<br>
> ++ clang-format --version<br>
> + clang_format='LLVM (<a href="http://llvm.org/" rel="noreferrer" target="_blank">http://llvm.org/</a>):<br>
> LLVM version 3.4.2<br>
> Optimized build.<br>
> Built Dec 7 2015 (09:37:36).<br>
> Default target: x86_64-redhat-linux-gnu<br>
> Host CPU: x86-64'<br>
<br>
This is a pretty old version of clang. Maybe this is the problem?<br></blockquote><div><br></div><div>Yes. That's what I suspected too. Trying to get repos for the upgrade.<br></div></div></div></blockquote><div><br></div></div></div><div>But, what's surprising is that script exits.<br></div></div></div></blockquote><div><br></div><div>What is the return code of clang-format? If it is non-zero then script will silently exit because that is what</div><div>it is told to do.</div><div><br></div><div>`#!/bin/sh -e' means exit on error.</div></div></div></div></blockquote><div><br></div><div>You are right :).<br><br> [rgowdapp@rgowdapp glusterfs]$ clang-format --version ; echo $?<br>LLVM (<a href="http://llvm.org/">http://llvm.org/</a>):<br> LLVM version 3.4.2<br> Optimized build.<br> Built Dec 7 2015 (09:37:36).<br> Default target: x86_64-redhat-linux-gnu<br> Host CPU: x86-64<br>1<br><br></div><div>Wonder why clang-format --version has to return non-zero return code though.<br><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>-sac<br></div><br></div></div></div>
</blockquote></div></div></div>