<div dir="ltr">What is the agreed upon clang version for Glusterfs project? Is it clang-6?<br><br><div class="gmail_quote"><div dir="ltr">On Fri, Oct 5, 2018 at 1:58 PM Raghavendra Gowdappa <<a href="mailto:rgowdapp@redhat.com">rgowdapp@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div dir="ltr"><div>clang-4.0.1 pushes patch, but still doesn't understand some keys in clang-format.</div><div><br></div><div>[rgowdapp@rgowdapp glusterfs]$ ./rfc.sh </div><div>[detached HEAD 401a7b6] cluster/dht: clang-format dht-common.c</div><div> 1 file changed, 10674 insertions(+), 11166 deletions(-)</div><div> rewrite xlators/cluster/dht/src/dht-common.c (88%)</div><div>[detached HEAD 2bf5031] cluster/dht: fixes to unlinking invalid linkto file</div><div> 1 file changed, 236 insertions(+), 268 deletions(-)</div><div>Successfully rebased and updated refs/heads/1635145.</div><div>YAML:35:23: error: unknown key 'SplitEmptyFunction'</div><div> SplitEmptyFunction: true</div><div> ^~~~</div><div><br></div></div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Oct 5, 2018 at 10:47 AM Raghavendra Gowdappa <<a href="mailto:rgowdapp@redhat.com" target="_blank">rgowdapp@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">We should document (better still add checks in rfc.sh and warn user to upgrade) that we need clang version x or greater.<br></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Oct 5, 2018 at 10:45 AM Sachidananda URS <<a href="mailto:surs@redhat.com" target="_blank">surs@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 5, 2018 at 10:41 AM, Raghavendra Gowdappa <span dir="ltr"><<a href="mailto:rgowdapp@redhat.com" target="_blank">rgowdapp@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div dir="ltr">General options:<br><br> -help - Display available options (-help-hidden for more)<br> -help-list - Display list of available options (-help-list-hidden for more)<br> -version - Display the version of this program<br>[rgowdapp@rgowdapp ~]$ clang-format -version ; echo $?<span><br>LLVM (<a href="http://llvm.org/" target="_blank">http://llvm.org/</a>):<br> LLVM version 3.4.2<br> Optimized build.<br> Built Dec 7 2015 (09:37:36).<br> Default target: x86_64-redhat-linux-gnu<br> Host CPU: x86-64<br>1<br><br></span></div></div></blockquote><div><br></div>It is a bug then, which they've fixed later on. Upgrade is the only choice.</div><div class="gmail_quote"><br></div></div></div>
</blockquote></div>
</blockquote></div>
</blockquote></div></div>