<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Fri, Aug 10, 2018 at 5:59 PM Sankarshan Mukhopadhyay <<a href="mailto:sankarshan.mukhopadhyay@gmail.com">sankarshan.mukhopadhyay@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, Aug 10, 2018 at 5:47 PM, Nigel Babu <<a href="mailto:nigelb@redhat.com" target="_blank">nigelb@redhat.com</a>> wrote:<br>
> Hello folks,<br>
><br>
> We're currently in a transition to python3. Right now, there's a bug in one<br>
> piece of this transition code. I saw Nithya run into this yesterday. The<br>
> challenge here is, none of our testing for python2/python3 transition<br>
> catches this bug. Both Pylint and the ast-based testing that Kaleb<br>
> recommended does not catch this bug. The bug is trivial and would take 2<br>
> mins to fix, the challenge is that until we exercise almost all of these<br>
> code paths from both Python3 and Python2, we're not going to find out that<br>
> there are subtle breakages like this.<br>
><br>
<br>
Where is this great reveal - what is this above mentioned bug?<br>
<br>
> As far as I know, the three pieces where we use Python are geo-rep,<br>
> glusterfind, and libgfapi-python. My question:<br>
> * Are there more places where we run python?<br>
> * What sort of automated test coverage do we have for these components right<br>
> now?<br>
> * What can the CI team do to help identify problems? We have both Centos7<br>
> and Fedora28 builders, so we can definitely help run tests specific to<br>
> python.<br><br></blockquote><div><br></div><div>The bugs I mentioned in this email are now fixed: <a href="https://github.com/gluster/glusterfs/commit/bc61ee44a3f8a9bf0490605f62ec27fcd6a5b8d0">https://github.com/gluster/glusterfs/commit/bc61ee44a3f8a9bf0490605f62ec27fcd6a5b8d0</a><br></div><div><br></div><div>I still have no good answer to how what automated testing we have right now and what are the gaps for both glusterfind and geo-rep. I'd like to know what is the current state of automated testing and what's the future planned for both these bits of python code. Note, testing that python2 code is compliant with python3 has tooling. The reverse has no tooling (Though there's only 1y 4m left on the lock).<br></div></div><br>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr">nigelb<br></div></div></div>