<div><br></div><div><br><div class="gmail_quote"><div dir="ltr">On Mon, 6 Aug 2018 at 06:09, Sankarshan Mukhopadhyay <<a href="mailto:sankarshan.mukhopadhyay@gmail.com">sankarshan.mukhopadhyay@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Mon, Aug 6, 2018 at 5:17 AM, Amye Scavarda <<a href="mailto:amye@redhat.com" target="_blank">amye@redhat.com</a>> wrote:<br>
><br>
><br>
> On Sun, Aug 5, 2018 at 3:24 PM Shyam Ranganathan <<a href="mailto:srangana@redhat.com" target="_blank">srangana@redhat.com</a>><br>
> wrote:<br>
>><br>
>> On 07/31/2018 07:16 AM, Shyam Ranganathan wrote:<br>
>> > On 07/30/2018 03:21 PM, Shyam Ranganathan wrote:<br>
>> >> On 07/24/2018 03:12 PM, Shyam Ranganathan wrote:<br>
>> >>> 1) master branch health checks (weekly, till branching)<br>
>> >>> - Expect every Monday a status update on various tests runs<br>
>> >> See <a href="https://build.gluster.org/job/nightly-master/" rel="noreferrer" target="_blank">https://build.gluster.org/job/nightly-master/</a> for a report on<br>
>> >> various nightly and periodic jobs on master.<br>
>> > Thinking aloud, we may have to stop merges to master to get these test<br>
>> > failures addressed at the earliest and to continue maintaining them<br>
>> > GREEN for the health of the branch.<br>
>> ><br>
>> > I would give the above a week, before we lockdown the branch to fix the<br>
>> > failures.<br>
>> ><br>
>> > Let's try and get line-coverage and nightly regression tests addressed<br>
>> > this week (leaving mux-regression open), and if addressed not lock the<br>
>> > branch down.<br>
>> ><br>
>><br>
>> Health on master as of the last nightly run [4] is still the same.<br>
>><br>
>> Potential patches that rectify the situation (as in [1]) are bunched in<br>
>> a patch [2] that Atin and myself have put through several regressions<br>
>> (mux, normal and line coverage) and these have also not passed.<br>
>><br>
>> Till we rectify the situation we are locking down master branch commit<br>
>> rights to the following people, Amar, Atin, Shyam, Vijay.<br>
>><br>
>> The intention is to stabilize master and not add more patches that my<br>
>> destabilize it.<br>
>><br>
>> Test cases that are tracked as failures and need action are present here<br>
>> [3].<br>
>><br>
>> @Nigel, request you to apply the commit rights change as you see this<br>
>> mail and let the list know regarding the same as well.<br>
>><br>
>> Thanks,<br>
>> Shyam<br>
>><br>
>> [1] Patches that address regression failures:<br>
>> <a href="https://review.gluster.org/#/q/starredby:srangana%2540redhat.com" rel="noreferrer" target="_blank">https://review.gluster.org/#/q/starredby:srangana%2540redhat.com</a><br>
>><br>
>> [2] Bunched up patch against which regressions were run:<br>
>> <a href="https://review.gluster.org/#/c/20637" rel="noreferrer" target="_blank">https://review.gluster.org/#/c/20637</a><br>
>><br>
>> [3] Failing tests list:<br>
>><br>
>> <a href="https://docs.google.com/spreadsheets/d/1IF9GhpKah4bto19RQLr0y_Kkw26E_-crKALHSaSjZMQ/edit?usp=sharing" rel="noreferrer" target="_blank">https://docs.google.com/spreadsheets/d/1IF9GhpKah4bto19RQLr0y_Kkw26E_-crKALHSaSjZMQ/edit?usp=sharing</a><br>
>><br>
>> [4] Nightly run dashboard: <a href="https://build.gluster.org/job/nightly-master/" rel="noreferrer" target="_blank">https://build.gluster.org/job/nightly-master/</a><br>
<br>
><br>
> Locking master is fine, this seems like there's been ample notice and<br>
> conversation.<br>
> Do we have test criteria to indicate when we're unlocking master? X amount<br>
> of tests passing, Y amount of bugs?<br>
<br>
The "till we rectify" might just include 3 days of the entire set of<br>
tests passing - thinking out loud here.</blockquote><div dir="auto"><br></div><div dir="auto">3 days = 3 nightly regressions isn’t enough as most failures are spurious in nature (IMHO). What Shyam and I are doing is retriggering various regressions on top of patch [2] . We’re looking for atleast 10 iterations to go through with out any tests retry and failures.</div><div dir="auto"><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
<br>
-- <br>
sankarshan mukhopadhyay<br>
<<a href="https://about.me/sankarshan.mukhopadhyay" rel="noreferrer" target="_blank">https://about.me/sankarshan.mukhopadhyay</a>><br>
_______________________________________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
<a href="https://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">https://lists.gluster.org/mailman/listinfo/gluster-devel</a><br>
</blockquote></div></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature">--Atin</div>