<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 2, 2018 at 3:54 PM, Rafi Kavungal Chundattu Parambil <span dir="ltr"><<a href="mailto:rkavunga@redhat.com" target="_blank">rkavunga@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Yes, I think we can mark the test as bad for now. We found two issues that cause the failures.<br>
<br>
One issue is with the usage of anonymous fd from a fuse mount. posix acl which sits on the brick graph does the authentication check during open. But with anonymous FD's we may not have an explicit open received before let's a read fop. As a result, posix acl is not getting honoured with anonymous fd.<br>
<br>
The second issue is with snapd and libgfapi where it uses libgfapi to get the information from snapshot bricks. But uid, and gid's received from a client are not passed through libgfapi.<br>
<br>
I will fail two separate bugs to track this issue.<br>
<br>
Since both of this issues are not relevant to the fix which Raghavendra send, I agree to mark the tests as bad.<br></blockquote><div><br></div><div>Thanks Rafi.</div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="im HOEnZb"><br>
<br>
Regards<br>
Rafi KC<br>
<br>
<br>
----- Original Message -----<br>
From: "Raghavendra Gowdappa" <<a href="mailto:rgowdapp@redhat.com">rgowdapp@redhat.com</a>><br>
</span><span class="im HOEnZb">To: "Sunny Kumar" <<a href="mailto:sunkumar@redhat.com">sunkumar@redhat.com</a>>, "Rafi" <<a href="mailto:rkavunga@redhat.com">rkavunga@redhat.com</a>><br>
</span><span class="im HOEnZb">Cc: "Gluster Devel" <<a href="mailto:gluster-devel@gluster.org">gluster-devel@gluster.org</a>><br>
Sent: Thursday, August 2, 2018 3:23:00 PM<br>
Subject: Re: ./tests/bugs/snapshot/bug-<wbr>1167580-set-proper-uid-and-<wbr>gid-during-nfs-access.t fails if non-anonymous fds are used in read path<br>
<br>
</span><span class="im HOEnZb">I've filed a bug to track this failure:<br>
<a href="https://bugzilla.redhat.com/show_bug.cgi?id=1611532" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/<wbr>show_bug.cgi?id=1611532</a><br>
<br>
As a stop gap measure I propose to mark the test as Bad to unblock patches<br>
[1][2]. Are maintainers of snapshot in agreement with this?<br>
<br>
regards,<br>
Raghavendra<br>
<br>
On Wed, Aug 1, 2018 at 10:28 AM, Raghavendra Gowdappa <<a href="mailto:rgowdapp@redhat.com">rgowdapp@redhat.com</a>><br>
wrote:<br>
<br>
> Sunny/Rafi,<br>
><br>
> I was trying to debug regression failures on [1]. Note that patch [1] only<br>
> disables usage of anonymous fds on readv. So, I tried the same test<br>
> disabling performance.open-behind<br>
><br>
> [root@rhs-client27 glusterfs]# git diff<br>
> diff --git a/tests/bugs/snapshot/bug-<wbr>1167580-set-proper-uid-and-<wbr>gid-during-nfs-access.t<br>
</span><span class="im HOEnZb">> b/tests/bugs/snapshot/bug-<wbr>1167580-set-proper-uid-and-<br>
> gid-during-nfs-access.t<br>
> index 3776451..cedf96b 100644<br>
> --- a/tests/bugs/snapshot/bug-<wbr>1167580-set-proper-uid-and-<br>
> gid-during-nfs-access.t<br>
> +++ b/tests/bugs/snapshot/bug-<wbr>1167580-set-proper-uid-and-<br>
> gid-during-nfs-access.t<br>
</span><div class="HOEnZb"><div class="h5">> @@ -79,6 +79,7 @@ TEST $CLI volume start $V0<br>
> EXPECT_WITHIN $NFS_EXPORT_TIMEOUT "1" is_nfs_export_available<br>
> TEST glusterfs -s $H0 --volfile-id $V0 $M0<br>
> TEST mount_nfs $H0:/$V0 $N0 nolock<br>
> +TEST $CLI volume set $V0 performance.open-behind off<br>
><br>
> # Create 2 user<br>
> user1=$(get_new_user)<br>
><br>
><br>
> With the above change, I can see consistent failures of the test just like<br>
> observed in [1].<br>
><br>
> TEST 23 (line 154): Y check_if_permitted eeefadc<br>
> /mnt/glusterfs/0/.snaps/snap2/<wbr>file3 cat<br>
> su: warning: cannot change directory to /tmp/tmp.eaKBKS0lfM/eeefadc: No<br>
> such file or directory<br>
> cat: /mnt/glusterfs/0/.snaps/snap2/<wbr>file3: Permission denied<br>
> su: warning: cannot change directory to /tmp/tmp.eaKBKS0lfM/eeefadc: No<br>
> such file or directory<br>
> cat: /mnt/glusterfs/0/.snaps/snap2/<wbr>file3: Permission denied<br>
> su: warning: cannot change directory to /tmp/tmp.eaKBKS0lfM/eeefadc: No<br>
> such file or directory<br>
> cat: /mnt/glusterfs/0/.snaps/snap2/<wbr>file3: Permission denied<br>
> su: warning: cannot change directory to /tmp/tmp.eaKBKS0lfM/eeefadc: No<br>
> such file or directory<br>
> cat: /mnt/glusterfs/0/.snaps/snap2/<wbr>file3: Permission denied<br>
><br>
><br>
> Test Summary Report<br>
> -------------------<br>
> ./tests/bugs/snapshot/bug-<wbr>1167580-set-proper-uid-and-<wbr>gid-during-nfs-access.t<br>
> (Wstat: 0 Tests: 46 Failed: 1)<br>
> Failed test: 23<br>
><br>
><br>
> I had a feeling this test fails spuriously and the spurious nature is tied<br>
> with whether open-behind uses an anonymous fd or a regular fd for read.<br>
><br>
> @Sunny,<br>
><br>
> This test is blocking two of my patches - [1] and [2]. Can I mark this<br>
> test as bad and proceed with my work on [1] and [2]?<br>
><br>
> [1] <a href="https://review.gluster.org/20511" rel="noreferrer" target="_blank">https://review.gluster.org/<wbr>20511</a><br>
> [2] <a href="https://review.gluster.org/20428" rel="noreferrer" target="_blank">https://review.gluster.org/<wbr>20428</a><br>
><br>
> regards,<br>
> Raghavendra<br>
><br>
</div></div></blockquote></div><br></div></div>