<div><br><div class="gmail_quote"><div dir="auto">On Wed, 18 Apr 2018 at 10:43, Nigel Babu <<a href="mailto:nigelb@redhat.com">nigelb@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>I've reverted the original patch entirely. Our policy is to either mark the test as bad or revert the entire patch. This seems to have caused multiple failures in the test system, so I've reverted the entire patch. Please re-land the patch with any fixes as a fresh review.</div></blockquote><div dir="auto"><br></div><div dir="auto">Thanks Nigel.</div><div dir="auto"><br></div><div dir="auto">The patches waiting on the regression queue need to be rebased. Only doing a ‘recheck centos’ is not going to be helpful.</div><div dir="auto"><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><br><div class="gmail_extra"><br><div class="gmail_quote"></div></div></div><div><div class="gmail_extra"><div class="gmail_quote">On Wed, Apr 18, 2018 at 8:25 AM, Atin Mukherjee <span><<a href="mailto:amukherj@redhat.com" target="_blank">amukherj@redhat.com</a>></span> wrote:<br></div></div></div><div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div>commit d206fab73f6815c927a84171ee9361c9b31557b1<br>Author: Kinglong Mee <<a href="mailto:mijinlong@open-fs.com" target="_blank">mijinlong@open-fs.com</a>><br>Date: Mon Apr 9 08:33:51 2018 -0400<br><br> storage/posix: add pgfid in readdirp if needed<br> <br> Change-Id: I6745428fd9d4e402bf2cad52cee8ab46b7fd822f<br> fixes: bz#1560319<br> Signed-off-by: Kinglong Mee <<a href="mailto:mijinlong@open-fs.com" target="_blank">mijinlong@open-fs.com</a>><br><br><br></div>The above commit has caused (thanks to Amar for bisect!) trash.t test in upstream CI to fail very frequently. As per <a href="http://fstat.gluster.org" target="_blank">fstat.gluster.org</a> (refer :<a href="https://bit.ly/2qGcSP6" target="_blank">https://bit.ly/2qGcSP6</a>) this test has failed 17 times in master branch in last 4 days. Given we're nearing GlusterFS 4.1 branching and there're few important patches blocked in the regression pipeline queue, I've sent a patch <a href="https://review.gluster.org/19894" target="_blank">https://review.gluster.org/19894</a> to mark trash.t as bad for now as a temporary arrangement.<br><br></div>I request Kinglong and the owner of trash feature to debug this issue and send a fix which can revert back my change.<br><br></div>
<br></blockquote></div></div></div><div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">_______________________________________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org" target="_blank">Gluster-devel@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/mailman/listinfo/gluster-devel</a><br></blockquote></div></div></div><div><div class="gmail_extra"><br><br clear="all"><br>-- <br><div class="m_-6245977641139457549gmail_signature" data-smartmail="gmail_signature"><div>nigelb<br></div></div>
</div></div></blockquote></div></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature">- Atin (atinm)</div>