<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 5, 2018 at 7:10 PM, Shyam Ranganathan <span dir="ltr"><<a href="mailto:srangana@redhat.com" target="_blank">srangana@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">On 03/04/2018 10:15 PM, Pranith Kumar Karampuri wrote:<br>
> Shyam,<br>
> Do let me know if there is anything that needs to be done on the<br>
> process front.<br>
<br>
</span>I see that use-compound-fops is now deprecated, which is something that<br>
users need to be aware of.<br>
<br>
So when preparing release-notes, for when this change will hit a release<br>
(or are you intending to backport this?), we need to call out the same.<br>
The process for such a change is to look for github issues across the<br>
commits, and will get missed if this is a bug.<br>
<br>
At times bugs are fine, but again in this case, the bug reads eager lock<br>
changes, and the commit is to remove compounding. So users again may not<br>
be aware of the change looking at the bug list.<br>
<br>
So overall, from a process (and a release) standpoint, I would have<br>
preferred a github issue (or a bug, which for this change seems not to<br>
be the case), that calls out that this feature is to be deprecated/disabled.<br></blockquote><div><br></div><div>Patch is yet to be merged. I am waiting for any further comments on this thread.</div><div>I will change the patch to use the following github issue. I also added some history</div><div>and reasoning as to why I am of the opinion to remove it now on the issue.</div><div><br></div><div><a href="https://github.com/gluster/glusterfs/issues/414">https://github.com/gluster/glusterfs/issues/414</a><br></div><div><br></div><div>I will wait till tomorrow morning IST before merging the patch in case there are no</div><div>further comments.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
HTH.<br>
<span class="gmail-"><br>
><br>
> On Mon, Mar 5, 2018 at 8:18 AM, Pranith Kumar Karampuri<br>
</span><span class="gmail-">> <<a href="mailto:pkarampu@redhat.com">pkarampu@redhat.com</a> <mailto:<a href="mailto:pkarampu@redhat.com">pkarampu@redhat.com</a>>> wrote:<br>
><br>
> hi,<br>
> We found that compound fops is not giving better performance<br>
> in replicate and I am thinking of removing that code. Sent the patch<br>
</span>> at <a href="https://review.gluster.org/19655" rel="noreferrer" target="_blank">https://review.gluster.org/<wbr>19655</a> <<a href="https://review.gluster.org/19655" rel="noreferrer" target="_blank">https://review.gluster.org/<wbr>19655</a>><br>
><br>
> --<br>
> Pranith<br>
><br>
><br>
><br>
<span class="gmail-HOEnZb"><font color="#888888">><br>
> --<br>
> Pranith<br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature"><div dir="ltr">Pranith<br></div></div>
</div></div>